New issue
Advanced search Search tips

Issue 714018 link

Starred by 10 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Migrate from base::Bind() to base::BindOnce() or base::BindRepeating()

Project Member Reported by tzik@chromium.org, Apr 21 2017

Issue description

This is an umbrella bug to track the progress of the migration.

Bind(), BindOnce() and BindRepeating() create Callback, OnceCallback, and RepeatingCallback respectively.
Bind() and Callback are currently used. BindOnce() and OnceCallback are next-gen. BindRepeating() and RepeatingCallback are aliases to Bind() and Callback.
See https://chromium.googlesource.com/chromium/src/+/master/docs/callback.md for details.

OnceCallback is move-only, and can be called at most once (clobbered on the first call).
As it has clear lifetime and better move-only type handling, I'm proposing to migrate most of Bind/Callback to BindOnce/OnceCallback.

We already have BindOnce/OnceCallback implementation, PostTask impls can take OnceCallback, Mojo code generator has use_once_callback flag to switch the interface, and some clang-based refactoring tools are in //tools/clang. So, I consider it's ready to start the mass migration.

 
Showing comments 138 - 237 of 237 Older
Project Member

Comment 138 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/084f1aee90def7edd1ed28e876da5bd063df1f73

commit 084f1aee90def7edd1ed28e876da5bd063df1f73
Author: Miguel Casas <mcasas@chromium.org>
Date: Thu Feb 01 18:25:29 2018

GpuMemoryBufferVideoFramePool: use BindOnce/OnceCallback

Every git cl upload I get a bunch of presubmits like:

Please consider using base::Bind{Once,Repeating} instead of base::Bind. (crbug.com/714018)

So this CL does the transition: Bind --> BindOnce,
Closure --> OnceClosure, Callback --> OnceCallback, use
of Base::Passed(), in method signatures, we change const &
to moving the argument, and instead Run()ning the Callback
we use std::move(cb).Run().

Threw in a few consts where applicable.  No new code otherwise,
tests (and asan etc) should cover it all.

Bug: 803975, 714018

Change-Id: I48338984a99627b5de34c5da45dadbdc7c0409e5
Reviewed-on: https://chromium-review.googlesource.com/893822
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533741}
[modify] https://crrev.com/084f1aee90def7edd1ed28e876da5bd063df1f73/content/renderer/media/media_stream_video_renderer_sink_unittest.cc
[modify] https://crrev.com/084f1aee90def7edd1ed28e876da5bd063df1f73/media/renderers/video_renderer_impl_unittest.cc
[modify] https://crrev.com/084f1aee90def7edd1ed28e876da5bd063df1f73/media/video/gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/084f1aee90def7edd1ed28e876da5bd063df1f73/media/video/gpu_memory_buffer_video_frame_pool.h
[modify] https://crrev.com/084f1aee90def7edd1ed28e876da5bd063df1f73/media/video/gpu_memory_buffer_video_frame_pool_unittest.cc
[modify] https://crrev.com/084f1aee90def7edd1ed28e876da5bd063df1f73/media/video/mock_gpu_memory_buffer_video_frame_pool.cc
[modify] https://crrev.com/084f1aee90def7edd1ed28e876da5bd063df1f73/media/video/mock_gpu_memory_buffer_video_frame_pool.h

Project Member

Comment 139 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b2a60479fe5f57b674f3c0aaf870e566eed9018

commit 2b2a60479fe5f57b674f3c0aaf870e566eed9018
Author: Matt Menke <mmenke@chromium.org>
Date: Wed Feb 07 02:12:12 2018

Make EmbeddedTestServer use RepeatingCallbacks.

HandleRequestCallbacks and MonitorRequestCallback are now explicitly
RepeatingCallbacks instead of just base::Callbacks. Also update some
consumers of those APIs in net/ to use BindRepeating, though there are
still a great number outside of net/ that just use Bind.

Bug: 714018
Change-Id: I473c7f3128b3398e97c2c587e5b70bf51cde83fa
Reviewed-on: https://chromium-review.googlesource.com/900186
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534880}
[modify] https://crrev.com/2b2a60479fe5f57b674f3c0aaf870e566eed9018/net/test/embedded_test_server/controllable_http_response.cc
[modify] https://crrev.com/2b2a60479fe5f57b674f3c0aaf870e566eed9018/net/test/embedded_test_server/default_handlers.cc
[modify] https://crrev.com/2b2a60479fe5f57b674f3c0aaf870e566eed9018/net/test/embedded_test_server/embedded_test_server.h
[modify] https://crrev.com/2b2a60479fe5f57b674f3c0aaf870e566eed9018/net/test/embedded_test_server/embedded_test_server_unittest.cc
[modify] https://crrev.com/2b2a60479fe5f57b674f3c0aaf870e566eed9018/net/url_request/url_request_quic_perftest.cc
[modify] https://crrev.com/2b2a60479fe5f57b674f3c0aaf870e566eed9018/net/url_request/url_request_unittest.cc

Project Member

Comment 140 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac

commit 6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac
Author: Mikel Astiz <mastiz@chromium.org>
Date: Wed Feb 07 10:46:38 2018

Refactor to adopt OnceCallback in USS ModelTypeStore API

This is a manually generated patch to update a widely used class in USS,
which prevents new datatypes from properly adopting OnceCallback in
their internals.

No behavioral differences.

Bug: 714018
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If5c63f0c180e077980a74a9dd60def7b9171def4
Reviewed-on: https://chromium-review.googlesource.com/897865
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534978}
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/chrome/browser/chromeos/printing/printers_sync_bridge.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/chrome/browser/chromeos/printing/printers_sync_bridge.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/chrome/browser/chromeos/printing/synced_printers_manager_factory.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/chrome/browser/sync/user_event_service_factory.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/reading_list/core/reading_list_model_storage.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/reading_list/core/reading_list_store.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/reading_list/core/reading_list_store.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/device_info/device_info_sync_bridge.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/device_info/device_info_sync_bridge.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/device_info/device_info_sync_bridge_unittest.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model/mock_model_type_store.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model/mock_model_type_store.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model/model_type_store.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model/model_type_store.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model/model_type_store_test_util.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model/model_type_store_test_util.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model_impl/model_type_store_impl.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/model_impl/model_type_store_impl.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/user_events/user_event_sync_bridge.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/components/sync/user_events/user_event_sync_bridge.h
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/ios/chrome/browser/reading_list/reading_list_model_factory.cc
[modify] https://crrev.com/6bd0344aa74cb498dbe47a3f23ebd397cb6e0cac/ios/chrome/browser/sync/ios_user_event_service_factory.cc

Project Member

Comment 141 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f2d2c1363b3974abfaabce87f076299f1faf8c9

commit 8f2d2c1363b3974abfaabce87f076299f1faf8c9
Author: David Benjamin <davidben@chromium.org>
Date: Tue Feb 27 00:08:26 2018

Use OnceCallback with SSLPrivateKey.

Bug: 714018
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icb3d2393ddf8cec56ceeb7a8c1adb1fe1be3b7ef
Reviewed-on: https://chromium-review.googlesource.com/935781
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539313}
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/chrome/browser/chromeos/certificate_provider/certificate_provider_service.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/chrome/browser/chromeos/certificate_provider/certificate_provider_service.h
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/chrome/browser/chromeos/certificate_provider/sign_requests.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/chrome/browser/chromeos/certificate_provider/sign_requests.h
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/content/browser/ssl_private_key_impl.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/net/socket/ssl_client_socket_impl.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/net/ssl/ssl_client_auth_cache_unittest.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/net/ssl/ssl_private_key.h
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/net/ssl/ssl_private_key_test_util.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/net/ssl/threaded_ssl_private_key.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/net/ssl/threaded_ssl_private_key.h
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/net/url_request/url_request_unittest.cc
[modify] https://crrev.com/8f2d2c1363b3974abfaabce87f076299f1faf8c9/services/network/url_loader.cc

Project Member

Comment 142 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e68b97ad3c51bda122028a28ad834e7a3d88673b

commit e68b97ad3c51bda122028a28ad834e7a3d88673b
Author: Scott Violet <sky@chromium.org>
Date: Thu Mar 01 21:44:20 2018

Starts moving services/ui/public/interfaces to OnceCallback

While migrating I'm introducing a temporary target. Eventually this
temporary target will become the real one.

BUG=714018
TEST=none

Change-Id: Iaf1ed6577e595c031f491099ad249ce8595d7169
Reviewed-on: https://chromium-review.googlesource.com/942661
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540298}
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/content/browser/gpu/browser_gpu_memory_buffer_manager.cc
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/content/browser/gpu/browser_gpu_memory_buffer_manager.h
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/content/browser/gpu/gpu_client.cc
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/content/browser/gpu/gpu_client.h
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/services/ui/clipboard/clipboard_impl.cc
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/services/ui/clipboard/clipboard_impl.h
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/services/ui/public/cpp/tests/gpu_unittest.cc
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/services/ui/ws/gpu_client.cc
[modify] https://crrev.com/e68b97ad3c51bda122028a28ad834e7a3d88673b/services/ui/ws/gpu_client.h

Project Member

Comment 143 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19d884b6ce9a9696b23946b00250fa92cfaf0243

commit 19d884b6ce9a9696b23946b00250fa92cfaf0243
Author: Scott Violet <sky@chromium.org>
Date: Fri Mar 02 23:51:20 2018

Moves ui_controls to OnceCallback

BUG=714018
TEST=none

Change-Id: Ia0dadc31d6713b3df042d5f434bfa2165146b072
Reviewed-on: https://chromium-review.googlesource.com/946855
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540688}
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ash/drag_drop/drag_drop_interactive_uitest.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ash/test/ui_controls_factory_ash.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/browser/ui/views/menu_test_base.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/browser/ui/views/menu_test_base.h
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/test/base/interactive_test_utils.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/test/base/interactive_test_utils.h
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/test/base/interactive_test_utils_cocoa.mm
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/test/base/interactive_test_utils_common_views.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/chrome/test/base/view_event_test_base.h
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/aura/test/ui_controls_factory_aurawin.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/aura/test/ui_controls_factory_aurax11.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/aura/test/ui_controls_factory_ozone.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/base/test/ui_controls.h
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/base/test/ui_controls_aura.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/base/test/ui_controls_aura.h
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/base/test/ui_controls_internal_win.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/base/test/ui_controls_internal_win.h
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/base/test/ui_controls_mac.mm
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/base/test/ui_controls_win.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/events/test/platform_event_waiter.cc
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/events/test/platform_event_waiter.h
[modify] https://crrev.com/19d884b6ce9a9696b23946b00250fa92cfaf0243/ui/views/test/ui_controls_factory_desktop_aurax11.cc

Project Member

Comment 144 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b30e16c583a7db293ef42088b4e210b70fa6b80

commit 8b30e16c583a7db293ef42088b4e210b70fa6b80
Author: Scott Violet <sky@chromium.org>
Date: Tue Mar 06 03:52:25 2018

WindowServices: moves a couple more interfaces to OnceCallback

BUG=714018
TEST=none

Change-Id: I6c8f6644a55fecccadf6257cd908404ca5bb7250
Reviewed-on: https://chromium-review.googlesource.com/947807
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541039}
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/ash/app_launch_unittest.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/test_utils.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/test_utils.h
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/window_server.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/window_server.h
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/window_server_test_impl.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/window_server_test_impl.h
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/window_tree.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/window_tree.h
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/ui/aura/test/mus/test_window_manager_client.cc
[modify] https://crrev.com/8b30e16c583a7db293ef42088b4e210b70fa6b80/ui/aura/test/mus/test_window_manager_client.h

Project Member

Comment 145 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb59b54fe98053d40c736644da40ef4b5ab4c2a9

commit bb59b54fe98053d40c736644da40ef4b5ab4c2a9
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Tue Mar 06 05:05:18 2018

Revert "WindowServices: moves a couple more interfaces to OnceCallback"

This reverts commit 8b30e16c583a7db293ef42088b4e210b70fa6b80.

Reason for revert: Causing failure on "Android Build" bot:
https://ci.chromium.org/buildbot/chromium/Android/82487

Original change's description:
> WindowServices: moves a couple more interfaces to OnceCallback
> 
> BUG=714018
> TEST=none
> 
> Change-Id: I6c8f6644a55fecccadf6257cd908404ca5bb7250
> Reviewed-on: https://chromium-review.googlesource.com/947807
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541039}

TBR=sky@chromium.org,msw@chromium.org

Change-Id: I626381e7df397ed4a9ea2823c85440599be811db
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714018
Reviewed-on: https://chromium-review.googlesource.com/949943
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541042}
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/ash/app_launch_unittest.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/test_utils.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/test_utils.h
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/window_server.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/window_server.h
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/window_server_test_impl.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/window_server_test_impl.h
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/window_tree.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/window_tree.h
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/ui/aura/test/mus/test_window_manager_client.cc
[modify] https://crrev.com/bb59b54fe98053d40c736644da40ef4b5ab4c2a9/ui/aura/test/mus/test_window_manager_client.h

Project Member

Comment 146 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dbe371300a52c2b64818966f776f281db16c20b

commit 3dbe371300a52c2b64818966f776f281db16c20b
Author: Scott Violet <sky@chromium.org>
Date: Tue Mar 06 20:10:28 2018

Moves remaining ui interfaces to once-callback

BUG=714018
TEST=none

Change-Id: I29070e75f7040f50f8e4b2c0e4fd738913a4cf76
Reviewed-on: https://chromium-review.googlesource.com/949086
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541179}
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ash/app_launch_unittest.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/content/renderer/mus/renderer_window_tree_client.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/content/renderer/mus/renderer_window_tree_client.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/public/interfaces/BUILD.gn
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/remote_event_dispatcher.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/remote_event_dispatcher.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/test_utils.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/test_utils.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/window_server.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/window_server.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/window_server_test_impl.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/window_server_test_impl.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/window_tree.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/window_tree.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/event_injector.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/test/mus/test_window_manager_client.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/test/mus/test_window_manager_client.h
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/3dbe371300a52c2b64818966f776f281db16c20b/ui/aura/test/mus/test_window_tree.h

Project Member

Comment 147 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa0c131b877393afa8b8b43cc51736eba1612155

commit fa0c131b877393afa8b8b43cc51736eba1612155
Author: tzik <tzik@chromium.org>
Date: Wed Mar 07 04:44:52 2018

Apply base_bind_rewriters to //device

This CL applies //tools/clang/base_bind_rewriters to //device.
It rewrites base::Bind to base::BindOnce where the resulting base::Callback
is immediately converted to base::OnceCallback, which is considered safe
to use base::BindOnce.

E.g.:
  base::PostTask(FROM_HERE, base::Bind([]{}));
  base::OnceClosure cb = base::Bind([]{});
are converted to:
  base::PostTask(FROM_HERE, base::BindOnce([]{}));
  base::OnceClosure cb = base::BindOnce([]{});

This reduces the number of 'base::Bind' in //device from 1038 to 822,
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: Id89004a2a3ad042bd91f80712ceb1090a4b36691
Reviewed-on: https://chromium-review.googlesource.com/950962
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541339}
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/bluetooth_adapter_factory_wrapper.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/bluetooth_remote_gatt_characteristic.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/bluetooth_socket_net.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/bluez/bluetooth_socket_bluez.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_adapter_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_agent_manager_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_device_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_gatt_characteristic_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_gatt_descriptor_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_gatt_manager_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_le_advertising_manager_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_media_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_media_transport_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluetooth_profile_manager_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/bluez_dbus_manager.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/fake_bluetooth_device_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/fake_bluetooth_gatt_service_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/dbus/fake_bluetooth_profile_manager_client.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/device_unittest.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/test/fake_peripheral.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/test/fake_remote_gatt_characteristic.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/bluetooth/test/fake_remote_gatt_descriptor.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/fido/u2f_hid_device_unittest.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/fido/u2f_register.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/fido/u2f_request.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/fido/u2f_sign.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/gamepad/gamepad_provider.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/gamepad/gamepad_service.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/geolocation/fake_location_provider.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/geolocation/geolocation_impl.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/geolocation/geolocation_provider_impl.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/geolocation/geolocation_provider_impl_unittest.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/geolocation/network_location_provider.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/geolocation/wifi_data_provider.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/geolocation/wifi_data_provider_common.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/test/usb_test_gadget_impl.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/mojo/device_impl_unittest.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/mojo/device_manager_impl_unittest.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/usb_descriptors_unittest.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/usb_device_handle_unittest.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/usb_device_handle_usbfs.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/usb_service.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/usb_service_linux.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/usb_string_read_fuzzer.cc
[modify] https://crrev.com/fa0c131b877393afa8b8b43cc51736eba1612155/device/usb/webusb_descriptors.cc

Project Member

Comment 148 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d16d21967cf0f3ce56953762af7a8125de81aebf

commit d16d21967cf0f3ce56953762af7a8125de81aebf
Author: tzik <tzik@chromium.org>
Date: Wed Mar 07 08:58:36 2018

Migrate //sql from base::Callback to base::RepeatingCallback

This updates //sql to use base::RepeatingCallback instead of legacy
base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //sql from 19 to 1
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I4b6b321e25f2b3db7ab7ac3e09d9ee74761db230
Reviewed-on: https://chromium-review.googlesource.com/952116
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541388}
[modify] https://crrev.com/d16d21967cf0f3ce56953762af7a8125de81aebf/sql/connection.h
[modify] https://crrev.com/d16d21967cf0f3ce56953762af7a8125de81aebf/sql/connection_unittest.cc
[modify] https://crrev.com/d16d21967cf0f3ce56953762af7a8125de81aebf/sql/recovery_unittest.cc
[modify] https://crrev.com/d16d21967cf0f3ce56953762af7a8125de81aebf/sql/sqlite_features_unittest.cc
[modify] https://crrev.com/d16d21967cf0f3ce56953762af7a8125de81aebf/sql/statement_unittest.cc
[modify] https://crrev.com/d16d21967cf0f3ce56953762af7a8125de81aebf/sql/test/error_callback_support.h
[modify] https://crrev.com/d16d21967cf0f3ce56953762af7a8125de81aebf/sql/test/scoped_error_expecter.cc

Project Member

Comment 149 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b

commit 4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b
Author: tzik <tzik@chromium.org>
Date: Wed Mar 07 14:08:15 2018

Migrate UnitTestLauncher to base::OnceCallback

This migrates base::LaunchUnitTests and its relatives to OnceCallback.
UnitTestLauncher is a blocker for a small number of components to
migrate to OnceCallback, but it's the last blocker for some components.

Bug: 714018
Change-Id: I0158f64201c7b4382726331df59fa4101fa1042b
Reviewed-on: https://chromium-review.googlesource.com/951023
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541421}
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/base/test/launcher/unit_test_launcher.cc
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/base/test/launcher/unit_test_launcher.h
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/base/test/launcher/unit_test_launcher_ios.cc
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/base/test/launcher/unit_test_launcher_nacl_nonsfi.cc
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/base/test/run_all_unittests.cc
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/components/test/run_all_unittests.cc
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/services/service_manager/public/cpp/test/common_initialization.cc
[modify] https://crrev.com/4c2a4cd78bac62cdfbf06aa80c2d86ccec0ba68b/services/service_manager/public/cpp/test/common_initialization.h

Project Member

Comment 150 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6934a31e7f675e3bd97b1646cb48dc1ab454ad10

commit 6934a31e7f675e3bd97b1646cb48dc1ab454ad10
Author: tzik <tzik@chromium.org>
Date: Thu Mar 08 01:03:16 2018

Migrate //gin from base::Callback to base::{Once,Repeating}Callback

This updates //gin to use base::OnceCallback or base::RepeatingCallback
instead of legacy base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //gin from 8 to 1
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I5c4bb758181c09e2d7b0e2fec5c51a4e1eec24bb
Reviewed-on: https://chromium-review.googlesource.com/952646
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541664}
[modify] https://crrev.com/6934a31e7f675e3bd97b1646cb48dc1ab454ad10/gin/arguments_unittest.cc
[modify] https://crrev.com/6934a31e7f675e3bd97b1646cb48dc1ab454ad10/gin/data_object_builder_unittest.cc
[modify] https://crrev.com/6934a31e7f675e3bd97b1646cb48dc1ab454ad10/gin/interceptor_unittest.cc
[modify] https://crrev.com/6934a31e7f675e3bd97b1646cb48dc1ab454ad10/gin/shell/gin_main.cc

Project Member

Comment 151 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25c274e606d77869bdd5fc786154f2aaa5a0ecc2

commit 25c274e606d77869bdd5fc786154f2aaa5a0ecc2
Author: tzik <tzik@chromium.org>
Date: Thu Mar 08 02:32:59 2018

Migrate //rlz from base::Callback to base::OnceCallback

This updates //rlz to use base::OnceCallback instead of legacy
base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //rlz from 3 to 0,
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I4a016a47acfae635ff4ed0c3b2f22c0ca62b8f5c
Reviewed-on: https://chromium-review.googlesource.com/952729
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541697}
[modify] https://crrev.com/25c274e606d77869bdd5fc786154f2aaa5a0ecc2/rlz/lib/financial_ping.cc

Project Member

Comment 152 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07f906326cdc12e9d092fa67c66e1909d69a9feb

commit 07f906326cdc12e9d092fa67c66e1909d69a9feb
Author: tzik <tzik@chromium.org>
Date: Thu Mar 08 03:02:02 2018

Migrate //chrome/browser/extensions/activity_log to OnceCallback

This updates //chrome/browser/extensions/activity_log to use
base::OnceCallback instead of legacy base::Callback. No intended
functional change is included.

This reduces the number of 'base::Bind' in
//chrome/browser/extensions/activity_log from 69 to 0 as tracked at
http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I4fe44c7fada907f3a1c70971067c29f0d5492e8f
Reviewed-on: https://chromium-review.googlesource.com/952953
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541703}
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/activity_log.cc
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/activity_log.h
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/activity_log_policy.h
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/activity_log_unittest.cc
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/counting_policy.cc
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/counting_policy.h
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/counting_policy_unittest.cc
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/fullstream_ui_policy.cc
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/fullstream_ui_policy.h
[modify] https://crrev.com/07f906326cdc12e9d092fa67c66e1909d69a9feb/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc

Project Member

Comment 153 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0881a4004e43c90129661c5bf452a5a881771190

commit 0881a4004e43c90129661c5bf452a5a881771190
Author: tzik <tzik@chromium.org>
Date: Thu Mar 08 06:19:49 2018

Migrate //courgette to RepeatingCallback

This updates //courgette to use base::RepeatingCallback instead of
legacy base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //courgette from 3 to 0 as
tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I40ec7c5cd7486f6b1110f13e35fd0368a4db9f3c
Reviewed-on: https://chromium-review.googlesource.com/954886
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541735}
[modify] https://crrev.com/0881a4004e43c90129661c5bf452a5a881771190/courgette/adjustment_method_unittest.cc
[modify] https://crrev.com/0881a4004e43c90129661c5bf452a5a881771190/courgette/disassembler_elf_32.cc
[modify] https://crrev.com/0881a4004e43c90129661c5bf452a5a881771190/courgette/disassembler_win32.cc
[modify] https://crrev.com/0881a4004e43c90129661c5bf452a5a881771190/courgette/instruction_utils.h

Project Member

Comment 154 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b30851c6c16fec292213d2d8fef70779656b905f

commit b30851c6c16fec292213d2d8fef70779656b905f
Author: Avi Drissman <avi@chromium.org>
Date: Thu Mar 08 20:34:33 2018

Update WebContents::RequestAXTreeSnapshot() to OnceCallback.

BUG=714018

Change-Id: Ic6fa05a2ebd6ca21bd1b2a349a58f7a419a3465d
Reviewed-on: https://chromium-review.googlesource.com/952991
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541881}
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/content/browser/accessibility/snapshot_ax_tree_browsertest.cc
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/b30851c6c16fec292213d2d8fef70779656b905f/content/public/browser/web_contents.h

Project Member

Comment 155 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88b34c8f0ae71ec3d82fabbce54c2a234b5cd225

commit 88b34c8f0ae71ec3d82fabbce54c2a234b5cd225
Author: tzik <tzik@chromium.org>
Date: Fri Mar 09 05:01:13 2018

Migrate //crypto from base::Callback to base::OnceCallback

This updates //crypto to use base::OnceCallback instead of legacy
base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //crypto from 3 to 0,
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I020993c154a0706a262543937d9ebe506ea01c25
Reviewed-on: https://chromium-review.googlesource.com/952507
Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542030}
[modify] https://crrev.com/88b34c8f0ae71ec3d82fabbce54c2a234b5cd225/crypto/nss_util.cc
[modify] https://crrev.com/88b34c8f0ae71ec3d82fabbce54c2a234b5cd225/crypto/nss_util.h
[modify] https://crrev.com/88b34c8f0ae71ec3d82fabbce54c2a234b5cd225/crypto/nss_util_internal.h

Project Member

Comment 156 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea7713cdaab0a396e9bae3626e5c0c06cba9c9e8

commit ea7713cdaab0a396e9bae3626e5c0c06cba9c9e8
Author: tzik <tzik@chromium.org>
Date: Fri Mar 09 09:39:09 2018

Migrate //printing to OnceCallback

This updates //printing to use base::OnceCallback instead of legacy
base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //printing from 2 to 0 as
tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: Ic5ba394447c20b444d238511473bbfc7abbc9669
Reviewed-on: https://chromium-review.googlesource.com/954883
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542071}
[modify] https://crrev.com/ea7713cdaab0a396e9bae3626e5c0c06cba9c9e8/printing/printing_context_win.cc
[modify] https://crrev.com/ea7713cdaab0a396e9bae3626e5c0c06cba9c9e8/printing/printing_context_win_unittest.cc

Project Member

Comment 157 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9b7ab57f150fd4386e5d32ad3c86b39ccd863fe

commit f9b7ab57f150fd4386e5d32ad3c86b39ccd863fe
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Mar 09 23:36:01 2018

Move away from base::Bind in //services/ui/service.cc

This CL moves aways from the use of base::Bind from
//services/ui/service.cc.

BUG=714018

Change-Id: Id7dd062c7e54fc59e7a92fe8173195bdbaa84356
Reviewed-on: https://chromium-review.googlesource.com/957162
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#542278}
[modify] https://crrev.com/f9b7ab57f150fd4386e5d32ad3c86b39ccd863fe/services/ui/service.cc

Project Member

Comment 158 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7adad1a9beba22548fa75e1936bf174d0de66f4

commit f7adad1a9beba22548fa75e1936bf174d0de66f4
Author: tzik <tzik@chromium.org>
Date: Sat Mar 10 20:31:01 2018

Migrate //headless to OnceCallback

This updates //headless to use base::OnceCallback instead of legacy
base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //headless from 142 to 21,
and //out/Release/gen from 1011 to 466 as tracked at
http://goo.gl/LUVhDj

Bug: 714018
Change-Id: Id4ed7a54b9aab6fb649e8bf160b54595daadda88
Reviewed-on: https://chromium-review.googlesource.com/956791
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542387}
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/app/headless_example.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/app/headless_shell.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/app/shell_navigation_request.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/devtools_api/domain_cc.template
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/devtools_api/domain_h.template
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_browser_context_impl.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_browser_context_options.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_browser_context_options.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_browser_impl.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_browser_impl.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_content_browser_client.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_devtools_client_impl.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_print_manager.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_print_manager.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_tab_socket_impl.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_tab_socket_impl.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/browser/headless_web_contents_impl.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/headless_browser_browsertest.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/headless_browser_context_browsertest.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/lib/headless_web_contents_browsertest.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/headless_browser.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/headless_browser.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/headless_browser_context.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/headless_tab_socket.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/headless_web_contents.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/internal/headless_devtools_client_impl.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/internal/message_dispatcher.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/black_hole_protocol_handler.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/compositor_controller.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/compositor_controller.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/deterministic_dispatcher.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/expedited_dispatcher.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/generic_url_request_job.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/generic_url_request_job_test.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/in_memory_request_job.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/throttled_dispatcher.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/public/util/virtual_time_controller.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/headless_browser_test.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/headless_browser_test.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/headless_js_bindings_browsertest.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/headless_render_browsertest.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/headless_render_test.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/headless_render_test.h
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/headless_test_launcher.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/tab_socket_test.cc
[modify] https://crrev.com/f7adad1a9beba22548fa75e1936bf174d0de66f4/headless/test/tab_socket_test.h

Project Member

Comment 159 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4373d4bcfd831b9a42b06ab9caab43e27386ff12

commit 4373d4bcfd831b9a42b06ab9caab43e27386ff12
Author: tzik <tzik@chromium.org>
Date: Tue Mar 13 04:42:06 2018

Apply base_bind_rewriters to //chrome/browser/extensions

This CL applies //tools/clang/base_bind_rewriters to
//chrome/browser/extensions.
It rewrites base::Bind to base::BindOnce where the resulting base::Callback
is immediately converted to base::OnceCallback, which is considered safe
to use base::BindOnce.

E.g.:
  base::PostTask(FROM_HERE, base::Bind([]{}));
  base::OnceClosure cb = base::Bind([]{});
are converted to:
  base::PostTask(FROM_HERE, base::BindOnce([]{}));
  base::OnceClosure cb = base::BindOnce([]{});

This reduces the number of 'base::Bind' in //device from from 648 to 612
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I1a92511d1fa36f9fb2ed048c8e44ca4247b46e78
Reviewed-on: https://chromium-review.googlesource.com/952404
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542727}
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/history/history_api.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/identity/identity_get_accounts_function.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/image_writer_private/unzip_helper.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/messaging/native_message_process_host.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/app_data_migrator_unittest.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/chrome_app_icon_service.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/extension_disabled_ui.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/4373d4bcfd831b9a42b06ab9caab43e27386ff12/chrome/browser/extensions/navigation_observer_browsertest.cc

Project Member

Comment 160 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91bae81a2da6970eccd7b11e45a23909bd86d23d

commit 91bae81a2da6970eccd7b11e45a23909bd86d23d
Author: tzik <tzik@chromium.org>
Date: Tue Mar 13 09:13:48 2018

Migrate LaunchUnitTests callers to OnceCallback

This updates callers of base::LaunchUnitTests in several directory
to use base::OnceCallback instead of legacy base::Callback.
No intended functional change is included.

This reduces the number of 'base::Bind' in //gin, //notification_helper,
//pdf, //sql, //url, and //chrome_elf from 7 to 0 as tracked at
http://goo.gl/LUVhDj

Bug: 714018
Change-Id: Ie1bf3ad1ca90f732356d4612cfd8e3e8eca8afda
Reviewed-on: https://chromium-review.googlesource.com/954882
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542743}
[modify] https://crrev.com/91bae81a2da6970eccd7b11e45a23909bd86d23d/gin/test/run_all_unittests.cc
[modify] https://crrev.com/91bae81a2da6970eccd7b11e45a23909bd86d23d/pdf/run_all_unittests.cc
[modify] https://crrev.com/91bae81a2da6970eccd7b11e45a23909bd86d23d/sql/test/run_all_unittests.cc
[modify] https://crrev.com/91bae81a2da6970eccd7b11e45a23909bd86d23d/url/run_all_unittests.cc

Project Member

Comment 161 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22a9de0c0dd4b46c22f4168f7c07b09c84953b69

commit 22a9de0c0dd4b46c22f4168f7c07b09c84953b69
Author: tzik <tzik@chromium.org>
Date: Wed Mar 14 02:04:07 2018

Apply base_bind_rewriters to //chromecast

This CL applies //tools/clang/base_bind_rewriters to
//chrome/browser/extensions.
It rewrites base::Bind to base::BindOnce where the resulting base::Callback
is immediately converted to base::OnceCallback, which is considered safe
to use base::BindOnce.

E.g.:
  base::PostTask(FROM_HERE, base::Bind([]{}));
  base::OnceClosure cb = base::Bind([]{});
are converted to:
  base::PostTask(FROM_HERE, base::BindOnce([]{}));
  base::OnceClosure cb = base::BindOnce([]{});

This reduces the number of 'base::Bind' in //chromecast from from 186 to 121
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: If50b2191fe374860cd17455f9bd0e0e549fbefc0
Reviewed-on: https://chromium-review.googlesource.com/960402
Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542983}
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/browser/cast_memory_pressure_monitor.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/browser/extensions/cast_extension_system.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/browser/extensions/cast_extensions_browser_client.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/browser/metrics/cast_metrics_service_client.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/browser/network_context_manager.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/crash/linux/synchronized_minidump_manager_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/graphics/run_all_unittests.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/audio/cast_audio_output_stream.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/base/media_resource_tracker_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cdm/cast_cdm_factory.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/backend/audio_decoder_for_mixer.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/backend/video_decoder_null.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/base/balanced_media_task_runner_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/base/buffering_frame_provider_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/base/demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/base/demuxer_stream_for_test.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/base/multi_demuxer_stream_adapter_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/decoder/cast_audio_decoder.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/pipeline/audio_video_pipeline_impl_unittest.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/pipeline/av_pipeline_impl.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/pipeline/media_pipeline_impl.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/test/mock_frame_consumer.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/cma/test/mock_frame_provider.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/media/test/run_all_unittests.cc
[modify] https://crrev.com/22a9de0c0dd4b46c22f4168f7c07b09c84953b69/chromecast/net/connectivity_checker_impl.cc

Project Member

Comment 162 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d49c7428faef5b5f38c309f8e5c07236e6ad1182

commit d49c7428faef5b5f38c309f8e5c07236e6ad1182
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Fri Mar 16 18:03:18 2018

Bluetooth: BindOnce refactoring

BUG=714018

TBR=nick@chromium.org

Change-Id: Ic30f482175460a71c0a5cd78796bf9296ebc13c7
Reviewed-on: https://chromium-review.googlesource.com/963084
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543760}
[modify] https://crrev.com/d49c7428faef5b5f38c309f8e5c07236e6ad1182/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/d49c7428faef5b5f38c309f8e5c07236e6ad1182/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/d49c7428faef5b5f38c309f8e5c07236e6ad1182/content/browser/frame_host/render_frame_host_impl.cc

Project Member

Comment 163 by bugdroid1@chromium.org, Mar 20 2018

Comment 164 by gab@chromium.org, Mar 20 2018

Hey Taiju, FYI, I just noticed that RunLoop::Quit*Closure() is still a base::Closure. I think this would be a fairly easy one to auto-migrate given it's by design only callable once (or at least I'd be surprised if any callers use it more than once and it would almost certainly be wrong...).

Thanks again for churning through these!
Project Member

Comment 166 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d84121731ab98dd54fcc749727c99fd2a499b43a

commit d84121731ab98dd54fcc749727c99fd2a499b43a
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Thu Mar 22 14:12:12 2018

Bind refactoring: guest_view

Explicitly mark GuestCallback as a RepeatingCallback and use BindRepeating on all callers

BUG=714018
TBR=sky@chromium.org

Change-Id: I5e1d7283b421872291fad9131fb6977d1ba8b3c0
Reviewed-on: https://chromium-review.googlesource.com/970904
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545061}
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/chromeos/login/eula_browsertest.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/chromeos/login/webview_login_browsertest.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/printing/print_view_manager_common.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/ui/tab_contents/core_tab_helper.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/ui/webui/signin/inline_login_ui_browsertest.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/chrome/browser/ui/webui/signin/signin_utils.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/content/browser/browser_plugin/browser_plugin_embedder.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/content/public/browser/browser_plugin_guest_manager.cc
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/content/public/browser/browser_plugin_guest_manager.h
[modify] https://crrev.com/d84121731ab98dd54fcc749727c99fd2a499b43a/content/public/test/browser_test_utils.cc

Project Member

Comment 167 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3711b44bcb0cfdab5b0189a064c212e0d1d398f

commit d3711b44bcb0cfdab5b0189a064c212e0d1d398f
Author: Avi Drissman <avi@chromium.org>
Date: Thu Mar 22 15:47:05 2018

Switch MHTML generation to the new callbacks.

BUG=714018

Change-Id: I33cd6842055c959af25e286b1962c6f902b35971
Reviewed-on: https://chromium-review.googlesource.com/974284
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545087}
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/chrome/browser/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/content/browser/download/mhtml_generation_manager.h
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/content/browser/download/save_package.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/d3711b44bcb0cfdab5b0189a064c212e0d1d398f/content/public/browser/web_contents.h

Project Member

Comment 168 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1873470733c8d03858c38e964897bfa65ea6e055

commit 1873470733c8d03858c38e964897bfa65ea6e055
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Mar 23 09:57:58 2018

Revert "Switch MHTML generation to the new callbacks."

This reverts commit d3711b44bcb0cfdab5b0189a064c212e0d1d398f.

Reason for revert: suspected of making BrowserCloseManagerWithDownloadsBrowserTest/BrowserCloseManagerWithDownloadsBrowserTest.TestWithDownloadsFromDifferentProfiles/ very flaky on waterfall

Original change's description:
> Switch MHTML generation to the new callbacks.
> 
> BUG=714018
> 
> Change-Id: I33cd6842055c959af25e286b1962c6f902b35971
> Reviewed-on: https://chromium-review.googlesource.com/974284
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545087}

TBR=avi@chromium.org,jam@chromium.org

Change-Id: I0ed09e0d0322de613180e5b7558256fb3aea58bf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714018, 825141
Reviewed-on: https://chromium-review.googlesource.com/977981
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545395}
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/chrome/browser/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/mhtml_generation_manager.h
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/download/save_package.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/1873470733c8d03858c38e964897bfa65ea6e055/content/public/browser/web_contents.h

Project Member

Comment 169 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149b78369e15711c32ff009996a8f2446108b21e

commit 149b78369e15711c32ff009996a8f2446108b21e
Author: Avi Drissman <avi@chromium.org>
Date: Fri Mar 23 14:31:49 2018

Reland "Switch MHTML generation to the new callbacks."

This is a reland of d3711b44bcb0cfdab5b0189a064c212e0d1d398f

Original change's description:
> Switch MHTML generation to the new callbacks.
>
> BUG=714018
>
> Change-Id: I33cd6842055c959af25e286b1962c6f902b35971
> Reviewed-on: https://chromium-review.googlesource.com/974284
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#545087}

TBR=avi@chromium.org,jam@chromium.org

Bug: 714018
No-Try: true
Change-Id: Ibc69a42603ddac0cb386905842659b84d60356a8
Reviewed-on: https://chromium-review.googlesource.com/978162
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545437}
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/android_webview/browser/aw_contents.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/chrome/browser/extensions/api/page_capture/page_capture_api.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/chrome/browser/offline_pages/offline_page_mhtml_archiver.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/content/browser/download/mhtml_generation_browsertest.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/content/browser/download/mhtml_generation_manager.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/content/browser/download/mhtml_generation_manager.h
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/content/browser/download/save_package.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/149b78369e15711c32ff009996a8f2446108b21e/content/public/browser/web_contents.h

Project Member

Comment 170 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a911482f6f8f30b2f65df4a286fe94a582e866ef

commit a911482f6f8f30b2f65df4a286fe94a582e866ef
Author: Avi Drissman <avi@chromium.org>
Date: Fri Mar 23 18:25:55 2018

Move WebContents internals to use the new callbacks.

BUG=714018

Change-Id: I7adfe8e440d29b4f775535a9942e2354d076a9d3
Reviewed-on: https://chromium-review.googlesource.com/976656
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545525}
[modify] https://crrev.com/a911482f6f8f30b2f65df4a286fe94a582e866ef/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a911482f6f8f30b2f65df4a286fe94a582e866ef/content/browser/web_contents/web_contents_impl.h

Project Member

Comment 171 by bugdroid1@chromium.org, Mar 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e5875bdf5f96d314787d01b2f1e15236ed6fa97

commit 5e5875bdf5f96d314787d01b2f1e15236ed6fa97
Author: Avi Drissman <avi@chromium.org>
Date: Sat Mar 24 01:39:47 2018

Move WebUI's RegisterMessageCallback to use the new callbacks.

BUG=714018

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2ca24193658c5d25d4038151b04b7216bb4bf2ba
Reviewed-on: https://chromium-review.googlesource.com/976392
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545658}
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ash/content/keyboard_overlay/keyboard_overlay_delegate.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/app_launcher_login_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/certificate_viewer_webui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/certificates_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui_browsertest.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/login/base_webui_handler.h
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/network_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/power_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/slow_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/chromeos/sys_internals/sys_internals_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/components_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/conflicts_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/constrained_web_dialog_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/crashes_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/device_log_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/domain_reliability_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/extensions/install_extension_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/flash_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/foreign_session_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/gcm_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/history_login_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/identity_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/inspect_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/invalidations_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/local_state/local_state_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/md_bookmarks/bookmarks_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_browsertest.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/media/webrtc_logs_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/memory_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/metrics_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/net_export_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/net_internals/net_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/ntp/app_icon_webui_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/ntp/core_app_launcher_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/plural_string_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/predictors/predictors_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/set_as_default_browser_ui_win.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/appearance_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/browser_lifetime_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/change_password_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/accessibility_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/android_apps_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/date_time_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/device_power_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/device_stylus_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/google_assistant_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/chromeos/internet_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/downloads_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/extension_control_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/font_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/languages_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/native_certificates_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/on_startup_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/printing_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/profile_info_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/reset_settings_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/safe_browsing_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/settings_default_browser_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/settings_import_data_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/settings/system_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/signin/inline_login_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/signin/signin_create_profile_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/signin/signin_error_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/snippets_internals_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/sync_file_system_internals/dump_database_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/sync_file_system_internals/extension_statuses_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/sync_internals_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/task_scheduler_internals/task_scheduler_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/version_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/web_ui_test_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/webapks_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/webui_webview_browsertest.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/welcome_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/browser/ui/webui/welcome_win10_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/test/base/web_ui_browser_test_browsertest.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/test/data/webui/async_gen.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/chrome/test/data/webui/chrome_send_browsertest.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/components/dom_distiller/webui/dom_distiller_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/components/ntp_tiles/webui/ntp_tiles_internals_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/components/ntp_tiles/webui/ntp_tiles_internals_message_handler_client.h
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/components/physical_web/webui/physical_web_base_message_handler.h
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/components/proximity_auth/webui/proximity_auth_webui_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/components/safe_browsing/web_ui/safe_browsing_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/accessibility/accessibility_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/appcache/appcache_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/indexed_db/indexed_db_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/media/media_internals_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/service_worker/service_worker_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/tracing/tracing_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/webrtc/webrtc_internals_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/webui/generic_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/webui/web_ui_impl.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/browser/webui/web_ui_impl.h
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/content/public/browser/web_ui.h
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/docs/webui_in_components.md
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/crashes_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/flags_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/gcm/gcm_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/net_export/net_export_ui.mm
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/omaha_ui.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/chrome/browser/ui/webui/version_handler.cc
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ios/web/public/webui/web_ui_ios.h
[modify] https://crrev.com/5e5875bdf5f96d314787d01b2f1e15236ed6fa97/ui/web_dialogs/web_dialog_ui.cc

Project Member

Comment 172 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12dbaba6ad138594c0464004ac4617ec4634ceaf

commit 12dbaba6ad138594c0464004ac4617ec4634ceaf
Author: tzik <tzik@chromium.org>
Date: Mon Mar 26 15:17:15 2018

Apply base_bind_rewriters to //chrome/browser/chromeos/arc

This applies base_bind_rewriters at //tools/clang/base_bind_rewriters to
replace base::Bind() with base::BindOnce() on mechanical cases, and to
remove unneeded base::Passed() on base::BindOnce() arguments.

Bug: 714018
Change-Id: Ibcdab031e117eb0ecffc2dd75295966cb032ea02
Reviewed-on: https://chromium-review.googlesource.com/979880
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545793}
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher_browsertest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/bluetooth/arc_bluetooth_bridge_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/cast_receiver/arc_cast_receiver_service.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_async_file_util.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_documents_provider_root_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_file_system_bridge_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/arc_file_system_operation_runner_util.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/fileapi/file_stream_forwarder_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/intent_helper/arc_navigation_throttle.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/oemcrypto/arc_oemcrypto_bridge.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/process/arc_process_service.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/screen_capture/arc_screen_capture_session.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/components/arc/arc_session_runner_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/components/arc/arc_util.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/components/arc/intent_helper/activity_icon_loader_unittest.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/components/arc/intent_helper/link_handler_model.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/components/arc/metrics/arc_metrics_service.cc
[modify] https://crrev.com/12dbaba6ad138594c0464004ac4617ec4634ceaf/components/arc/midis/arc_midis_bridge.cc

Project Member

Comment 173 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ee0692f435a72172f5a0283038511fe3f1f4120

commit 6ee0692f435a72172f5a0283038511fe3f1f4120
Author: Avi Drissman <avi@chromium.org>
Date: Mon Mar 26 17:08:01 2018

Do light cleanup of SB's Blacklist class.

This does C++11ification.

This also does a partial Callback cleanup, only of the instances
where it was obvious what they were. Further cleanup is
left for later.

This also removes ancient cleanup code that has been
cleaning up profiles for 4.5 years now. All the profiles
have been cleaned up by now.

BUG=295882, 714018

Change-Id: I26da23e1a49aa0f776ec1f9ca1310d9254dee3af
Reviewed-on: https://chromium-review.googlesource.com/979613
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545822}
[modify] https://crrev.com/6ee0692f435a72172f5a0283038511fe3f1f4120/chrome/browser/extensions/blacklist.cc
[modify] https://crrev.com/6ee0692f435a72172f5a0283038511fe3f1f4120/chrome/browser/extensions/blacklist.h
[modify] https://crrev.com/6ee0692f435a72172f5a0283038511fe3f1f4120/chrome/browser/extensions/blacklist_unittest.cc

Project Member

Comment 174 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f

commit a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f
Author: Avi Drissman <avi@chromium.org>
Date: Tue Mar 27 03:39:02 2018

Move WebContents::DownloadImage/GetManifest to use the new callbacks.

BUG=714018

Change-Id: I330346f3e752870ac1752467ee2c9b934934cb2f
Reviewed-on: https://chromium-review.googlesource.com/974746
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545987}
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/chrome/browser/extensions/favicon_downloader.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/chrome/browser/media/android/remote/remote_media_player_manager.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/components/favicon/core/favicon_handler.h
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/components/favicon/core/favicon_handler_unittest.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/components/favicon/ios/web_favicon_driver.mm
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/browser/manifest/manifest_icon_downloader.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/public/browser/web_contents.h
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/renderer/fetchers/multi_resolution_image_resource_fetcher.h
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/renderer/image_downloader/image_downloader_base.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/renderer/image_downloader/image_downloader_base.h
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/renderer/image_downloader/image_downloader_impl.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/test/test_web_contents.cc
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/content/test/test_web_contents.h
[modify] https://crrev.com/a5a52dd537bd8fbbd8c8e4ad65afa30b6d1fd76f/extensions/browser/app_window/app_window.cc

Project Member

Comment 175 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db5cf5c4acb1f5d2bd812ec632a60391c50b4f00

commit db5cf5c4acb1f5d2bd812ec632a60391c50b4f00
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue Mar 27 22:07:33 2018

ServiceWorker: BindOnce refactoring

BUG=714018

Change-Id: I348d7b85d4cf3fa68279ac9797b4223c4168cdc2
Reviewed-on: https://chromium-review.googlesource.com/981500
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546288}
[modify] https://crrev.com/db5cf5c4acb1f5d2bd812ec632a60391c50b4f00/content/browser/service_worker/service_worker_browsertest.cc

Project Member

Comment 176 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0939b5495029f7710b16a52a413cf7a357c09d3c

commit 0939b5495029f7710b16a52a413cf7a357c09d3c
Author: Avi Drissman <avi@chromium.org>
Date: Thu Mar 29 01:13:22 2018

Light cleanup of CallbackList.

1. C++11ify a few things.
2. Clarify that the callbacks are RepeatingCallbacks.

BUG=714018

Change-Id: I6f1ffeacbcaee54d70a53803a2082cfb11f98f83
Reviewed-on: https://chromium-review.googlesource.com/979196
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546688}
[modify] https://crrev.com/0939b5495029f7710b16a52a413cf7a357c09d3c/base/callback_list.h

Project Member

Comment 177 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/387bee3f782afb7103251942eb78d8d1862aa213

commit 387bee3f782afb7103251942eb78d8d1862aa213
Author: tzik <tzik@chromium.org>
Date: Fri Mar 30 21:06:48 2018

Apply base_bind_rewriters to //ui

This applies base_bind_rewriters at //tools/clang/base_bind_rewriters to
replace base::Bind() with base::BindOnce() on mechanical cases, and to
remove unneeded base::Passed() on base::BindOnce() arguments.

Bug: 714018
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8b7ac7bd4c98cf223a8a9b890139e5d21e6a4cdf
Reviewed-on: https://chromium-review.googlesource.com/987636
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547272}
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/app_list/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/app_list/views/expand_arrow_view.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/app_list/views/search_result_container_view.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/arc/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/aura/mus/input_method_mus.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/aura/mus/input_method_mus_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/aura/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/aura/window_event_dispatcher.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/aura/window_event_dispatcher_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/base/ime/input_method_chromeos.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/base/models/simple_menu_model.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/base/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/base/test/ui_controls_internal_win.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/base/x/x11_util.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/chromeos/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/compositor/layer_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/compositor/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/display/manager/chromeos/display_configurator_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/display/manager/chromeos/test/test_native_display_delegate.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/display/manager/display_manager.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/blink/input_handler_proxy.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/blink/input_handler_proxy_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/ozone/device/device_manager_manual.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/ozone/evdev/event_factory_evdev.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/ozone/evdev/event_thread_evdev.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/ozone/evdev/input_controller_evdev.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/ozone/evdev/input_device_factory_evdev.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/ozone/evdev/input_device_factory_evdev_proxy.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/platform/platform_event_source_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/platform/x11/x11_hotplug_event_handler.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/events/test/event_generator.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/gfx/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/gl/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/keyboard/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/message_center/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/drm_thread.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/drm_thread_message_proxy.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/drm_window_proxy.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/drm_window_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/hardware_display_controller_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/proxy_helpers.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/proxy_helpers.h
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/gpu/proxy_helpers_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/host/drm_display_host.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/host/drm_display_host_manager.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/headless/gl_surface_osmesa_png.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/headless/headless_surface_factory.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/wayland/fake_server.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/platform/wayland/wayland_connection.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/ozone/public/ozone_gpu_test_helper.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/shell_dialogs/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/shell_dialogs/select_file_dialog.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/shell_dialogs/select_file_dialog_win.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/snapshot/snapshot_aura.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/snapshot/test/run_all_unittests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/mouse_watcher.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/mus/drag_interactive_uitest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/mus/views_mus_test_suite.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/views_perftests.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/views_test_suite.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/widget/widget_interactive_uitest.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/views/win/hwnd_message_handler.cc
[modify] https://crrev.com/387bee3f782afb7103251942eb78d8d1862aa213/ui/wm/test/run_all_unittests.cc

Project Member

Comment 178 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89585d367da687581261617965cdfee15fd8fcd1

commit 89585d367da687581261617965cdfee15fd8fcd1
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Wed Apr 04 15:17:52 2018

[ozone/wayland] Move away from base::Bind

BUG=714018

Change-Id: I9d846815404f3154639cf6c2a2fcff98ee91cd0c
Reviewed-on: https://chromium-review.googlesource.com/995512
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#548063}
[modify] https://crrev.com/89585d367da687581261617965cdfee15fd8fcd1/ui/ozone/platform/wayland/fake_server.cc
[modify] https://crrev.com/89585d367da687581261617965cdfee15fd8fcd1/ui/ozone/platform/wayland/wayland_connection.cc

Project Member

Comment 179 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aa7f05745f26f11b51069222e3038632dc3470d

commit 4aa7f05745f26f11b51069222e3038632dc3470d
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Apr 09 08:58:42 2018

Use base::BindOnce in cloud_print PrintSystem code.

Modernize code as well.

BUG=714018

Change-Id: I7dd5330e094c190328ea9c6dd9faa042510962e5
Reviewed-on: https://chromium-review.googlesource.com/1001032
Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549131}
[modify] https://crrev.com/4aa7f05745f26f11b51069222e3038632dc3470d/chrome/service/cloud_print/print_system_cups.cc
[modify] https://crrev.com/4aa7f05745f26f11b51069222e3038632dc3470d/chrome/service/cloud_print/print_system_win.cc

Project Member

Comment 180 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e45d8f693b7f6e516ea0cdff8ba6c154aadb41ff

commit e45d8f693b7f6e516ea0cdff8ba6c154aadb41ff
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Mon Apr 09 23:57:18 2018

BindOnce refactoring: explicitly use BindRepeating in browser.cc

PrefChangeRegistrar::NamedChangeCallback is explicitly defined as a
RepeatingCallback, so use BindRepeating in callers.

BUG=714018

Change-Id: I4e655bc8586f00a860e7205f5aa3818ae3a71a22
Reviewed-on: https://chromium-review.googlesource.com/1003115
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549329}
[modify] https://crrev.com/e45d8f693b7f6e516ea0cdff8ba6c154aadb41ff/chrome/browser/ui/browser.cc

Project Member

Comment 181 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbf68c4d029c34fa518ec08310f1c7d704fad6ba

commit fbf68c4d029c34fa518ec08310f1c7d704fad6ba
Author: tzik <tzik@chromium.org>
Date: Thu Apr 12 10:31:52 2018

Migrate base::TestIOThread to OnceCallback

base::TestIOThread::PostTask is a left-over of the OnceCallback support
of TaskRunner::PostTask, that is needed by its user to migrate to
OnceCallback.

Bug: 714018
Change-Id: Iceb18fb84bde555e4fa217c32e463e01adf034a1
Reviewed-on: https://chromium-review.googlesource.com/997313
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550135}
[modify] https://crrev.com/fbf68c4d029c34fa518ec08310f1c7d704fad6ba/base/test/test_io_thread.cc
[modify] https://crrev.com/fbf68c4d029c34fa518ec08310f1c7d704fad6ba/base/test/test_io_thread.h

Project Member

Comment 182 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095c5c0201299a9529f45494904728d4c514403b

commit 095c5c0201299a9529f45494904728d4c514403b
Author: tzik <tzik@chromium.org>
Date: Thu Apr 12 12:28:50 2018

Migrate ResourceCoordinator to OnceCallback

This removes 'use_once_callback = false' flag from BUILD.gn from
services/resource_coordinator, and fixes all implementations of the
interface.

Bug: 714018, 729950
Change-Id: I203b0957fdc12da1829339f79d84210446ebad7e
Reviewed-on: https://chromium-review.googlesource.com/997064
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550156}
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/components/services/heap_profiling/heap_profiling_service.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/components/services/heap_profiling/heap_profiling_service.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/coordination_unit/coordination_unit_base.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/coordination_unit/coordination_unit_introspector_impl.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/coordinator_impl.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/coordinator_impl_unittest.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/memory_instrumentation/queued_request_dispatcher.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/frame_resource_coordinator.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/client_process_impl.h
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/memory_instrumentation.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_integration_unittest.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/page_resource_coordinator.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/cpp/process_resource_coordinator.cc
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/public/mojom/BUILD.gn
[modify] https://crrev.com/095c5c0201299a9529f45494904728d4c514403b/services/resource_coordinator/resource_coordinator_service_unittest.cc

Project Member

Comment 184 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b28255c8f47ddf51ca59b50cee639789ee7fc7e

commit 3b28255c8f47ddf51ca59b50cee639789ee7fc7e
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Apr 13 10:25:40 2018

Migrate CustomizationWallpaperDownloader away from base::Bind and base::Closure.

Instead, base::BindOnce and base::OnceClosure are used.

This is driven-by CL that allows the presubmit hook to let other
changes to this file to be uploaded.

BUG=714018

Change-Id: I0adbfe6bc5a2195e52310bebcd5a1c00e85ef244
Reviewed-on: https://chromium-review.googlesource.com/1011304
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#550577}
[modify] https://crrev.com/3b28255c8f47ddf51ca59b50cee639789ee7fc7e/chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc

Project Member

Comment 185 by bugdroid1@chromium.org, Apr 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/007662df136fb42cfe8bab00e1b80f8048833b45

commit 007662df136fb42cfe8bab00e1b80f8048833b45
Author: tzik <tzik@chromium.org>
Date: Sat Apr 14 03:45:18 2018

Migrate services/tracing to OnceCallback

This removes 'use_once_callback = false' flag from BUILD.gn in
services/tracing/public/mojom, and fixes all implementations of the
interface.

Bug: 714018,
Change-Id: If7cec8d89f304b314275239cde4c15aa40ce0386
Reviewed-on: https://chromium-review.googlesource.com/999074
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550874}
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/base/trace_event/tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/base/trace_event/tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chromeos/dbus/fake_debug_daemon_client.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cast_tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cast_tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cros_tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cros_tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/etw_tracing_agent_win.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/etw_tracing_agent_win.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/power_tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/power_tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/coordinator.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/coordinator.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/base_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/base_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/chrome_trace_event_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/chrome_trace_event_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/mojom/BUILD.gn
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/test_util.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/test_util.h

Project Member

Comment 186 by bugdroid1@chromium.org, Apr 17 2018

Project Member

Comment 187 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b28255c8f47ddf51ca59b50cee639789ee7fc7e

commit 3b28255c8f47ddf51ca59b50cee639789ee7fc7e
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Apr 13 10:25:40 2018

Migrate CustomizationWallpaperDownloader away from base::Bind and base::Closure.

Instead, base::BindOnce and base::OnceClosure are used.

This is driven-by CL that allows the presubmit hook to let other
changes to this file to be uploaded.

BUG=714018

Change-Id: I0adbfe6bc5a2195e52310bebcd5a1c00e85ef244
Reviewed-on: https://chromium-review.googlesource.com/1011304
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#550577}
[modify] https://crrev.com/3b28255c8f47ddf51ca59b50cee639789ee7fc7e/chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc

Project Member

Comment 188 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/007662df136fb42cfe8bab00e1b80f8048833b45

commit 007662df136fb42cfe8bab00e1b80f8048833b45
Author: tzik <tzik@chromium.org>
Date: Sat Apr 14 03:45:18 2018

Migrate services/tracing to OnceCallback

This removes 'use_once_callback = false' flag from BUILD.gn in
services/tracing/public/mojom, and fixes all implementations of the
interface.

Bug: 714018,
Change-Id: If7cec8d89f304b314275239cde4c15aa40ce0386
Reviewed-on: https://chromium-review.googlesource.com/999074
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550874}
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/base/trace_event/memory_dump_manager.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/base/trace_event/tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/base/trace_event/tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chrome/browser/chromeos/arc/tracing/arc_tracing_bridge.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/chromeos/dbus/fake_debug_daemon_client.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cast_tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cast_tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cros_tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/cros_tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/etw_tracing_agent_win.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/etw_tracing_agent_win.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/power_tracing_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/content/browser/tracing/power_tracing_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/coordinator.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/coordinator.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/base_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/base_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/chrome_trace_event_agent.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/cpp/chrome_trace_event_agent.h
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/public/mojom/BUILD.gn
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/test_util.cc
[modify] https://crrev.com/007662df136fb42cfe8bab00e1b80f8048833b45/services/tracing/test_util.h

Project Member

Comment 189 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91251881a3845c9ecd6227da2d825aaa88824ba8

commit 91251881a3845c9ecd6227da2d825aaa88824ba8
Author: Michael Spang <spang@chromium.org>
Date: Tue Apr 24 22:28:08 2018

ozone: evdev: Move to OnceCallback & RepeatingCallback

Migrate ui/events/ozone/evdev to the new callback types as appropriate.

Bug: 714018
Test: CQ & run chrome on eve
Change-Id: Ic518057debb61cd6dbe297bebb13fec0538063c6
Reviewed-on: https://chromium-review.googlesource.com/1026523
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553321}
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/device/device_manager_manual.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/event_converter_evdev.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/event_converter_evdev.h
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/event_dispatch_callback.h
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/event_factory_evdev.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/event_thread_evdev.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/event_thread_evdev.h
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/gamepad_event_converter_evdev_unittest.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/input_device_factory_evdev.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/input_injector_evdev_unittest.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/touch_event_converter_evdev.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/touch_event_converter_evdev.h
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc
[modify] https://crrev.com/91251881a3845c9ecd6227da2d825aaa88824ba8/ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc

Project Member

Comment 190 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ce84d2d7ab568b70af3d84383b082c94f380067

commit 3ce84d2d7ab568b70af3d84383b082c94f380067
Author: Michael Spang <spang@chromium.org>
Date: Wed Apr 25 17:55:49 2018

ui/display: Convert display callbacks to OnceCallback

This cleans up ui/display to use base::OnceCallback instead of
base::Callback where appropriate.

Bug: 714018
Test: CQ & run chrome on eve

Change-Id: I4231d9266f2d7df41701fe70fa8ef4a9b42b34c4
Reviewed-on: https://chromium-review.googlesource.com/1026553
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553643}
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/services/ui/display/screen_manager_forwarding.cc
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/services/ui/display/screen_manager_forwarding.h
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/manager/fake_display_delegate.cc
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/manager/fake_display_delegate.h
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/manager/forwarding_display_delegate.h
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/manager/test/test_native_display_delegate.cc
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/manager/test/test_native_display_delegate.h
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/mojo/BUILD.gn
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/display/types/native_display_delegate.h
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/ozone/platform/drm/host/drm_display_host.cc
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/ozone/platform/drm/host/drm_display_host.h
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/ozone/platform/drm/host/drm_display_host_manager.cc
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/ozone/platform/drm/host/drm_display_host_manager.h
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/ozone/platform/drm/host/drm_native_display_delegate.cc
[modify] https://crrev.com/3ce84d2d7ab568b70af3d84383b082c94f380067/ui/ozone/platform/drm/host/drm_native_display_delegate.h

Project Member

Comment 191 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31cf671fc496c1cd054aeda2ae1c75a48191c04a

commit 31cf671fc496c1cd054aeda2ae1c75a48191c04a
Author: Michael Spang <spang@chromium.org>
Date: Wed Apr 25 20:02:43 2018

ozone: Migrate to base::{Once,Repeating}Callback as appropriate

Bug: 714018
Test: CQ & run chrome on eve

Change-Id: I7f6bb7a0165d99fb1890cdaa4e893f1fbb28ff51
Reviewed-on: https://chromium-review.googlesource.com/1026417
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553709}
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/drm_device.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/drm_device.h
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/drm_thread_proxy.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/gbm_surfaceless.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_atomic.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/hardware_display_plane_manager_legacy.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/mock_drm_device.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/mock_drm_device.h
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/proxy_helpers.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/gpu/proxy_helpers.h
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/platform/drm/host/drm_display_host_manager.cc
[modify] https://crrev.com/31cf671fc496c1cd054aeda2ae1c75a48191c04a/ui/ozone/public/ozone_gpu_test_helper.cc

Project Member

Comment 192 by bugdroid1@chromium.org, May 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32c68cacef20b259ceaa1a062aa01398ba0e1818

commit 32c68cacef20b259ceaa1a062aa01398ba0e1818
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Thu May 03 00:31:56 2018

Migrate HDRProxy to BindOnce/BindRepeating

Bug: 714018
Change-Id: I4c0c9935a6c2864717eb9a0f995591d85e3d2a15
Reviewed-on: https://chromium-review.googlesource.com/1039947
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555629}
[modify] https://crrev.com/32c68cacef20b259ceaa1a062aa01398ba0e1818/content/browser/browser_main_loop.cc
[modify] https://crrev.com/32c68cacef20b259ceaa1a062aa01398ba0e1818/content/browser/gpu/gpu_process_host.h
[modify] https://crrev.com/32c68cacef20b259ceaa1a062aa01398ba0e1818/ui/display/win/screen_win.h

Project Member

Comment 193 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/222512a0ce7deab81dad3af945bad2196e8a8838

commit 222512a0ce7deab81dad3af945bad2196e8a8838
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri May 04 02:08:29 2018

Move GoogleURLTracker away from base::Bind()

This is a preparation CL to migrate GoogleURLTracker from
URLFetcher to SimpleURLLoader.

BUG=714018

Change-Id: I1ba490d9fea5bf5c23212471f723407de488023f
Reviewed-on: https://chromium-review.googlesource.com/1042505
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555962}
[modify] https://crrev.com/222512a0ce7deab81dad3af945bad2196e8a8838/components/google/core/browser/google_url_tracker.cc

Project Member

Comment 194 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a

commit 7cfcd1107398f8d4d5a54fd7c7e55725731cd79a
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue May 08 00:07:56 2018

Migrate LoginAuthRequiredCallback to BindOnce

Bug: 714018
Change-Id: Icf71c24297709c96513db23e7f562dce298e6374
Reviewed-on: https://chromium-review.googlesource.com/1048070
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556617}
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/android_webview/browser/aw_login_delegate.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/android_webview/browser/aw_login_delegate.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/ui/android/login_handler_android.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/ui/cocoa/login_handler_cocoa.mm
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/ui/login/login_handler.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/chrome/browser/ui/views/login_handler_views.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/browser/network_service_client.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/public/browser/content_browser_client.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/shell/browser/layout_test/layout_test_content_browser_client.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/shell/browser/shell_login_dialog.cc
[modify] https://crrev.com/7cfcd1107398f8d4d5a54fd7c7e55725731cd79a/content/shell/browser/shell_login_dialog.h

Project Member

Comment 195 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e99c31b07dc741631933b22ed50f6a1ddffcf45c

commit e99c31b07dc741631933b22ed50f6a1ddffcf45c
Author: Lei Zhang <thestig@chromium.org>
Date: Mon May 14 22:13:52 2018

Mark EmbeddedServiceInfo::ServiceFactory as a RepeatingCallback.

BUG=714018

Change-Id: Ia17a1dc5f1d06ea6d0af1301489526c9030d1d53
Reviewed-on: https://chromium-review.googlesource.com/1054779
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558487}
[modify] https://crrev.com/e99c31b07dc741631933b22ed50f6a1ddffcf45c/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/e99c31b07dc741631933b22ed50f6a1ddffcf45c/services/service_manager/embedder/embedded_service_info.h

Project Member

Comment 196 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9bbab8aca813b98cb956a59c55286eb1354eb55

commit b9bbab8aca813b98cb956a59c55286eb1354eb55
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Wed May 16 15:02:56 2018

Migrate SpeechRecognizerImplAndroid to BindOnce

Bug: 714018
Change-Id: If7b20cee715746e7d97b557f79ca1c9e5ffaca6d
Reviewed-on: https://chromium-review.googlesource.com/1061596
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559095}
[modify] https://crrev.com/b9bbab8aca813b98cb956a59c55286eb1354eb55/content/browser/speech/speech_recognizer_impl_android.cc

Project Member

Comment 197 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3554c03c8fc5febcaacb866ed77d3021c0bfc00c

commit 3554c03c8fc5febcaacb866ed77d3021c0bfc00c
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Wed May 16 17:01:15 2018

Migrate MediaStreamManager::GenerateStreamCallback to BindOnce

Bug: 714018
Change-Id: I6424da4665e0f5e4bdb8ad03b30ad5ff41d28b1f
Reviewed-on: https://chromium-review.googlesource.com/1061813
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559147}
[modify] https://crrev.com/3554c03c8fc5febcaacb866ed77d3021c0bfc00c/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/3554c03c8fc5febcaacb866ed77d3021c0bfc00c/content/browser/renderer_host/media/media_stream_manager.h
[modify] https://crrev.com/3554c03c8fc5febcaacb866ed77d3021c0bfc00c/content/browser/webrtc/webrtc_getusermedia_browsertest.cc

Project Member

Comment 199 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e3e7d6a3b0f030b5f96063b94d1ece64064d048

commit 3e3e7d6a3b0f030b5f96063b94d1ece64064d048
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri May 18 18:49:48 2018

Migrate ExtensionDownloader away from base::Bind()

BUG=714018

Change-Id: Ia8ed733ab2d77eb6ac5672bf3ac846019a62e59f
Reviewed-on: https://chromium-review.googlesource.com/1066410
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#559973}
[modify] https://crrev.com/3e3e7d6a3b0f030b5f96063b94d1ece64064d048/extensions/browser/updater/extension_downloader.cc

Project Member

Comment 200 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6ae71231e0a0824aebfa4d4579f8ac70c42300d

commit a6ae71231e0a0824aebfa4d4579f8ac70c42300d
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Tue Jun 05 10:50:08 2018

Migrate TranslateScript and TranslateURLFetcher away from base::Bind

Driven by CL, preparation for CL https://crrev.com/c/1085947.

BUG=714018

Change-Id: I455fb3bfc2addd6b99151778639f47de4d240709
Reviewed-on: https://chromium-review.googlesource.com/1085948
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#564437}
[modify] https://crrev.com/a6ae71231e0a0824aebfa4d4579f8ac70c42300d/components/translate/core/browser/translate_script.cc
[modify] https://crrev.com/a6ae71231e0a0824aebfa4d4579f8ac70c42300d/components/translate/core/browser/translate_url_fetcher.cc
[modify] https://crrev.com/a6ae71231e0a0824aebfa4d4579f8ac70c42300d/components/translate/core/browser/translate_url_fetcher.h

Project Member

Comment 201 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6

commit 45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue Jun 05 14:15:49 2018

Migrate WebContentsCreatedCallback to BindOnce

Bug: 714018
Change-Id: If45e105f525c6133fcf81b66ab8c9072d5514815
Reviewed-on: https://chromium-review.googlesource.com/1085229
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564482}
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/components/guest_view/browser/guest_view_base.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/components/guest_view/browser/guest_view_base.h
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/components/guest_view/browser/guest_view_manager.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/components/guest_view/browser/guest_view_manager.h
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/api/guest_view/guest_view_internal_api.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/app_view/app_view_guest.h
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/extension_options/extension_options_guest.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/extension_options/extension_options_guest.h
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/extension_view/extension_view_guest.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/extension_view/extension_view_guest.h
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/extensions_guest_view_message_filter.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/mime_handler_view/test_mime_handler_view_guest.h
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/45e1a44fa6f3fdbc0f3ce0ea77bc798112483dd6/extensions/browser/guest_view/web_view/web_view_guest.h

Project Member

Comment 202 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26

commit 5749908f9a7d9db3cbc020e7736bb8d8b6e46f26
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue Jun 12 12:38:30 2018

Migrate MediaResponseCallback to OnceCallback

Bug: 714018
Change-Id: I024f77e3642a225302f748595430cb478de75fe9
Reviewed-on: https://chromium-review.googlesource.com/1093052
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566389}
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/android_webview/browser/aw_web_contents_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/android_webview/browser/aw_web_contents_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/android_webview/browser/permission/media_access_permission_request.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/android_webview/browser/permission/media_access_permission_request.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/android_webview/browser/permission/media_access_permission_request_unittest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/android/tab_web_contents_delegate_android.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/android/tab_web_contents_delegate_android.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/chromeos/login/ui/webui_login_view.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/chromeos/login/ui/webui_login_view.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/extensions/api/tab_capture/offscreen_tab.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/extensions/api/tab_capture/offscreen_tab.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/extensions/chrome_extension_host_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/extensions/chrome_extension_host_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/chromeos_login_media_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/chromeos_login_media_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/extension_media_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/extension_media_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/media_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/media_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/public_session_media_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/public_session_media_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/public_session_tab_capture_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/public_session_tab_capture_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/desktop_capture_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/desktop_capture_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/media_capture_devices_dispatcher.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/media_stream_devices_controller.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/media_stream_devices_controller.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/media_stream_devices_controller_browsertest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/permission_bubble_media_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/screen_capture_infobar_delegate_android.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/tab_capture_access_handler.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/media/webrtc/tab_capture_access_handler.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/ui/apps/chrome_app_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/ui/apps/chrome_app_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/ui/ash/chrome_keyboard_ui.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/ui/ash/chrome_keyboard_ui.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/ui/ash/chrome_keyboard_ui_unittest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/ui/browser.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chrome/browser/ui/browser.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chromecast/browser/cast_web_view_default.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chromecast/browser/cast_web_view_default.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chromecast/browser/extensions/cast_extension_host_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/chromecast/browser/extensions/cast_extension_host_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/components/offline_pages/content/background_loader/background_loader_contents.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/components/offline_pages/content/background_loader/background_loader_contents.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/browser/frame_host/render_frame_host_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/browser/frame_host/render_frame_host_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/browser/renderer_host/media/media_stream_ui_proxy_unittest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/public/browser/web_contents_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/content/public/common/media_stream_request.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/app_window/app_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/app_window/app_web_contents_helper.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/app_window/app_web_contents_helper.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/extension_host.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/extension_host.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/extension_host_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/app_view/app_view_apitest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/app_view/app_view_guest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/app_view/app_view_guest.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/web_view/web_view_guest.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/web_view/web_view_media_access_apitest.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/guest_view/web_view/web_view_permission_helper.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/media_capture_util.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/browser/media_capture_util.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/shell/browser/shell_app_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/shell/browser/shell_app_delegate.h
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/shell/browser/shell_extension_host_delegate.cc
[modify] https://crrev.com/5749908f9a7d9db3cbc020e7736bb8d8b6e46f26/extensions/shell/browser/shell_extension_host_delegate.h

Project Member

Comment 203 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06e4121112d87486828cd5811a7700902fb984ec

commit 06e4121112d87486828cd5811a7700902fb984ec
Author: Matt Wolenetz <wolenetz@chromium.org>
Date: Fri Jun 15 01:44:55 2018

MSE: Modernize base::Bind usage for StreamParser callbacks

Since upcoming changeType() work will refactor some of the current code
that creates and passes callbacks to StreamParser::Init(), this CL
modernizes related base::Bind and base::Callback usage to either
base::Bind{Once,Repeating} and base::{Once,Repeating}Callback.

Note that the encrypted media init data callback is the same underlying
type in StreamParser as in Demuxer, so this CL also modernizes the
binding for the Demuxer version of that type.

base::Bind count in //media: before=1425, after=1384

BUG=714018,751838,605134

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie8c3ef44a836c5bfa3f34ff300da760dd7f552c1
Reviewed-on: https://chromium-review.googlesource.com/1099935
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567507}
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/base/mock_filters.h
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/base/stream_parser.h
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/filters/chunk_demuxer.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/filters/chunk_demuxer_unittest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/filters/demuxer_perftest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/filters/source_buffer_state.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/filters/source_buffer_state.h
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/filters/source_buffer_state_unittest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/common/stream_parser_test_base.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mp2t/mp2t_stream_parser.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mp2t/mp2t_stream_parser.h
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mp2t/mp2t_stream_parser_unittest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mp4/mp4_stream_parser.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mp4/mp4_stream_parser.h
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mp4/mp4_stream_parser_unittest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mpeg/mpeg_audio_stream_parser_base.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/mpeg/mpeg_audio_stream_parser_base.h
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/webm/webm_stream_parser.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/webm/webm_stream_parser.h
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/formats/webm/webm_stream_parser_unittest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/test/mock_media_source.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/test/pipeline_integration_fuzzertest.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/06e4121112d87486828cd5811a7700902fb984ec/media/test/pipeline_integration_test_base.cc

Project Member

Comment 206 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/963756a3c73181ba0baa3dfe4c7bb2119ba5faa4

commit 963756a3c73181ba0baa3dfe4c7bb2119ba5faa4
Author: Donna Wu <donna.wu@intel.com>
Date: Wed Jun 27 06:59:00 2018

Migrate MtpDeviceManager to OnceCallback.

This CL migrated to as many OnceCallback(s) as possible in
services/device/media_transfer_protocol directory. Due to some
unchanged DBus interfaces, there are still several base::Bind()
left in the implementation.

BUG=714018

Change-Id: Iceb2558f45a54e43503fc67fe40380cc9baef248
Reviewed-on: https://chromium-review.googlesource.com/1111693
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Donna Wu <donna.wu@intel.com>
Cr-Commit-Position: refs/heads/master@{#570676}
[modify] https://crrev.com/963756a3c73181ba0baa3dfe4c7bb2119ba5faa4/services/device/media_transfer_protocol/media_transfer_protocol_daemon_client.cc
[modify] https://crrev.com/963756a3c73181ba0baa3dfe4c7bb2119ba5faa4/services/device/media_transfer_protocol/media_transfer_protocol_daemon_client.h
[modify] https://crrev.com/963756a3c73181ba0baa3dfe4c7bb2119ba5faa4/services/device/media_transfer_protocol/mtp_device_manager.cc

Project Member

Comment 207 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b43687e17ba2243f4c75450de715a270f1ef49e2

commit b43687e17ba2243f4c75450de715a270f1ef49e2
Author: Sky Malice <skym@google.com>
Date: Fri Jun 29 18:57:00 2018

Migrate TaskFinishedCallback to OnceCallback.

Also updated DownloadServiceImpl's pending tasks and actions to use
OnceClosure and fixed lint errors in modified files.

Bug: 714018
Change-Id: I3efdae52913657519dfca2bd1aa7b46aa98ae45d
Reviewed-on: https://chromium-review.googlesource.com/1117311
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571573}
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/chrome/browser/android/download/service/download_background_task.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/chrome/browser/android/download/service/download_task_scheduler.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/chrome/browser/android/download/service/download_task_scheduler.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/chrome/browser/download/download_task_scheduler_impl.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/chrome/browser/download/download_task_scheduler_impl.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/controller.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/controller_impl.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/controller_impl.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/controller_impl_unittest.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/download_service_impl.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/download_service_impl.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/empty_task_scheduler.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/empty_task_scheduler.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/scheduler/scheduler_impl_unittest.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/internal/background_service/test/mock_controller.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/public/background_service/download_service.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/public/background_service/task_scheduler.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/public/background_service/test/mock_download_service.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/public/background_service/test/test_download_service.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/download/public/background_service/test/test_download_service.h
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/offline_pages/core/prefetch/test_download_service.cc
[modify] https://crrev.com/b43687e17ba2243f4c75450de715a270f1ef49e2/components/offline_pages/core/prefetch/test_download_service.h

Project Member

Comment 211 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7b67724819aaecea597a71e14088c5df0562989

commit c7b67724819aaecea597a71e14088c5df0562989
Author: Sky Malice <skym@google.com>
Date: Mon Jul 02 17:07:11 2018

Migrate AcquireFileAccessPermissionCallback to OnceCallback.

Bug: 714018
Change-Id: I73cf48ba17dd96f6f4571bad941b6669509ba6b2
Reviewed-on: https://chromium-review.googlesource.com/1117575
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571927}
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/android/download/download_controller.cc
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/android/download/download_controller.h
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/android/download/download_controller_base.h
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/android/download/mock_download_controller.cc
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/android/download/mock_download_controller.h
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/offline_pages/android/offline_page_bridge.cc
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/c7b67724819aaecea597a71e14088c5df0562989/chrome/browser/offline_pages/offline_page_utils.h

Project Member

Comment 212 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60b5734808c05fd3b4350f608ca963209fc97cae

commit 60b5734808c05fd3b4350f608ca963209fc97cae
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Tue Jul 10 16:48:54 2018

Migrate about_handler to BindOnce

Bug: 714018
Change-Id: I365b66d8017dfaa0d84d3dabddf4e11606b4228b
Reviewed-on: https://chromium-review.googlesource.com/1131320
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573772}
[modify] https://crrev.com/60b5734808c05fd3b4350f608ca963209fc97cae/components/about_handler/url_request_about_job.cc

Project Member

Comment 213 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/306445eb3243c9186674568b488f0cebdd374918

commit 306445eb3243c9186674568b488f0cebdd374918
Author: Mark Pilgrim <pilgrim@chromium.org>
Date: Wed Jul 11 13:38:54 2018

Migrate ProfileSyncServiceAutofillTest to BindOnce/BindRepeating

Bug: 714018
Change-Id: I5f237f6be4311ebd36262354aef1256cd06d44eb
Reviewed-on: https://chromium-review.googlesource.com/1131995
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574141}
[modify] https://crrev.com/306445eb3243c9186674568b488f0cebdd374918/components/browser_sync/profile_sync_service_autofill_unittest.cc
[modify] https://crrev.com/306445eb3243c9186674568b488f0cebdd374918/components/browser_sync/profile_sync_test_util.cc
[modify] https://crrev.com/306445eb3243c9186674568b488f0cebdd374918/components/browser_sync/profile_sync_test_util.h

Project Member

Comment 214 by bugdroid1@chromium.org, Jul 11

Project Member

Comment 215 by bugdroid1@chromium.org, Jul 12

Project Member

Comment 216 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fe41d919a0f521a30d9e13b1e97a0a529835c0e

commit 5fe41d919a0f521a30d9e13b1e97a0a529835c0e
Author: tzik <tzik@chromium.org>
Date: Fri Jul 27 19:56:23 2018

Use OnceCallback on Mojo interfaces in services/ui/public

This CL flips `use_once_callback` flag on the Mojo code generator for
//services/ui/public, and fixes all compile errors after that. After
this CL, Mojo interfaces there service starts using base::OnceCallback
instead of base::Callback on its return value handling.

Bug: 714018
Change-Id: I9a0923249f3bb2b37319a118f742f384c90cf31f
Reviewed-on: https://chromium-review.googlesource.com/1151185
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578759}
[modify] https://crrev.com/5fe41d919a0f521a30d9e13b1e97a0a529835c0e/services/ui/display/output_protection.cc
[modify] https://crrev.com/5fe41d919a0f521a30d9e13b1e97a0a529835c0e/services/ui/display/output_protection.h
[modify] https://crrev.com/5fe41d919a0f521a30d9e13b1e97a0a529835c0e/services/ui/display/screen_manager_ozone_internal.cc
[modify] https://crrev.com/5fe41d919a0f521a30d9e13b1e97a0a529835c0e/services/ui/display/screen_manager_ozone_internal.h
[modify] https://crrev.com/5fe41d919a0f521a30d9e13b1e97a0a529835c0e/services/ui/public/interfaces/display/BUILD.gn
[modify] https://crrev.com/5fe41d919a0f521a30d9e13b1e97a0a529835c0e/ui/display/manager/display_configurator.cc
[modify] https://crrev.com/5fe41d919a0f521a30d9e13b1e97a0a529835c0e/ui/display/manager/display_configurator.h

Project Member

Comment 217 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff02ffa180b7d92f0a19d80921906ab088301163

commit ff02ffa180b7d92f0a19d80921906ab088301163
Author: tzik <tzik@chromium.org>
Date: Wed Aug 01 07:09:17 2018

Migrate Mojo tests from legacy Callback to OnceCallback

This CL flips `use_once_callback` flag on the Mojo code generator for
Mojo tests, and fixes all compile errors after that.
After this CL, Mojo interfaces there service starts using
base::OnceCallback instead of base::Callback on its return value
handling.

Bug: 714018
Change-Id: Iaa9566292500cefd92ecedd137ed4ba4bfec502e
Reviewed-on: https://chromium-review.googlesource.com/1156190
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579717}
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/media/mojo/services/deferred_destroy_strong_binding_set_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/binding_callback_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/binding_set_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/binding_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/bindings_perftest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/data_view_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/e2e_perftest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/handle_passing_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/lazy_serialization_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/native_struct_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/pickle_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/report_bad_message_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/request_response_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/sample_service_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/struct_traits_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/sync_method_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/test_helpers_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/union_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/validation_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/cpp/bindings/tests/wtf_types_unittest.cc
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/mojo/public/interfaces/bindings/tests/BUILD.gn
[modify] https://crrev.com/ff02ffa180b7d92f0a19d80921906ab088301163/third_party/blink/renderer/platform/mojo/interface_invalidator_test.cc

Project Member

Comment 218 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c

commit cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c
Author: tzik <tzik@chromium.org>
Date: Thu Aug 09 21:32:47 2018

Use OnceCallback on Mojo interfaces in //chrome/common

This CL flips `use_once_callback` flag on the Mojo code generator for
//chrome/common, and fixes all compile errors after that. After
this CL, Mojo interfaces there service starts using base::OnceCallback
instead of base::Callback on its return value handling.

Bug: 714018
Change-Id: I70823c7a0ca0032fa3223e2a2926d37acc8f6523
Reviewed-on: https://chromium-review.googlesource.com/1152342
Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581897}
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/browser/net_benchmarking.cc
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/browser/net_benchmarking.h
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/browser/plugins/plugin_info_host_impl.cc
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/browser/plugins/plugin_info_host_impl.h
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/browser/web_applications/extensions/bookmark_app_data_retriever_unittest.cc
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/common/BUILD.gn
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/renderer/chrome_render_frame_observer.cc
[modify] https://crrev.com/cd02d3b7a2617ed0484ee6a3b12f6ee45bb75f9c/chrome/renderer/chrome_render_frame_observer.h

Project Member

Comment 219 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53f903791b68c64193805c501a19191efd713efa

commit 53f903791b68c64193805c501a19191efd713efa
Author: tzik <tzik@chromium.org>
Date: Wed Aug 15 05:52:12 2018

Remove use_once_callback option from Mojo code generator

This CL removes legacy base::Callback support from Mojo code generator,
that is no longer used.

Bug: 714018
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2928476e357136a7c7bbb57f83509c63fe45b321
Reviewed-on: https://chromium-review.googlesource.com/1152637
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583174}
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/components/cronet/tools/generators/cronet_bindings_generator.py
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/components/cronet/tools/generators/cronet_c_generator.py
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/generators/cpp_templates/interface_declaration.tmpl
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/generators/cpp_templates/interface_macros.tmpl
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/generators/mojom_cpp_generator.py
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/mojom.gni
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/mojom_bindings_generator.py
[modify] https://crrev.com/53f903791b68c64193805c501a19191efd713efa/mojo/public/tools/bindings/pylib/mojom/generate/generator.py

Project Member

Comment 220 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1fcd4bcbcbf2c7c89f760ef12b670aca5d8b9c

commit ee1fcd4bcbcbf2c7c89f760ef12b670aca5d8b9c
Author: Antonio Gomes <tonikitoo@igalia.com>
Date: Fri Aug 17 14:11:09 2018

Move sync_client.cc away from base::Bind

BUG=714018

Change-Id: I59944400286435c71ed605ba019cd7f2680e5532
Reviewed-on: https://chromium-review.googlesource.com/1174656
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#584052}
[modify] https://crrev.com/ee1fcd4bcbcbf2c7c89f760ef12b670aca5d8b9c/components/sync/engine/net/network_time_update_callback.h
[modify] https://crrev.com/ee1fcd4bcbcbf2c7c89f760ef12b670aca5d8b9c/components/sync/tools/sync_client.cc

Project Member

Comment 221 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22835a1e00f6371d922f1308e5563d21ceed6afa

commit 22835a1e00f6371d922f1308e5563d21ceed6afa
Author: Joshua Bell <jsbell@chromium.org>
Date: Wed Sep 26 15:33:37 2018

Some BindOnce updates for storage dependencies

Change a handful of Bind/Callback/Closure usages to the modern
Once/Repeating variations. Factored out of pending CLs that caught the
presubmit checks. Just a refactor - no intentional behavior changes.

Bug: 714018

Change-Id: Id882fbf57042415d819acccecc27d79aaa50a485
Reviewed-on: https://chromium-review.googlesource.com/1244365
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594324}
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/chrome/browser/browsing_data/browsing_data_quota_helper.h
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/chrome/browser/browsing_data/browsing_data_quota_helper_impl.h
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/chrome/browser/browsing_data/mock_browsing_data_quota_helper.cc
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/chrome/browser/browsing_data/mock_browsing_data_quota_helper.h
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/content/browser/dom_storage/dom_storage_context_wrapper.h
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/22835a1e00f6371d922f1308e5563d21ceed6afa/content/public/browser/dom_storage_context.h

Project Member

Comment 222 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb20488b6f18a04eef62282d7e87af864923debd

commit bb20488b6f18a04eef62282d7e87af864923debd
Author: Joshua Bell <jsbell@chromium.org>
Date: Mon Oct 01 22:12:37 2018

BindOnce update for StoragePartition/ShaderDiskCache

Bug: 714018
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2cb2aba8e1f8460f0dedc25fdeba1df702e845fb
Reviewed-on: https://chromium-review.googlesource.com/1244369
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595570}
[modify] https://crrev.com/bb20488b6f18a04eef62282d7e87af864923debd/content/browser/storage_partition_impl.cc
[modify] https://crrev.com/bb20488b6f18a04eef62282d7e87af864923debd/gpu/ipc/host/shader_disk_cache.cc
[modify] https://crrev.com/bb20488b6f18a04eef62282d7e87af864923debd/gpu/ipc/host/shader_disk_cache.h
[modify] https://crrev.com/bb20488b6f18a04eef62282d7e87af864923debd/gpu/ipc/host/shader_disk_cache_unittest.cc

Project Member

Comment 223 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94893f7c7ea30b30582ea20446ce99530e15ef82

commit 94893f7c7ea30b30582ea20446ce99530e15ef82
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Mon Oct 01 23:36:04 2018

[FileSystem] Change callback types in FileSystemOperation to be Once or Repeating.

Bug: 714018
Change-Id: I02bc49853ff630a0422ba0ddc8f08b7412046327
Reviewed-on: https://chromium-review.googlesource.com/1255148
Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595636}
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/chromeos/file_manager/fileapi_util.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/chromeos/file_manager/fileapi_util.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/chromeos/file_manager/filesystem_api_util.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/chromeos/fileapi/recent_download_source.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/chromeos/fileapi/recent_drive_source.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/sync_file_system/local/local_file_sync_context.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/sync_file_system/local/local_file_sync_context.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/chrome/browser/sync_file_system/local/syncable_file_system_operation.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/copy_or_move_operation_delegate.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/copy_or_move_operation_delegate.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/file_system_operation.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/file_system_operation_impl.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/file_system_operation_impl.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/file_system_operation_runner.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/file_system_operation_runner.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/recursive_operation_delegate.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/recursive_operation_delegate.h
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/recursive_operation_delegate_unittest.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/remove_operation_delegate.cc
[modify] https://crrev.com/94893f7c7ea30b30582ea20446ce99530e15ef82/storage/browser/fileapi/remove_operation_delegate.h

Project Member

Comment 224 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82ace7702f298aedf722e2f3a26d815d49c913f9

commit 82ace7702f298aedf722e2f3a26d815d49c913f9
Author: Joshua Bell <jsbell@chromium.org>
Date: Wed Oct 24 16:12:26 2018

Cache Storage: BindOnce-ify CacheManager::GetAllOriginsUsage

Switch a few Cache Storage-related code paths from generic
Bind/Callback to BindOnce/OnceCallback.

Bug: 714018
Change-Id: I245cb56090228865cb0f4957caf8f704568eac39
Reviewed-on: https://chromium-review.googlesource.com/c/1289433
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602357}
[modify] https://crrev.com/82ace7702f298aedf722e2f3a26d815d49c913f9/chrome/browser/browsing_data/browsing_data_cache_storage_helper.cc
[modify] https://crrev.com/82ace7702f298aedf722e2f3a26d815d49c913f9/chrome/browser/browsing_data/browsing_data_cache_storage_helper.h
[modify] https://crrev.com/82ace7702f298aedf722e2f3a26d815d49c913f9/chrome/browser/browsing_data/mock_browsing_data_cache_storage_helper.cc
[modify] https://crrev.com/82ace7702f298aedf722e2f3a26d815d49c913f9/chrome/browser/browsing_data/mock_browsing_data_cache_storage_helper.h
[modify] https://crrev.com/82ace7702f298aedf722e2f3a26d815d49c913f9/content/browser/cache_storage/cache_storage_context_impl.cc
[modify] https://crrev.com/82ace7702f298aedf722e2f3a26d815d49c913f9/content/browser/cache_storage/cache_storage_context_impl.h
[modify] https://crrev.com/82ace7702f298aedf722e2f3a26d815d49c913f9/content/public/browser/cache_storage_context.h

Project Member

Comment 225 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5218b37535d460f5595f17ba7f0c5a6361ce49f0

commit 5218b37535d460f5595f17ba7f0c5a6361ce49f0
Author: Gabriel Marin <gmx@chromium.org>
Date: Mon Nov 19 22:03:13 2018

PerfProvider: Migrate from base::Bind to Bind(Once|Repeating)

base::Bind is deprecated. Converted the callback for the SessionRestore
observer to BindRepeating, while the other uses are converted to BindOnce.

BUG=714018,b:116527691
TEST=Unit tests pass

Change-Id: Ieef3f8b40f057d64265f8524b2b779ee7ce8806b
Reviewed-on: https://chromium-review.googlesource.com/c/1340605
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609458}
[modify] https://crrev.com/5218b37535d460f5595f17ba7f0c5a6361ce49f0/chrome/browser/metrics/perf/perf_output.cc
[modify] https://crrev.com/5218b37535d460f5595f17ba7f0c5a6361ce49f0/chrome/browser/metrics/perf/perf_output.h
[modify] https://crrev.com/5218b37535d460f5595f17ba7f0c5a6361ce49f0/chrome/browser/metrics/perf/perf_provider_chromeos.cc

Project Member

Comment 226 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25119546259f9080963073323e9ece9091f5f2e8

commit 25119546259f9080963073323e9ece9091f5f2e8
Author: Lucas Furukawa Gadani <lfg@chromium.org>
Date: Wed Dec 05 01:42:53 2018

Migrate PepperBrowserConnection to use OnceCallback.

Bug: 714018

Change-Id: I780e94380f65214921eb87e9ecb4fd8fa33fe721
Reviewed-on: https://chromium-review.googlesource.com/c/1357506
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613803}
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/components/pdf/renderer/pdf_accessibility_tree_browsertest.cc
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/content/public/renderer/renderer_ppapi_host.h
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/content/renderer/pepper/mock_renderer_ppapi_host.cc
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/content/renderer/pepper/mock_renderer_ppapi_host.h
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/content/renderer/pepper/pepper_browser_connection.cc
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/content/renderer/pepper/pepper_browser_connection.h
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/content/renderer/pepper/renderer_ppapi_host_impl.cc
[modify] https://crrev.com/25119546259f9080963073323e9ece9091f5f2e8/content/renderer/pepper/renderer_ppapi_host_impl.h

Project Member

Comment 227 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab8c3ec70afe9588748eb424723ede8e8e9a5662

commit ab8c3ec70afe9588748eb424723ede8e8e9a5662
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Tue Dec 11 23:05:59 2018

Vaapi decoder: Use BindOnce to placate presubmit warning

Use BindOnce to placate the presubmit warning.

Bug: 714018
Change-Id: I5b268640b8b9ad48c3a3f0fc25a3f7b1dbd7adea
Reviewed-on: https://chromium-review.googlesource.com/c/1371903
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615713}
[modify] https://crrev.com/ab8c3ec70afe9588748eb424723ede8e8e9a5662/media/gpu/vaapi/vaapi_video_decode_accelerator.cc

Project Member

Comment 228 by bugdroid1@chromium.org, Dec 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544

commit 66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Dec 27 23:54:42 2018

[Extensions Callback Cleanup] EventRouter-related code

Remove usages of base::Callback and base::Bind (in favor of
base::[Once|Repeating]Callback and base::Bind[Once|Repeating]) and
update to passing by value when an instance is retained in
EventRouter-related code (including EventRouter,
LazyEventDispatcher, and callers).

Bug: 714018

Change-Id: I027c2eaccc521e89ef182aeac8c4d0d2523bcebb
Reviewed-on: https://chromium-review.googlesource.com/c/1391729
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619095}
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/chrome/browser/extensions/api/downloads/downloads_api.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/chrome/browser/extensions/api/downloads/downloads_api.h
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/chrome/browser/extensions/api/tabs/tabs_event_router.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/chrome/browser/extensions/api/tabs/windows_event_router.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/api/audio/audio_api.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/api/hid/hid_device_manager.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/api/printer_provider/printer_provider_api.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/api/usb/usb_event_router.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/event_listener_map_unittest.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/event_router.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/event_router.h
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/event_router_unittest.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/events/lazy_event_dispatcher.cc
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/events/lazy_event_dispatcher.h
[modify] https://crrev.com/66bfdb8c74c976d9f5ce43e763c1dc89bbfb1544/extensions/browser/lazy_background_task_queue_unittest.cc

Project Member

Comment 229 by bugdroid1@chromium.org, Dec 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffeabfd32ce0145b3a5225cdde42a4cf279f4885

commit ffeabfd32ce0145b3a5225cdde42a4cf279f4885
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Dec 28 01:22:15 2018

[Extensions Callback Cleanup] extensions/renderer/bindings code

Do the following clean-ups in extensions/renderer/bindings:
- Convert base::Callback to base::RepeatingCallback/base::OnceCallback
- Convert base::Bind to base::BindRepeating/base::BindOnce
- Pass callbacks by value when an instance is retained

In practice, all call sites here required a RepeatingCallback.

Bug: 714018
Change-Id: Id7cbffa21d5cda4210075086d083df5a4116dc6b
Reviewed-on: https://chromium-review.googlesource.com/c/1391417
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619105}
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_binding.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_binding.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_binding_hooks_test_delegate.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_binding_hooks_test_delegate.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_binding_types.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_binding_unittest.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_bindings_system.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_bindings_system.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_bindings_system_unittest.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_event_handler_unittest.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_event_listeners.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_event_listeners.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_last_error.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_last_error.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_last_error_unittest.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_request_handler.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_request_handler.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_type_reference_map.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/api_type_reference_map.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/binding_access_checker.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/binding_access_checker.h
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/binding_access_checker_unittest.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/declarative_event_unittest.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/event_emitter_unittest.cc
[modify] https://crrev.com/ffeabfd32ce0145b3a5225cdde42a4cf279f4885/extensions/renderer/bindings/exception_handler_unittest.cc

Project Member

Comment 230 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb

commit cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Thu Jan 03 22:15:07 2019

[Extensions Callback Cleanup] RouteHandlerFunction

Do the following clean-ups in
ObjectBackedNativeHandler::RouteHandlerFunction() and its callers:
- Convert base::Callback to base::RepeatingCallback/base::OnceCallback
- Convert base::Bind to base::BindRepeating/base::BindOnce
- Pass callbacks by value when an instance is retained

In practice, these are all base::RepeatingCallbacks.

Bug: 714018
Change-Id: I5c7c58bcad7d033ca576ff7bde173bc6f9482303
Reviewed-on: https://chromium-review.googlesource.com/c/1391853
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619779}
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/app_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/file_browser_handler_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/file_manager_private_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/media_galleries_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/notifications_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/page_capture_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/platform_keys_natives.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chrome/renderer/extensions/sync_file_system_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/chromecast/renderer/extensions/automation_internal_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/api_activity_logger.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/api_definitions_natives.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/app_window_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/blob_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/context_menus_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/css_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/display_source_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/event_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/file_system_natives.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/i18n_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/id_generator_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/lazy_background_page_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/logging_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/messaging_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/module_system.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/module_system_test.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/module_system_unittest.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/object_backed_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/object_backed_native_handler.h
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/process_info_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/render_frame_observer_natives.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/runtime_custom_bindings.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/send_request_natives.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/set_icon_natives.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/test_features_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/test_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/user_gestures_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/utils_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/v8_context_native_handler.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/v8_schema_registry.cc
[modify] https://crrev.com/cc02a0cd6ff03d4e3c9e2a102ff3de60ae1ef2bb/extensions/renderer/wake_event_page.cc

Project Member

Comment 231 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efd14a14b24e67e5852fbb031c4a8debaea3b097

commit efd14a14b24e67e5852fbb031c4a8debaea3b097
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Jan 04 00:51:49 2019

[Extensions Callback Cleanup] Miscellaneous Installation Util

Do the following clean-ups in some miscellaneous installation utility
classes/files in extensions code:
- Convert base::Callback to base::RepeatingCallback/base::OnceCallback
- Convert base::Bind to base::BindRepeating/base::BindOnce
- Pass callbacks by value when an instance is retained

Bug: 714018

Change-Id: Ia58a8467b6956bdf2bd15557d51f312e9cc0a4cc
Reviewed-on: https://chromium-review.googlesource.com/c/1391866
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619835}
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/content_verifier_test_utils.cc
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/content_verifier_test_utils.h
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/install_signer.cc
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/install_signer.h
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/install_verifier.cc
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/policy_extension_reinstaller.cc
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/policy_extension_reinstaller.h
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/policy_extension_reinstaller_unittest.cc
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/unpacked_installer.cc
[modify] https://crrev.com/efd14a14b24e67e5852fbb031c4a8debaea3b097/chrome/browser/extensions/unpacked_installer.h

Project Member

Comment 232 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cf1016701fef0e87719683c48f114e14a188b60

commit 1cf1016701fef0e87719683c48f114e14a188b60
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Jan 04 01:07:51 2019

[Extensions Callback Cleanup] Webstore Installers

Do the following clean-ups in the webstore installer classes and its
callers:
- Convert base::Callback to base::RepeatingCallback/base::OnceCallback
- Convert base::Bind to base::BindRepeating/base::BindOnce
- Pass callbacks by value when an instance is retained

Bug: 714018

Change-Id: Ia55a04264ac528625c3f8664fd30607036945c24
Reviewed-on: https://chromium-review.googlesource.com/c/1391867
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619844}
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/apps/platform_apps/api/webstore_widget_private/app_installer.cc
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/apps/platform_apps/api/webstore_widget_private/app_installer.h
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/apps/platform_apps/api/webstore_widget_private/webstore_widget_private_api.cc
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/webstore_install_with_prompt.cc
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/webstore_install_with_prompt.h
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/webstore_reinstaller.cc
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/webstore_reinstaller.h
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/webstore_reinstaller_browsertest.cc
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/webstore_standalone_installer.cc
[modify] https://crrev.com/1cf1016701fef0e87719683c48f114e14a188b60/chrome/browser/extensions/webstore_standalone_installer.h

Project Member

Comment 233 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7462bc1cab4bc11c76ba65d10ea56f9378484d40

commit 7462bc1cab4bc11c76ba65d10ea56f9378484d40
Author: kylechar <kylechar@chromium.org>
Date: Tue Jan 08 14:55:54 2019

viz: Cleanup callback types.

Remove usage of deprecated base::Bind, base::Callback, base::Closure and
base::CancelableClosure types from components/viz/*. Where possible
convert to the corresponding once type. Otherwise replace with the
repeating type which is equivalent to the deprecated type.

Bug: 714018
Change-Id: I4cb59d4eb63f49662fa50c758617f71f017103a2
Reviewed-on: https://chromium-review.googlesource.com/c/1398789
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620717}
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/client/frame_eviction_manager.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/common/frame_sinks/delay_based_time_source.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/common/frame_sinks/delay_based_time_source.h
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/common/yuv_readback_unittest.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/copy_output_scaling_pixeltest.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/display_scheduler.h
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/gl_renderer_copier_pixeltest.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display/texture_deleter.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/frame_sinks/external_begin_frame_source_android_unittest.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/test/fake_external_begin_frame_source.cc
[modify] https://crrev.com/7462bc1cab4bc11c76ba65d10ea56f9378484d40/components/viz/test/fake_external_begin_frame_source.h

Project Member

Comment 234 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7fda54ed0b151331e08730c45040976adf7cad7

commit c7fda54ed0b151331e08730c45040976adf7cad7
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Tue Jan 08 17:20:36 2019

Revert "viz: Cleanup callback types."

This reverts commit 7462bc1cab4bc11c76ba65d10ea56f9378484d40.

Reason for revert: suspicion of breaking video.WebRTCCamera on chromeos-amd64-generic-rel (sorry in advance if I'm wrong)

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel/24062

2019/01/08 07:41:36 Running video.WebRTCCamera
2019/01/08 07:41:36 Restarting ui job
2019/01/08 07:41:41 Clearing device owner info
2019/01/08 07:41:41 Waiting for org.chromium.SessionManager D-Bus service
2019/01/08 07:41:41 Asking session_manager to enable Chrome testing
2019/01/08 07:41:41 Waiting for Chrome to write its debugging port to /home/chronos/DevToolsActivePort
2019/01/08 07:41:42 Removing cryptohome for testuser@gmail.com
2019/01/08 07:41:42 Finding OOBE DevTools target
2019/01/08 07:41:43 Connecting to Chrome at ws://127.0.0.1:41481/devtools/page/E3AE03DCDCE497A47AFDB8CA52CBE579
2019/01/08 07:41:43 Waiting for OOBE
2019/01/08 07:41:50 Logging in as user "testuser@gmail.com"
2019/01/08 07:41:51 Waiting for cryptohome for user "testuser@gmail.com"
2019/01/08 07:41:59 Waiting for OOBE to be dismissed
2019/01/08 07:42:04 Creating new page with URL http://127.0.0.1:39539/getusermedia.html
2019/01/08 07:42:04 Connecting to Chrome at ws://127.0.0.1:41481/devtools/page/4C1188A054BDBE0276A3DF2A6B7B1A22
2019/01/08 07:42:12 Results: [{Width:640 Height:480 FrameStats:{TotalFrames:0 BlackFrames:0 FrozenFrames:0} Errors:[]} {Width:1280 Height:720 FrameStats:{TotalFrames:25 BlackFrames:0 FrozenFrames:0} Errors:[]}]
2019/01/08 07:42:12 Error: [webrtc.go:206] 640x480 was not healthy: no frame was displayed
2019/01/08 07:42:12 Finished video.WebRTCCamera

Original change's description:
> viz: Cleanup callback types.
> 
> Remove usage of deprecated base::Bind, base::Callback, base::Closure and
> base::CancelableClosure types from components/viz/*. Where possible
> convert to the corresponding once type. Otherwise replace with the
> repeating type which is equivalent to the deprecated type.
> 
> Bug: 714018
> Change-Id: I4cb59d4eb63f49662fa50c758617f71f017103a2
> Reviewed-on: https://chromium-review.googlesource.com/c/1398789
> Commit-Queue: kylechar <kylechar@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620717}

TBR=danakj@chromium.org,kylechar@chromium.org

Change-Id: I327c747bce826c932e255e50f58c3fb59a01e946
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 714018
Reviewed-on: https://chromium-review.googlesource.com/c/1401064
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620771}
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/client/frame_eviction_manager.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/common/frame_sinks/delay_based_time_source.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/common/frame_sinks/delay_based_time_source.h
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/common/yuv_readback_unittest.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/copy_output_scaling_pixeltest.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/display_scheduler.h
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/gl_renderer_copier_pixeltest.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display/texture_deleter.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/frame_sinks/external_begin_frame_source_android_unittest.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/test/fake_external_begin_frame_source.cc
[modify] https://crrev.com/c7fda54ed0b151331e08730c45040976adf7cad7/components/viz/test/fake_external_begin_frame_source.h

Project Member

Comment 235 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b

commit d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b
Author: kylechar <kylechar@chromium.org>
Date: Tue Jan 08 20:23:18 2019

Reland "viz: Cleanup callback types."

This is a reland of 7462bc1cab4bc11c76ba65d10ea56f9378484d40

chromeos-amd64-generic-rel went green before revert landed.

Original change's description:
> viz: Cleanup callback types.
>
> Remove usage of deprecated base::Bind, base::Callback, base::Closure and
> base::CancelableClosure types from components/viz/*. Where possible
> convert to the corresponding once type. Otherwise replace with the
> repeating type which is equivalent to the deprecated type.
>
> Bug: 714018
> Change-Id: I4cb59d4eb63f49662fa50c758617f71f017103a2
> Reviewed-on: https://chromium-review.googlesource.com/c/1398789
> Commit-Queue: kylechar <kylechar@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620717}

TBR: danakj@chromium.org
Bug: 714018
Change-Id: I194cb8d40d66610a1ed329d63bfb9f4dbd1963b2
Reviewed-on: https://chromium-review.googlesource.com/c/1401235
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620857}
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/client/frame_eviction_manager.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/common/frame_sinks/delay_based_time_source.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/common/frame_sinks/delay_based_time_source.h
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/common/yuv_readback_unittest.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/copy_output_scaling_pixeltest.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/display_scheduler.h
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/gl_renderer_copier_pixeltest.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/gl_renderer_unittest.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/software_renderer_unittest.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display/texture_deleter.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/display_embedder/compositor_overlay_candidate_validator_ozone.h
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/frame_sinks/external_begin_frame_source_android_unittest.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/service/gl/gpu_service_impl.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/test/fake_external_begin_frame_source.cc
[modify] https://crrev.com/d50f57eee4aa2aa1283aa46f9705fb7e79b8d25b/components/viz/test/fake_external_begin_frame_source.h

Project Member

Comment 236 by bugdroid1@chromium.org, Jan 11 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bb144d56998ef9715b3333b25550120cf9d9ea5

commit 4bb144d56998ef9715b3333b25550120cf9d9ea5
Author: kylechar <kylechar@chromium.org>
Date: Fri Jan 11 20:42:07 2019

cc: Cleanup callback types (part 1).

Remove usage of deprecated base::Bind, base::Callback, base::Closure and
base::CancelableClosure types from cc/*. Where possible convert to the
corresponding once type. Otherwise replace with the repeating type which
is equivalent to the deprecated type.

This is the first of multiple CLs to cleanup callback types in cc/*.

ImageController::ProcessNextImageDecodeOnWorkerThread() has a slight
implementation change. This is necessary to accomodate
ImageDecodeRequest becoming move-only due to use of OnceCallback. The
implementation change should be a no-op functionality wise.

Bug: 714018
Change-Id: I16c4ad368a4865557406f8a64630ae14b61fecac
Reviewed-on: https://chromium-review.googlesource.com/c/1401368
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622132}
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/ash/components/fast_ink/fast_ink_view.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/base/delayed_unique_notifier.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/base/delayed_unique_notifier.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/base/delayed_unique_notifier_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/base/unique_notifier.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/base/unique_notifier.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/base/unique_notifier_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/benchmarks/micro_benchmark_controller_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/input/scrollbar_animation_controller_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/paint/paint_op_buffer_serializer.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/paint/paint_op_buffer_serializer.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/bitmap_raster_buffer_provider.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/bitmap_raster_buffer_provider.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/gpu_raster_buffer_provider.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/gpu_raster_buffer_provider.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/one_copy_raster_buffer_provider.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/one_copy_raster_buffer_provider.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/raster_buffer_provider.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/zero_copy_raster_buffer_provider.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/raster/zero_copy_raster_buffer_provider.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/scheduler/scheduler_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/fake_layer_tree_frame_sink_client.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/fake_layer_tree_host_impl_client.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/fake_raster_buffer_provider.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/fake_raster_buffer_provider.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/layer_tree_test.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/pixel_test.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/pixel_test.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/run_all_perftests.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/test/run_all_unittests.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/checker_image_tracker.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/checker_image_tracker_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/decoded_image_tracker.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/decoded_image_tracker.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/decoded_image_tracker_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/image_controller.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/image_controller.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/image_controller_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/picture_layer_tiling_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/tile_manager.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/layer_tree_frame_sink_client.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/proxy_common.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/proxy_impl.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/proxy_impl.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/cc/trees/single_thread_proxy.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/components/exo/layer_tree_frame_sink_holder.h
[modify] https://crrev.com/4bb144d56998ef9715b3333b25550120cf9d9ea5/content/renderer/android/synchronous_layer_tree_frame_sink.cc

Project Member

Comment 237 by bugdroid1@chromium.org, Yesterday (35 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ef69ec8928ff7cf273d88acb140378a4b5d1911

commit 3ef69ec8928ff7cf273d88acb140378a4b5d1911
Author: kylechar <kylechar@chromium.org>
Date: Wed Jan 16 21:07:15 2019

cc: Cleanup callback types (part 2).

Remove usage of deprecated base::Bind, base::Callback, base::Closure,
base::CancelableCallback and base::CancelableClosure types from cc/*.
Where possible convert to the corresponding once type. Otherwise replace
with the repeating type which is equivalent to the deprecated type.

This is the final CL to cleanup callback types in cc/*.

This CL switches DecodedImageTracker to use TickClock instead of a
callback to get TimeTicks now value. TickClock is an existing type meant
for setting a fake TimeTicks source, so it does the same thing a bit
more explicitly.

Bug: 714018
Change-Id: Ifffabe9d40a7dad75a76c7989bb24e799e0408fa
Reviewed-on: https://chromium-review.googlesource.com/c/1413335
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623364}
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/benchmarks/rasterize_and_record_benchmark.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/benchmarks/unittest_only_benchmark.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/input/scrollbar_animation_controller.h
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/input/scrollbar_animation_controller_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/input/single_scrollbar_animation_controller_thinning_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/layers/texture_layer.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/layers/texture_layer_impl_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/layers/video_layer_impl_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/raster/raster_buffer_provider_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/raster/staging_buffer_pool.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/raster/staging_buffer_pool.h
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/test/layer_tree_test.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/test/layer_tree_test.h
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/tiles/decoded_image_tracker.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/tiles/decoded_image_tracker.h
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/tiles/decoded_image_tracker_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/tiles/tile_manager.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/tiles/tile_manager.h
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/image_animation_controller.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/image_animation_controller_unittest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/layer_tree_host_perftest.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/layer_tree_host_unittest_proxy.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/layer_tree_host_unittest_scroll.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/single_thread_proxy.cc
[modify] https://crrev.com/3ef69ec8928ff7cf273d88acb140378a4b5d1911/cc/trees/single_thread_proxy.h

Showing comments 138 - 237 of 237 Older

Sign in to add a comment