New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713998 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security

Blocking:
issue 62400



Sign in to add a comment

Heap-buffer-overflow in CXFA_Object::IsNode

Project Member Reported by ClusterFuzz, Apr 21 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Apr 21 2017

Labels: M-59
Project Member

Comment 2 by sheriffbot@chromium.org, Apr 21 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 21 2017

Labels: Pri-1

Comment 4 by xzhou@chromium.org, Apr 21 2017

Cc: mbarbe...@chromium.org
I cannot see any details in the clusterfuzz report. CC mbarbella@.
Cc: tanin@chromium.org
Sounds similar to an issue that Tanin was looking into earlier. Not sure if it's expected to be resolved yet.

Comment 6 by mea...@chromium.org, Apr 21 2017

Components: Internals>Plugins>PDF
Blocking: 62400
Labels: -Pri-1 -ReleaseBlock-Beta -Security_Severity-Medium -Security_Impact-Head Security_severity-None Pri-2
XFA -> not shipping.

Comment 8 by mea...@chromium.org, Apr 21 2017

Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
thestig: Thanks for the correction! 

dsinclair: Assigning to you so that we have an owner for this bug.

Comment 9 by mea...@chromium.org, Apr 21 2017

Labels: -Security_severity-None Security_Severity-Medium Security_Impact-None
Adjusting the flags (impact to none, reassign severity as medium)
Ah, thanks.
FXJSE_ assuming again any V8 object with internal fields is one of its own.  I'll take a look at what we did on the FXJS_ side the last time we hit this on monday.
Project Member

Comment 12 by ClusterFuzz, Apr 25 2017

ClusterFuzz has detected this issue as fixed in range 465929:466779.

Detailed report: https://clusterfuzz.com/testcase?key=4980637548412928

Fuzzer: libfuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 4
Crash Address: 0x6090000cd080
Crash State:
  CXFA_Object::IsNode
  CXFA_Object::AsNode
  ToNode
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=465905:465929
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=465929:466779

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4980637548412928


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Apr 25 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4980637548412928 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Cc: dsinclair@chromium.org
Labels: ClusterFuzz-Wrong
Owner: tsepez@chromium.org
Status: Assigned (was: Verified)
tsepez@ is working on this, but the fix isn't committed yet.
should actually be fixed in (plus forthcoming roll)

https://pdfium.googlesource.com/pdfium/+/336544a7451ac80c9f33216b7f61e9347d251108

I'm guessing the repro may be sensitive to small perturbations in V8 which may have closed it out prematurely.
Status: Fixed (was: Assigned)
Project Member

Comment 19 by sheriffbot@chromium.org, Aug 9 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment