New issue
Advanced search Search tips

Issue 713996 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

compile failure on chromium/Win x64

Project Member Reported by keishi@chromium.org, Apr 21 2017

Issue description

compile failure on chromium/Win x64

Builders failed on: 
- Win x64: 
  https://build.chromium.org/p/chromium/builders/Win%20x64


FAILED: gen/v8/snapshot.cc snapshot_blob.bin 
C:/b/depot_tools/python276_bin/python.exe ../../v8/tools/run.py ./mksnapshot --startup_src gen/v8/snapshot.cc --random-seed 314159265 --startup_blob snapshot_blob.bin


==== C stack trace ===============================



	v8::internal::MacroAssembler::Push [0x00000001405244A0+0]

	v8::internal::CodeAgingHelper::CodeAgingHelper [0x0000000140519F91+97]

	v8::internal::Isolate::Init [0x00000001402BEE43+1379]

	v8::SnapshotCreator::SnapshotCreator [0x000000013FEFB6BB+235]

	v8::V8::CreateSnapshotDataBlob [0x000000013FEFE02D+61]

	main [0x000000013FEF236D+269]

	__scrt_common_main_seh [0x00000001406807B9+285] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)

	BaseThreadInitThunk [0x0000000076EA59CD+13]

	RtlUserThreadStart [0x0000000076FDB891+33]


 

Comment 1 by keishi@chromium.org, Apr 21 2017

Reverted v8 roll
https://codereview.chromium.org/2834783003/

Closed v8 rolling https://v8-roll.appspot.com/
This turned green before the revert. This was a flake in a helper tool. See also  http://crbug.com/700525 
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9c0272a5d06697b9e633f7140fcbfd7ff2b1fe

commit 1d9c0272a5d06697b9e633f7140fcbfd7ff2b1fe
Author: machenbach <machenbach@chromium.org>
Date: Fri Apr 21 06:39:07 2017

Reland of Update V8 to version 6.0.50. (patchset #1 id:1 of https://codereview.chromium.org/2834783003/ )

Reason for revert:
Turned green before revert was in.

Original issue's description:
> Revert of Update V8 to version 6.0.50. (patchset #1 id:1 of https://codereview.chromium.org/2833753003/ )
>
> Reason for revert:
> compile failure on chromium/Win x64
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=713996
>
> Original issue's description:
> > Update V8 to version 6.0.50.
> >
> > Summary of changes available at:
> > https://chromium.googlesource.com/v8/v8/+log/ab42a2aa..63c64c6d
> >
> > Please follow these instructions for assigning/CC'ing issues:
> > https://github.com/v8/v8/wiki/Triaging%20issues
> >
> > Please close rolling in case of a roll revert:
> > https://v8-roll.appspot.com/
> > This only works with a Google account.
> >
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> >
> > TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org
> >
> > Review-Url: https://codereview.chromium.org/2833753003
> > Cr-Commit-Position: refs/heads/master@{#466258}
> > Committed: https://chromium.googlesource.com/chromium/src/+/5ed39274a52c6e34e35e7a9c95aff9ef64a5ca32
>
> TBR=hablich@chromium.org,kozyatinskiy@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Review-Url: https://codereview.chromium.org/2834783003
> Cr-Commit-Position: refs/heads/master@{#466267}
> Committed: https://chromium.googlesource.com/chromium/src/+/b1294add46cb5b22c5e03ca2ad91db5562c4bf44

TBR=hablich@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org,v8-autoroll@chromium.org,keishi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 713996 

Review-Url: https://codereview.chromium.org/2829923005
Cr-Commit-Position: refs/heads/master@{#466274}

[modify] https://crrev.com/1d9c0272a5d06697b9e633f7140fcbfd7ff2b1fe/DEPS

Cc: yangguo@chromium.org hablich@chromium.org
Labels: Pri-2 Type-Bug
Owner: yangguo@chromium.org
Status: Assigned (was: Available)
Yang, any clue what was going on here?
No idea. V8 just randomly crashed, for some reason not obvious to me. The fact that mksnapshot runs V8 to create the snapshot caused the resulting build failure.
Status: Fixed (was: Assigned)
https://build.chromium.org/p/chromium/builders/Win%20x64 is now consistently green, marking this as Fixed.

Sign in to add a comment