New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 713995 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Apr 2017
Cc:
rouslan@chromium.org
█ groby@chromium.org
█ rlanday@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

SpellChecker::RemoveSpellingMarkersUnderWords remove markers of all types

Project Member Reported by xiaoche...@chromium.org, Apr 21 2017 
SpellChecker::RemoveSpellingMarkersUnderWords calls an overload of DocumentMarkerController::RemoveMarkers, which removes markers of all types instead of just spelling and grammar.

It should be fixed to removing only spelling and grammar.

Or just spelling?

Comment 1 by xiaoche...@chromium.org, Apr 21 2017

Cc: groby@chromium.org rouslan@chromium.org rlanday@chromium.org
SpellChecker::RemoveSpellingMarkersUnderWords is called by SpellCheck::OnCustomDictionaryChanged().

Should it remove grammar markers?

Comment 2 by rouslan@chromium.org, Apr 21 2017 

Yep.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0a6581e71557593b172fc1b53e229e7a78cfe2

commit 5b0a6581e71557593b172fc1b53e229e7a78cfe2
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Apr 25 01:39:58 2017

Fix DocumentMarkerController::RemoveSpellingMarkersUnderWords

The above mentioned function used to remove all markers, which is wrong.
This patch fixes it to remove only spelling and grammar markers.

BUG= 713995 
TEST=DocumentMarkerControllerTest.RemoveSpellingMarkersUnderWords

Review-Url: https://codereview.chromium.org/2838733002
Cr-Commit-Position: refs/heads/master@{#466860}

[modify] https://crrev.com/5b0a6581e71557593b172fc1b53e229e7a78cfe2/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
[modify] https://crrev.com/5b0a6581e71557593b172fc1b53e229e7a78cfe2/third_party/WebKit/Source/core/editing/markers/DocumentMarkerControllerTest.cpp

Comment 4 by xiaoche...@chromium.org, Apr 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment