New issue
Advanced search Search tips

Issue 713991 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 597889



Sign in to add a comment

bluetooth:win: Match order in which global variables are set

Project Member Reported by ortuno@chromium.org, Apr 21 2017

Issue description

The following variables are set as soon our API calls the platform API but on Windows these are set only after the platform API has replied. We should refactor Windows to better match the rest of the test framework

gatt_read_characteristic_attempts_
gatt_write_characteristic_attempts_
last_write_value_

Currently this causes tests to be less thorough and a lot of #if defined's for thorough tests e.g.:

https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc?l=726


After this change tests should follow the following pattern:

1. Perform GATT operation
2. Check that the correct number of GATT operations has been dispatched
3. For relevant operations check that the correct arguments have been provided.
4. Fake GATT Operation response
5. Check callbacks and response values.
 
Description: Show this description
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)

Sign in to add a comment