The following variables are set as soon our API class the platform API but on Windows these are set only after the platform API has replied. We should refactor Windows to better match the rest of the test framework
gatt_read_characteristic_attempts_
gatt_write_characteristic_attempts_
last_write_value_
Currently this causes tests to be less thorough and a lot of #if defined's for thorough tests e.g.:
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc?l=726
After this change tests should follow the following pattern:
1. Perform GATT operation
2. Check that the correct number of GATT operations has been dispatched
3. For relevant operations check that the correct arguments have been provided.
4. Fake GATT Operation response
5. Check callbacks and response values.
The following variables are set as soon our API calls the platform API but on Windows these are set only after the platform API has replied. We should refactor Windows to better match the rest of the test framework
gatt_read_characteristic_attempts_
gatt_write_characteristic_attempts_
last_write_value_
Currently this causes tests to be less thorough and a lot of #if defined's for thorough tests e.g.:
https://cs.chromium.org/chromium/src/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc?l=726
After this change tests should follow the following pattern:
1. Perform GATT operation
2. Check that the correct number of GATT operations has been dispatched
3. For relevant operations check that the correct arguments have been provided.
4. Fake GATT Operation response
5. Check callbacks and response values.
Comment 1 by ortuno@chromium.org
, Nov 7 2017