New issue
Advanced search Search tips

Issue 713986 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature



Sign in to add a comment

can't get from logdog log back to the run that generated the log

Project Member Reported by ojan@chromium.org, Apr 21 2017

Issue description

It would be really nice to be able to get from the log entry back to the buildbot run. It's often the case that people will revert a patch and only link to the log. For the person trying to understand why their patch got reverted, that's hard since they can't see the rest of the run (e.g. to verify that the revert was actually correct).

 

Comment 1 by no...@chromium.org, Apr 21 2017

Cc: d...@chromium.org
Dan how about utilizing stream tags for this, put a build URL special tag and display it on the viewer page.

Comment 2 by d...@chromium.org, Apr 21 2017

Yeah that'd be a fine way to do this.

Comment 3 by d...@chromium.org, Apr 21 2017

 Issue 714125  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9d20a223d82b56419650d8fccbc85e05d81ca140

commit 9d20a223d82b56419650d8fccbc85e05d81ca140
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Apr 24 15:00:42 2017

LogDog: Emit build URL as LogDog tag.

Emit the build URL as a LogDog tag. The viewer app can then read this tag
and use it to create a link back to the original build.

BUG= chromium:713986 
TEST=unit

Change-Id: I56759c7563321653abe1b116aa77c10360ce4f6c
Reviewed-on: https://chromium-review.googlesource.com/485259
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/9d20a223d82b56419650d8fccbc85e05d81ca140/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/9d20a223d82b56419650d8fccbc85e05d81ca140/scripts/slave/unittests/logdog_bootstrap_test.py

Status: Untriaged (was: Unconfirmed)
Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/be3ef4c9a4c295df8a50f7719f3e990cc57f2140

commit be3ef4c9a4c295df8a50f7719f3e990cc57f2140
Author: dnj <dnj@chromium.org>
Date: Wed May 03 15:47:15 2017

LogDog Viewer: Link back to source build.

As of tools/build commit 9d20a223d82b56419650d8fccbc85e05d81ca140,
LogDog streams may export a "logdog.viewer_url" tag that associates a
URL with the log stream. Update the viewer to check for this tag and, if
present, convert the log stream title at the top of the viewer into a
link pointing to that URL.

BUG= chromium:713986 
TEST=local
  - Tested with a local viewer, seems to be working.

R=hinoka@chromium.org, nodir@chromium.org

Review-Url: https://codereview.chromium.org/2860453003

[modify] https://crrev.com/be3ef4c9a4c295df8a50f7719f3e990cc57f2140/web/apps/logdog-view/elements/logdog-view/logdog-view.html
[modify] https://crrev.com/be3ef4c9a4c295df8a50f7719f3e990cc57f2140/web/inc/logdog-stream-view/logdog-stream-view.html
[modify] https://crrev.com/be3ef4c9a4c295df8a50f7719f3e990cc57f2140/web/inc/logdog-stream-view/view.ts
[modify] https://crrev.com/be3ef4c9a4c295df8a50f7719f3e990cc57f2140/web/inc/logdog-stream-view/viewer.ts
[modify] https://crrev.com/be3ef4c9a4c295df8a50f7719f3e990cc57f2140/web/inc/logdog-stream/logdog.ts

Comment 7 by d...@chromium.org, May 4 2017

Owner: d...@chromium.org
Status: Fixed (was: Untriaged)
This should be fixed now.

Sign in to add a comment