New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713984 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 510287



Sign in to add a comment

bluetooth: Clean up Web Bluetooth Fakes' ReadRemoteCharacteristic

Project Member Reported by ortuno@chromium.org, Apr 21 2017

Issue description

Our fakes call GattCharacteristicValueChanged before running ReadRemoteCharacteristic's callback. This matched the behavior of the real function but since the function stopped calling GattCharacteristicValueChanged our fakes should do so as well.
 

Comment 1 by ortuno@chromium.org, Apr 21 2017

Status: Fixed (was: Started)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abe917c952a135427bec96cd62d8b7c174d79734

commit abe917c952a135427bec96cd62d8b7c174d79734
Author: ortuno <ortuno@chromium.org>
Date: Fri Apr 21 06:51:53 2017

bluetooth: Match real ReadRemoteCharacteristic's behavior

BluetoothRemoteGattCharacteristic::ReadRemoteCharacteristic used to
dispatch an GattCharacteristicValueChanged event once a characteristic was
read. This side effect was removed but our fakes were not changed.

This patch stops calling GattCharacteristicValueChanged after read operations.

BUG= 713984 

Review-Url: https://codereview.chromium.org/2829853006
Cr-Commit-Position: refs/heads/master@{#466276}

[modify] https://crrev.com/abe917c952a135427bec96cd62d8b7c174d79734/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc

Sign in to add a comment