New issue
Advanced search Search tips

Issue 713975 link

Starred by 0 users
Status: WontFix
Owner:
aga...@chromium.org
Closed: Feb 2018
Cc:
seanmccullough@chromium.org
zhangtiff@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

revert button in codereview tool should have a prefilled template

Project Member Reported by ojan@chromium.org, Apr 21 2017 
The revert button is great! But sheriff’s often don’t give thorough revert reasons. There should be a template to fill out. Something like:

REVERT REASON:
LINKS TO FAILING BOTS (not just to the logs):
[optional] LINKS TO LOGS:
etc.

Comment 1 by zhangtiff@chromium.org, Feb 14 2018

Cc: zhangtiff@chromium.org seanmccullough@chromium.org
Components: -Infra>Sheriffing Infra>Codereview>Gerrit
I believe this is more of a Gerrit bug. I'll keep Sean and I CCed though since I think, if Gerrit team chooses to implement this, we might have to discuss how these templates would be surfaced in sheriff-specific situations. Since revert is used for a lot more than sheriffing.

Comment 2 by aga...@chromium.org, Feb 14 2018

Owner: aga...@chromium.org
Status: WontFix (was: Untriaged)
There already is a template to fill out, it's the thing with "REVERT REASON:" in it :) By default, Gerrit doesn't even give that much.

We already customize the commit message created by the revert button, and so we could customize it more. But as Tiffany said, it is used by many more repos than Chromium, and changes are reverted for many more reasons than just failing bots with logs to look at. So I'm reticent to add such specific fields to the revert prompt.
►

Sign in to add a comment