New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713965 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD Bookmarks] Crash when opening chrome-extension:// bookmark

Project Member Reported by tsergeant@chromium.org, Apr 21 2017

Issue description

Steps to reproduce:

1. Open a URL like chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html (the inner PDF viewer extension) and press Ctrl-D to bookmark
2. Open MD Bookmarks
3. Double click the PDF viewer bookmark to open it

Expected behavior:

PDF UI should open (works correctly in the current BMM)

Actual behavior:

Browser crash!

Received signal 11 SEGV_MAPERR 000000000138
#0 0x7fa95b74d137 base::debug::StackTrace::StackTrace()
#1 0x7fa95b74ccaf base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fa95b476330 <unknown>
#3 0x55633a36ebc6 std::_Rb_tree<>::find()
#4 0x55633ad491a0 extensions::Extension::GetManifestData()
#5 0x55633ad6ab5c extensions::IncognitoInfo::IsSplitMode()
#6 0x55633aeac735 extensions::ExtensionTabUtil::OpenTab()
#7 0x55633ae7f84f extensions::TabsCreateFunction::Run()

Given the signature, this is probably something to do with running chrome.tabs.create from a WebUI context.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/862d903230e664fa75a09f6546366cb51e1e53bd

commit 862d903230e664fa75a09f6546366cb51e1e53bd
Author: calamity <calamity@chromium.org>
Date: Mon May 22 07:14:28 2017

[MD Bookmarks] Fix crash when opening a chrome-extension:// URL.

This CL fixes a crash which was happening because the bookmark manager
API expects an extension to be associated with the WebUI.

BUG= 713965 

Review-Url: https://codereview.chromium.org/2864213002
Cr-Commit-Position: refs/heads/master@{#473518}

[modify] https://crrev.com/862d903230e664fa75a09f6546366cb51e1e53bd/chrome/browser/extensions/extension_tab_util.cc

Status: Fixed (was: Assigned)
Hooray!

Sign in to add a comment