New issue
Advanced search Search tips

Issue 713931 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Refactor mac signing scripts for development workflow

Project Member Reported by kerrnel@chromium.org, Apr 20 2017

Issue description

Refactor the mac signing scripts to make signing with a development cert, or rolling the certificate, easier.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4223ead6668664ae3cbfc0cb2f58c0294adc327f

commit 4223ead6668664ae3cbfc0cb2f58c0294adc327f
Author: kerrnel <kerrnel@chromium.org>
Date: Tue May 02 18:56:51 2017

Refactor mac signing scripts for development workflow

Refactor the mac signing scripts to add a --development flag,
so that a default designated requirement is used for development
builds. This also moves all the varaibles that need to be changed
to update the official signing certificate into one file.

BUG= 713931 

Review-Url: https://codereview.chromium.org/2832073002
Cr-Commit-Position: refs/heads/master@{#468727}

[modify] https://crrev.com/4223ead6668664ae3cbfc0cb2f58c0294adc327f/chrome/installer/mac/BUILD.gn
[modify] https://crrev.com/4223ead6668664ae3cbfc0cb2f58c0294adc327f/chrome/installer/mac/OWNERS
[modify] https://crrev.com/4223ead6668664ae3cbfc0cb2f58c0294adc327f/chrome/installer/mac/sign_app.sh.in
[modify] https://crrev.com/4223ead6668664ae3cbfc0cb2f58c0294adc327f/chrome/installer/mac/sign_installer_tools.sh
[modify] https://crrev.com/4223ead6668664ae3cbfc0cb2f58c0294adc327f/chrome/installer/mac/sign_versioned_dir.sh.in
[add] https://crrev.com/4223ead6668664ae3cbfc0cb2f58c0294adc327f/chrome/installer/mac/variables.sh

Status: Fixed (was: Started)
Target 'make_signers' seems to be broken after this change. Since it does not have 'copies' target in deps.
re #13: Can you please open a new bug about make_signers being broken, including the details of the problem?
Here is it https://bugs.chromium.org/p/chromium/issues/detail?id=728241
Sorry I have no idea how to link it.

Sign in to add a comment