New issue
Advanced search Search tips

Issue 713911 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Jul 2017
Cc:
twelling...@chromium.org
tedc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Toolbar should animate reappearance

Project Member Reported by mdjones@chromium.org, Apr 20 2017 
Currently the toolbar pops back on screen when a navigation is triggered and it is hidden. Instead it should animate back on-screen.

This is not necessarily related to Chrome Home but is more apparent since the toolbar is larger.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/861bce1518ab2209ba6fcdc7d0d99d9aa775c01b

commit 861bce1518ab2209ba6fcdc7d0d99d9aa775c01b
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Jul 18 16:34:40 2017

[Home] Allow bottom controls animation

The animation logic in the BrowserControlsOffsetManager did not
previously account for bottom controls when triggering an early exit.
This change only skips animation if both top and bottom browser
controls are 0.

BUG= 713911 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9b4a24abfcb3cdd9184370d7bc401dbdec37daa9
Reviewed-on: https://chromium-review.googlesource.com/557953
Reviewed-by: Alexandre Elias <aelias@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487497}
[modify] https://crrev.com/861bce1518ab2209ba6fcdc7d0d99d9aa775c01b/cc/input/browser_controls_offset_manager.cc
[modify] https://crrev.com/861bce1518ab2209ba6fcdc7d0d99d9aa775c01b/cc/input/browser_controls_offset_manager_unittest.cc

Comment 2 by mdjones@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment