New issue
Advanced search Search tips

Issue 713910 link

Starred by 1 user
Status: Verified
Owner:
mcasas@chromium.org
Closed: Apr 2017
Cc:
fbeaufort@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Image Capture Android 2: applyConstraints(.... iso: bla ) is ignored

Project Member Reported by mcasas@chromium.org, Apr 20 2017 
In the demo [1] on a Nexus 6 w/ Canary, either of the Js lines:

theTrack.applyConstraints({advanced: [ {exposureMode : "manual", iso : 100}] });

and/or

theTrack.applyConstraints({advanced: [ {iso : 100}] });



does not produced the desired effect, the |iso| setting is ignored.







[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80d0234a6c13bba1e14ca76f48d7c437fe5b020e

commit 80d0234a6c13bba1e14ca76f48d7c437fe5b020e
Author: mcasas <mcasas@chromium.org>
Date: Fri Apr 21 15:57:10 2017

Image Capture: set SENSOR_EXPOSURE_TIME when CONTROL_AE_MODE_OFF

This CL addresses a bug from the field: when the |exposureMode| is set to
"manual", the camera abandons all AutoExposure and the captured image
turns black, because the exposure time needs to be configured explicitly.

The solution is to set it to the middle of the allowed range, leaving
further configuration to the Iso (SENSOR_SENSITIVITY).

BUG= 713910 

Review-Url: https://codereview.chromium.org/2827253004
Cr-Commit-Position: refs/heads/master@{#466350}

[modify] https://crrev.com/80d0234a6c13bba1e14ca76f48d7c437fe5b020e/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

Comment 2 by mcasas@chromium.org, Apr 21 2017

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 21 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda64b9c75a79848d2b7a547e3d8ef64ce024fa3

commit cda64b9c75a79848d2b7a547e3d8ef64ce024fa3
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Fri Apr 21 18:31:57 2017

Image Capture: set SENSOR_EXPOSURE_TIME when CONTROL_AE_MODE_OFF

This CL addresses a bug from the field: when the |exposureMode| is set to
"manual", the camera abandons all AutoExposure and the captured image
turns black, because the exposure time needs to be configured explicitly.

The solution is to set it to the middle of the allowed range, leaving
further configuration to the Iso (SENSOR_SENSITIVITY).

BUG= 713910 

Review-Url: https://codereview.chromium.org/2827253004
Cr-Commit-Position: refs/heads/master@{#466350}
(cherry picked from commit 80d0234a6c13bba1e14ca76f48d7c437fe5b020e)

Review-Url: https://codereview.chromium.org/2834843003 .
Cr-Commit-Position: refs/branch-heads/3071@{#124}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/cda64b9c75a79848d2b7a547e3d8ef64ce024fa3/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java

Comment 5 by mcasas@chromium.org, Apr 21 2017

Status: Fixed (was: Started)

Comment 6 by fbeaufort@chromium.org, Apr 25 2017

Status: Verified (was: Fixed)
Verified in Chromium 60.0.3081.0.
►

Sign in to add a comment