Infobar animation in Chrome Home |
||||
Issue descriptionIn Chrome Home, infobars should not start animating off-screen until the toolbar is completely hidden. This will reduce the amount of visual noise when scrolling from the top of a page.
,
Jul 27 2017
Attaching video of new behavior.
,
Jul 27 2017
@cleer, what should the behavior be if the user changes scroll direction when the infobar is partially hidden? As of now, the infobar will retain its current visibility and not change until the toolbar is completely shown or hidden.
,
Jul 28 2017
One possible alternative is to snap the infobar to full or hidden if the direction changes.
,
Jul 28 2017
,
Aug 7 2017
Attaching video of partially hidden scroll behavior.
,
Aug 8 2017
Uploading recording with snap behavior on scroll direction switch:
,
Aug 10 2017
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12 commit fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Aug 21 18:24:55 2017 [Home] Only animate infobars after toolbar has finished To reduce the amount of visual noise at the bottom of the screen when Chrome Home is enabled, infobars will only scroll after the toolbar has stopped moving. - When appearing, the infobar will begin showing only after the toolbar is completely visible. - When hiding, the infobar will not hide until the toolbar is completely invisible. - If the scroll direction changes while the infobar container is not completely shown or hidden, it will snap to the nearest state. BUG= 713909 Change-Id: I3fa4a75d8e03136a2eeaa8baf799d4533dc302ad Reviewed-on: https://chromium-review.googlesource.com/590928 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc (OOO 8.21-25) <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#495995} [modify] https://crrev.com/fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java [modify] https://crrev.com/fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
,
Aug 21 2017
,
Aug 22 2017
Infobar animation is expected as mentioned @ #8 on latest M62-62.0.3193.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by k...@chromium.org
, Apr 20 2017