New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713909 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Infobar animation in Chrome Home

Project Member Reported by mdjones@chromium.org, Apr 20 2017

Issue description

In Chrome Home, infobars should not start animating off-screen until the toolbar is completely hidden. This will reduce the amount of visual noise when scrolling from the top of a page.
 

Comment 1 by k...@chromium.org, Apr 20 2017

Labels: Hotlist-Chrome-Home
Attaching video of new behavior.
recording.mp4
4.4 MB View Download
@cleer, what should the behavior be if the user changes scroll direction when the infobar is partially hidden? As of now, the infobar will retain its current visibility and not change until the toolbar is completely shown or hidden.
One possible alternative is to snap the infobar to full or hidden if the direction changes.
Status: Started (was: Assigned)
Attaching video of partially hidden scroll behavior.
recording.mp4
5.4 MB View Download
Uploading recording with snap behavior on scroll direction switch:
recording.mp4
3.6 MB View Download

Comment 8 by kings...@google.com, Aug 10 2017

Labels: Fine-Pri-2.0
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12

commit fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Aug 21 18:24:55 2017

[Home] Only animate infobars after toolbar has finished

To reduce the amount of visual noise at the bottom of the screen when
Chrome Home is enabled, infobars will only scroll after the toolbar
has stopped moving.

- When appearing, the infobar will begin showing only after the
  toolbar is completely visible.
- When hiding, the infobar will not hide until the toolbar is
  completely invisible.
- If the scroll direction changes while the infobar container is not
  completely shown or hidden, it will snap to the nearest state.

BUG= 713909 

Change-Id: I3fa4a75d8e03136a2eeaa8baf799d4533dc302ad
Reviewed-on: https://chromium-review.googlesource.com/590928
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc (OOO 8.21-25) <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495995}
[modify] https://crrev.com/fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12/chrome/android/java/src/org/chromium/chrome/browser/banners/SwipableOverlayView.java
[modify] https://crrev.com/fcb6dbaa8625155ba1346086a4e1ddeadfc7ba12/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

Status: Fixed (was: Started)
Infobar animation is expected as mentioned @ #8 on latest M62-62.0.3193.0 

Sign in to add a comment