New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713899 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

feedback reporting: wifi: Don't mangle a mac address that's all 0s, it's not valid and confuses everyone!

Project Member Reported by kirtika@chromium.org, Apr 20 2017

Issue description

Here's a snippet from a representative feedback report, most
of them suffer from this issue:


2017-03-20T14:01:47.993809-07:00 DEBUG wpa_supplicant[559]: wlan0: New scan results available (own=1 ext=0)
2017-03-20T14:01:47.993988-07:00 DEBUG wpa_supplicant[559]: wlan0: Radio work 'scan'@0x6039a907eaa0 done in 3.384935 seconds
2017-03-20T14:01:47.994073-07:00 DEBUG wpa_supplicant[559]: wlan0: Selecting BSS from priority group 0
2017-03-20T14:01:47.994162-07:00 DEBUG wpa_supplicant[559]: wlan0: 0: 94:b4:0f:00:00:50 ssid='2' wpa_ie_len=0 rsn_ie_len=20 caps=0x1111 level=-61 freq=5700 
2017-03-20T14:01:47.994230-07:00 DEBUG wpa_supplicant[559]: wlan0:    skip - SSID mismatch
2017-03-20T14:01:47.994361-07:00 DEBUG wpa_supplicant[559]: wlan0: 1: 94:b4:0f:00:00:08 ssid='1' wpa_ie_len=0 rsn_ie_len=20 caps=0x1111 level=-62 freq=5700 
2017-03-20T14:01:47.994438-07:00 DEBUG wpa_supplicant[559]: wlan0:    selected based on RSN IE
2017-03-20T14:01:47.994516-07:00 DEBUG wpa_supplicant[559]: wlan0:    selected BSS 94:b4:0f:00:00:08 ssid='1'
2017-03-20T14:01:47.994615-07:00 DEBUG wpa_supplicant[559]: wlan0: 

// the 00:08 is a real AP MAC address here, that's great.
// What about the 00:0c? It doesn't occur anywhere else in the
// logs!

Considering connect request: reassociate: 1  selected: 94:b4:0f:00:00:08  bssid: 00:00:00:00:00:0c  pending: 00:00:00:00:00:0c  wpa_state: SCANNING  ssid=0x6039a8ffdd10  current_ssid=0x6039a8ffdd10
2017-03-20T14:01:47.994689-07:00 DEBUG wpa_supplicant[559]: wlan0: Request association with 94:b4:0f:00:00:08
2017-03-20T14:01:47.994746-07:00 DEBUG wpa_supplicant[559]: wlan0: Re-association to the same ESS
2017-03-20T14:01:47.994803-07:00 DEBUG wpa_supplicant[559]: TDLS: TDLS is allowed in the target BSS


This log line is very helpful for debugging wpa-supplicant state.
In most cases (when we are not transitioning from one AP to another),
the bssid: and pending: fields are "00:00:00:00:00:00". 
The feedback reporting tool is treating this as a real MAC address,
and assigning a pseudonym to it, which confuses anyone debugging the logs ("What is the 00:00:00:00:00:0c?"). Don't do this.  

Considering connect request: reassociate: 1  selected: 94:b4:0f:00:00:08  bssid: 00:00:00:00:00:0c  pending: 00:00:00:00:00:0c  wpa_state: SCANNING  ssid=0x6039a8ffdd10  current_ssid=0x6039a8ffdd10


 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e8fefb6515d08954ef8bd71885acec17eae74ba6

commit e8fefb6515d08954ef8bd71885acec17eae74ba6
Author: Brian Norris <briannorris@chromium.org>
Date: Sat Sep 16 06:39:27 2017

debugd: anonymizer: don't anonymize empty and broadcast MAC

00:00:00:00:00:00 is a non-existent MAC address (sometimes means "not
configured"). Don't confuse things by trying to anonymize it.

Same thing for the broadcast address (all ff's).

BUG= chromium:713899 
TEST=unittests

Change-Id: I4a5ff2ad99a0ad790f83a75545495dca33675b4a
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/669942
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/e8fefb6515d08954ef8bd71885acec17eae74ba6/debugd/src/anonymizer_tool.cc
[modify] https://crrev.com/e8fefb6515d08954ef8bd71885acec17eae74ba6/debugd/src/anonymizer_tool_test.cc

Owner: briannorris@chromium.org
Status: Fixed (was: Untriaged)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Cc: -yoshi@chromium.org

Sign in to add a comment