New issue
Advanced search Search tips

Issue 713892 link

Starred by 1 user
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Switch from MADV_FREE to MADV_FREE_REUSABLE for DiscardableSharedMemory.

Project Member Reported by erikc...@chromium.org, Apr 20 2017 
On macOS, MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the
reusable bit, which allows both Activity Monitor and memory-infra to correctly
track the pages.

See longer discussion at https://bugs.chromium.org/p/chromium/issues/detail?id=708797#c29.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61f066322d740afe3e2b17789fbc8960ed56558b

commit 61f066322d740afe3e2b17789fbc8960ed56558b
Author: erikchen <erikchen@chromium.org>
Date: Fri Apr 21 07:10:39 2017

macOS: Use MADV_FREE_REUSABLE for discardable shared memory.

MADV_FREE_REUSABLE has comparable behavior, but also marks the pages with the
reusable bit, which allows both Activity Monitor and memory-infra to correctly
track the pages.

BUG= 713892 

Review-Url: https://codereview.chromium.org/2834743002
Cr-Commit-Position: refs/heads/master@{#466280}

[modify] https://crrev.com/61f066322d740afe3e2b17789fbc8960ed56558b/base/memory/discardable_shared_memory.cc

Comment 2 by erikc...@chromium.org, Apr 24 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment