Changing the page selection in print preview should not cause a re-render |
||
Issue descriptionWhat steps will reproduce the problem? (1) Build Chromium with some logging in PrintPreviewDataService to see what it is doing. (2) Visit a webpage that prints out on muliple pages. (3) Print preview. (4) Change the page selection. What is the expected result? Print preview should get the preview data from PrintPreviewDataService. No new data should be going into PrintPreviewDataService. What happens instead? Print preview is re-rendering the webpage and putting new data into PrintPreviewDataService. Not having to re-render was an optimization added in bug 84383 , but it probably regressed long ago due to print preview JS refactoring.
,
Apr 22 2017
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d62082dec8785c54220a0295033cf12a0edf2d4 commit 2d62082dec8785c54220a0295033cf12a0edf2d4 Author: thestig <thestig@chromium.org> Date: Fri May 05 19:16:45 2017 Print Preview: Make generate draft mode work again. This makes updating the print preview when changing the page range faster. The updated print preview will be stitched together from existing data, rather than re-rendered. BUG= 713860 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2833993004 Cr-Commit-Position: refs/heads/master@{#469749} [modify] https://crrev.com/2d62082dec8785c54220a0295033cf12a0edf2d4/chrome/browser/resources/print_preview/native_layer.js [modify] https://crrev.com/2d62082dec8785c54220a0295033cf12a0edf2d4/chrome/browser/resources/print_preview/preview_generator.js [modify] https://crrev.com/2d62082dec8785c54220a0295033cf12a0edf2d4/chrome/browser/ui/webui/print_preview/print_preview_handler.cc [modify] https://crrev.com/2d62082dec8785c54220a0295033cf12a0edf2d4/chrome/test/data/webui/print_preview.js
,
May 5 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, Apr 22 2017Status: Started (was: Available)