New issue
Advanced search Search tips

Issue 713847 link

Starred by 1 user
Status: Fixed
Owner:
jam@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 598073



Sign in to add a comment

Make browser test requests work when using a network process

Project Member Reported by jam@chromium.org, Apr 20 2017 
We have a RuleBasedHostResolverProc in the browser test harness which tests use to setup rules like map google.com->localhost. This works by modifying globals in net/ for host resolving, but doesn't work when network code is running in a different process.

This bug tracks having the browser test harness automatically send these rules to the network process when it's in use.

In doing this work, I'll have to refactor some code in the browser test harnesses to make the base browser test harness be able to inject code in between SetUpOnMainThread and running the test. We would then enforce that changes to the host resolver have to be done only in SetUpOnMainThread. Most tests do this already, but not all.

While doing the above refactoring, I noticed we don't need SetUpInProcessBrowserTestFixture anymore since we have SetUpOnMainThread now. It was added in https://src.chromium.org/viewvc/chrome?view=revision&revision=26938 but I confirmed we don't need it anymore.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4621c2490b9b9cc5cba1d57a57c6009687190eef

commit 4621c2490b9b9cc5cba1d57a57c6009687190eef
Author: jam <jam@chromium.org>
Date: Thu Apr 20 21:52:36 2017

Replace SyncTest::SetUpInProcessBrowserTestFixture with SyncTest::SetUpOnMainThread.

The former was added a long time ago in https://codereview.chromium.org/214047 before we had SetUpOnMainThread. We don't need SetUpInProcessBrowserTestFixture anymore after the core browser test harness has been split apart. Since SetUpInProcessBrowserTestFixture was added for sync, removing it here first and then I'll remove the other usages later.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2835503003
Cr-Commit-Position: refs/heads/master@{#466151}

[modify] https://crrev.com/4621c2490b9b9cc5cba1d57a57c6009687190eef/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/4621c2490b9b9cc5cba1d57a57c6009687190eef/chrome/browser/sync/test/integration/sync_test.h
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49736bfaaee2f7f1c641daf66516ce540eddcbd2

commit 49736bfaaee2f7f1c641daf66516ce540eddcbd2
Author: jam <jam@chromium.org>
Date: Thu Apr 20 22:45:00 2017

Replace SetUpInProcessBrowserTestFixture/TearDownInProcessBrowserTestFixture usage in content with SetUpOnMainThread/TearDownOnMainThread.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2832023002
Cr-Commit-Position: refs/heads/master@{#466171}

[modify] https://crrev.com/49736bfaaee2f7f1c641daf66516ce540eddcbd2/content/browser/accessibility/cross_platform_accessibility_browsertest.cc
[modify] https://crrev.com/49736bfaaee2f7f1c641daf66516ce540eddcbd2/content/browser/speech/speech_recognition_browsertest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f

commit b3877746a0165c9eea1a3b8892ebe6c6feae8f1f
Author: jam <jam@chromium.org>
Date: Mon Apr 24 16:27:08 2017

Move calling of shared browser test methods like SetUpOnMainThread/TearDownOnMainThread/RunTestOnMainThread into the shared browser test launcher code.

This is done because in a future change, I will add code to run in between SetUpOnMainThread and the test.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2832153003
Cr-Commit-Position: refs/heads/master@{#466648}

[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/browser/downgrade/user_data_downgrade_browsertest.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/browser/extensions/api/screenlock_private/screenlock_private_apitest.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chrome/test/base/in_process_browser_test.h
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chromecast/browser/renderer_prelauncher_test.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chromecast/browser/test/cast_browser_test.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/chromecast/browser/test/cast_browser_test.h
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/content/public/test/browser_test_base.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/content/public/test/browser_test_base.h
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/content/public/test/content_browser_test.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/content/public/test/content_browser_test.h
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/extensions/browser/guest_view/web_view/web_view_apitest.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/extensions/browser/guest_view/web_view/web_view_apitest.h
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/extensions/shell/test/shell_test.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/extensions/shell/test/shell_test.h
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/headless/test/headless_browser_test.cc
[modify] https://crrev.com/b3877746a0165c9eea1a3b8892ebe6c6feae8f1f/headless/test/headless_browser_test.h
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/700d86f404cceb4d49e2a1ed0b6f584839e43fde

commit 700d86f404cceb4d49e2a1ed0b6f584839e43fde
Author: jam <jam@chromium.org>
Date: Tue Apr 25 20:04:19 2017

Sync the browser test host resolver with the network process before a test runs.

This fixes the browser tests which use the in-process host resolver, which depends on globals in the network code.

Most of the tests already call host_resolver()->AddRule in their SetUpOnMainThread. This will be enforced once the remaining ones which don't do this are updated.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2837813004
Cr-Commit-Position: refs/heads/master@{#467082}

[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/network/manifest.json
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/network/network_service.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/network/network_service.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/common/BUILD.gn
[add] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/common/network_service_test.mojom
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/browser_test_base.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/browser_test_base.h
[add] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/test_host_resolver.cc
[add] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/test_host_resolver.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/utility/content_utility_client.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/shell/BUILD.gn
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/shell/utility/shell_content_utility_client.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/shell/utility/shell_content_utility_client.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/test/BUILD.gn
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/utility/utility_service_factory.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/utility/utility_service_factory.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/net/dns/mock_host_resolver.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/net/dns/mock_host_resolver.h
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/700d86f404cceb4d49e2a1ed0b6f584839e43fde

commit 700d86f404cceb4d49e2a1ed0b6f584839e43fde
Author: jam <jam@chromium.org>
Date: Tue Apr 25 20:04:19 2017

Sync the browser test host resolver with the network process before a test runs.

This fixes the browser tests which use the in-process host resolver, which depends on globals in the network code.

Most of the tests already call host_resolver()->AddRule in their SetUpOnMainThread. This will be enforced once the remaining ones which don't do this are updated.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2837813004
Cr-Commit-Position: refs/heads/master@{#467082}

[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/network/manifest.json
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/network/network_service.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/network/network_service.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/common/BUILD.gn
[add] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/common/network_service_test.mojom
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/browser_test_base.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/browser_test_base.h
[add] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/test_host_resolver.cc
[add] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/test/test_host_resolver.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/public/utility/content_utility_client.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/shell/BUILD.gn
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/shell/utility/shell_content_utility_client.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/shell/utility/shell_content_utility_client.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/test/BUILD.gn
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/utility/utility_service_factory.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/content/utility/utility_service_factory.h
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/net/dns/mock_host_resolver.cc
[modify] https://crrev.com/700d86f404cceb4d49e2a1ed0b6f584839e43fde/net/dns/mock_host_resolver.h
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162

commit 8f34ea7b0b5524e427fbadad6e0cb06e8ff59162
Author: jam <jam@chromium.org>
Date: Wed Apr 26 17:48:55 2017

Ensure all content_browsertests call the host resolver in SetUpOnMainThread and not after.

BUG= 713847 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2838293002
Cr-Commit-Position: refs/heads/master@{#467370}

[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/accessibility/accessibility_win_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/accessibility/hit_testing_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/accessibility/snapshot_ax_tree_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/android/render_widget_host_connector_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/devtools/site_per_process_devtools_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/download/download_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/frame_host/navigation_handle_impl_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/frame_host/render_frame_message_filter_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/loader/resource_dispatcher_host_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/renderer_host/render_widget_host_view_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/web_contents/opened_by_dom_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/8f34ea7b0b5524e427fbadad6e0cb06e8ff59162/content/test/browser_test_utils_browsertest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f2d393a778cf804b6641c27fa8a7ae48cdb8343

commit 3f2d393a778cf804b6641c27fa8a7ae48cdb8343
Author: jam <jam@chromium.org>
Date: Wed Apr 26 20:28:51 2017

Fix integration tests in src/chrome and src/extensions so that we can turn on IO thread checks without failures.

These were never turned on because they were only in content_browsertests. We should turn them on everywhere to catch changes that make blocking I/O calls on the UI or (non-blocking) IO threads.

In the follow up cl, I'll turn on IO checks on the main thread in integration tests in src/chrome.

BUG= 713847 
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2835233002
Cr-Commit-Position: refs/heads/master@{#467438}

[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/apps/app_restore_service_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/base/test/multiprocess_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/app_controller_mac_browsertest.mm
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/apps/app_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/chrome_service_worker_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/downgrade/user_data_downgrade_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/download/save_page_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/commands/command_service_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/file_system/file_system_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/i18n/i18n_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/messaging/native_messaging_test_util.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/webrtc_logging_private/webrtc_event_log_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/app_background_page_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/app_process_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/content_verifier_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/crx_installer_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/extension_keybinding_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/extension_webui_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/lazy_background_page_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/startup_helper_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/extensions/test_extension_dir.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/history/redirect_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/importer/edge_importer_browsertest_win.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/importer/ie_importer_browsertest_win.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/lifetime/browser_close_manager_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/media_galleries/fileapi/iapps_finder_impl_win_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/notifications/message_center_settings_controller.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/plugins/plugin_power_saver_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/policy/policy_prefs_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/policy/test/local_policy_test_server.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/prefs/pref_functional_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/prefs/pref_service_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/profiles/profile_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/service_process/service_process_control_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/sessions/session_restore_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/sync/test/integration/bookmarks_helper.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/sync/test/integration/single_client_directory_sync_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/sync/test/integration/sync_extension_helper.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/sync/test/integration/sync_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/task_manager/providers/web_contents/tab_contents_tag_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/themes/theme_service_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/browser_focus_uitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/search/local_ntp_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/startup/startup_browser_creator_corrupt_profiles_browsertest_win.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/startup/startup_browser_creator_interactive_uitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/views/bookmarks/bookmark_bubble_view_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/webui/policy_ui_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/browser/ui/webui/test_files_request_filter.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/base/javascript_browser_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/base/ui_test_utils.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/base/web_ui_browser_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/ppapi/ppapi_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/chrome/test/remoting/qunit_browser_test_runner.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/components/autofill/core/browser/data_driven_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/components/drive/service/fake_drive_service.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/components/subresource_filter/core/common/test_ruleset_creator.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/components/subresource_filter/core/common/test_ruleset_creator.h
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/content/browser/media/capture/desktop_capture_device.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/content/public/test/browser_test_base.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/extensions/browser/api/printer_provider/printer_provider_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/extensions/browser/guest_view/app_view/app_view_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/extensions/browser/guest_view/web_view/web_view_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/extensions/shell/test/shell_apitest.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/extensions/shell/test/shell_test.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/net/test/cert_test_util.cc
[modify] https://crrev.com/3f2d393a778cf804b6641c27fa8a7ae48cdb8343/sql/test/test_helpers.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/348eafc5e89c9537b196af6d58c09762d173df0d

commit 348eafc5e89c9537b196af6d58c09762d173df0d
Author: jam <jam@chromium.org>
Date: Wed Apr 26 23:05:11 2017

Enable thread restriction checks in browser_tests and interactive_ui_tests on all platforms other than ChromeOS.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2844053002
Cr-Commit-Position: refs/heads/master@{#467500}

[modify] https://crrev.com/348eafc5e89c9537b196af6d58c09762d173df0d/chrome/test/base/in_process_browser_test.cc
Project Member

Comment 9 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a5b558831d3e98f4a736e77753eacf8abdfd694

commit 1a5b558831d3e98f4a736e77753eacf8abdfd694
Author: jam <jam@chromium.org>
Date: Mon May 01 16:50:10 2017

Update some host_resolver()->AddRules in chrome/browser.

Part 2/2.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2851103002
Cr-Commit-Position: refs/heads/master@{#468326}

[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/desktop_capture/desktop_capture_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/history/history_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/permissions/permissions_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/streams_private/streams_private_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/api/webrtc_from_web_accessible_resource_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/wake_event_page_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/webstore_inline_installer_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/webstore_installer_test.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/webstore_installer_test.h
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/extensions/window_open_apitest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/net/cookie_policy_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/pdf/pdf_extension_test.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/search_engines/template_url_scraper_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/ui/login/login_handler_browsertest.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc
[modify] https://crrev.com/1a5b558831d3e98f4a736e77753eacf8abdfd694/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
Project Member

Comment 10 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1

commit bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1
Author: jam <jam@chromium.org>
Date: Mon May 01 17:27:59 2017

Update some host_resolver()->AddRules in chrome/browser.

Part 1/2.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2847313002
Cr-Commit-Position: refs/heads/master@{#468343}

[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/chromeos/extensions/wallpaper_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/chromeos/extensions/wallpaper_private_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/chromeos/login/login_manager_test.h
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/chromeos/login/test/oobe_base_test.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/content_settings/content_settings_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/app_background_page_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/app_process_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/chrome_app_api_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/content_capabilities_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/content_script_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/cross_origin_xhr_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/execute_script_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_dom_clipboard_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_incognito_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_javascript_url_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_messages_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_nacl_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_override_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_tabs_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_unload_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_with_management_policy_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/extension_with_management_policy_apitest.h
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/isolated_app_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/lazy_background_page_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/native_bindings_apitest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/browser/extensions/process_management_browsertest.cc
[modify] https://crrev.com/bb11ed744e0fd8ae443be82bfeaf92a70d23f0b1/chrome/test/data/extensions/api_test/executescript/navigation_race/test.js
Project Member

Comment 11 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9cfcb53166c1ad54a7c8d07e205b13b970b2b93

commit a9cfcb53166c1ad54a7c8d07e205b13b970b2b93
Author: jam <jam@chromium.org>
Date: Mon May 01 21:49:13 2017

Update a host_resolver()->AddRule in chrome/browser that I missed earlier.

Part 3/2.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2856593002
Cr-Commit-Position: refs/heads/master@{#468432}

[modify] https://crrev.com/a9cfcb53166c1ad54a7c8d07e205b13b970b2b93/chrome/browser/extensions/process_manager_browsertest.cc
Project Member

Comment 12 by bugdroid1@chromium.org, May 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd5f1e9961edb89b0df27420a76ed3fcc5703424

commit dd5f1e9961edb89b0df27420a76ed3fcc5703424
Author: jam <jam@chromium.org>
Date: Mon May 01 23:21:32 2017

Remove a host_resolver()->ClearRules call in a test body and replace it with an AddRule call that happens in SetUpOnMainThread.

This allows us to enforce that mock host resolver isn't modified in a test body.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2854693002
Cr-Commit-Position: refs/heads/master@{#468479}

[modify] https://crrev.com/dd5f1e9961edb89b0df27420a76ed3fcc5703424/chrome/browser/download/save_page_browsertest.cc
Project Member

Comment 13 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06d120609d01e63b439496a09945d4025b727c4b

commit 06d120609d01e63b439496a09945d4025b727c4b
Author: jam <jam@chromium.org>
Date: Tue May 02 00:44:01 2017

Last set of fixed tests in preparation for enforcing that mock host resolver isn't modified in a test body.

BUG= 713847 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2851213004
Cr-Commit-Position: refs/heads/master@{#468510}

[modify] https://crrev.com/06d120609d01e63b439496a09945d4025b727c4b/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc
[modify] https://crrev.com/06d120609d01e63b439496a09945d4025b727c4b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/06d120609d01e63b439496a09945d4025b727c4b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7267b7d974901c85735a7d3bd3fff186f1f71948

commit 7267b7d974901c85735a7d3bd3fff186f1f71948
Author: jam <jam@chromium.org>
Date: Tue May 02 17:00:09 2017

Enforce that mock host resolver isn't modified in a test body.

This will be incompatible with a network process since we want to synchronize mock rules with it before the test starts.

BUG= 713847 

Review-Url: https://codereview.chromium.org/2850273002
Cr-Commit-Position: refs/heads/master@{#468686}

[modify] https://crrev.com/7267b7d974901c85735a7d3bd3fff186f1f71948/content/public/test/browser_test_base.cc

Comment 15 by jam@chromium.org, May 2 2017

Status: Fixed (was: Started)

Comment 16 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 17 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
►

Sign in to add a comment