New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713842 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Improve Autofill.CardUploadDecisionExpanded histogram

Project Member Reported by jsaul@google.com, Apr 20 2017

Issue description

The Autofill.CardUploadDecisionExpanded histogram reports on the first decision error found.  Reporting on all errors found would help us determine where our efforts are most needed.
 

Comment 1 by csashi@google.com, Apr 23 2017

We log CardUploadDecision as UKM. We could log all reasons in the UKM.

Comment 2 by csashi@google.com, Apr 28 2017

We could log all reasons in UKM and UMA.
Project Member

Comment 3 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf

commit bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf
Author: csashi <csashi@google.com>
Date: Wed May 03 01:09:36 2017

Logs all reasons card upload was not offered in UKM and UMA.

UPLOAD_OFFERED and UPLOAD_NOT_OFFERED are the 2 big buckets.
Other buckets count the specific reasons.

Fixes DeveloperEngagementUkm to also use bit mask instead of separate metrics.

BUG= 713842 

Review-Url: https://codereview.chromium.org/2849753002
Cr-Commit-Position: refs/heads/master@{#468852}

[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/bc9f3b2b440eac0f15e651a9c3fd38eb40c849bf/tools/metrics/ukm/ukm.xml

Comment 4 by csashi@google.com, May 3 2017

Status: Fixed (was: Assigned)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment