New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713829 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression

Blocked on:
issue v8:6282



Sign in to add a comment

Flaky V8_Fatal in Isolate::AddDetachedContext during WebglConformance_conformance_context_context_release_upon_reload

Project Member Reported by ynovikov@chromium.org, Apr 20 2017

Issue description

Seen in https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Release%20%28Intel%29/builds/2262

But, more importantly, this causes flakiness on mac_optional_gpu_tests_rel CQ bot:

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9197
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9200
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9205
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9214
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9216
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9218
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9221
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9229

Strangely, it didn't happen on https://build.chromium.org/p/client.v8.fyi/builders/Mac%20Release%20%28Intel%29

Stack:
#
# Fatal error in ../../v8/src/objects-inl.h, line 2424
# Check failed: index >= 0 && index < this->length().
#
0   Chromium Framework                  0x000000010f7ff9ec base::debug::StackTrace::StackTrace(unsigned long) + 28
1   Chromium Framework                  0x000000011362832b gin::(anonymous namespace)::PrintStackTrace() + 27
2   Chromium Framework                  0x00000001132d8ffc V8_Fatal + 220
3   Chromium Framework                  0x000000010ea8fe82 v8::internal::Isolate::AddDetachedContext(v8::internal::Handle<v8::internal::Context>) + 274
4   Chromium Framework                  0x000000010e5009ac v8::internal::Bootstrapper::DetachGlobal(v8::internal::Handle<v8::internal::Context>) + 188
5   Chromium Framework                  0x000000010e446f88 v8::Context::DetachGlobal() + 104
6   Chromium Framework                  0x0000000112fb0547 blink::ScriptState::DetachGlobalObject() + 119
7   Chromium Framework                  0x0000000112f9b23d blink::LocalWindowProxy::DisposeContext(blink::WindowProxy::Lifecycle) + 957
8   Chromium Framework                  0x0000000112ff486a blink::WindowProxyManager::ClearForNavigation() + 26
9   Chromium Framework                  0x0000000112fa3a92 blink::ScriptController::ClearWindowProxy() + 18
10  Chromium Framework                  0x0000000113c298ea blink::LocalFrame::SetDOMWindow(blink::LocalDOMWindow*) + 42
11  Chromium Framework                  0x00000001141bb618 blink::DocumentLoader::InstallNewDocument(blink::DocumentInit const&, WTF::AtomicString const&, WTF::AtomicString const&, blink::DocumentLoader::InstallNewDocumentReason, blink::ParserSynchronizationPolicy, blink::KURL const&) + 440
12  Chromium Framework                  0x00000001141bb408 blink::DocumentLoader::EnsureWriter(WTF::AtomicString const&, blink::KURL const&) + 872
13  Chromium Framework                  0x00000001141b9ffa blink::DocumentLoader::CommitData(char const*, unsigned long) + 74
14  Chromium Framework                  0x00000001141bbaa0 blink::DocumentLoader::ProcessData(char const*, unsigned long) + 160
15  Chromium Framework                  0x00000001141bb96b blink::DocumentLoader::DataReceived(blink::Resource*, char const*, unsigned long) + 491
16  Chromium Framework                  0x000000010efef732 blink::RawResource::AppendData(char const*, unsigned long) + 114
17  Chromium Framework                  0x000000010f01723b blink::ResourceLoader::DidReceiveData(char const*, int) + 187
18  Chromium Framework                  0x0000000112ed376b content::WebURLLoaderImpl::Context::OnReceivedData(std::__1::unique_ptr<content::RequestPeer::ReceivedData, std::__1::default_delete<content::RequestPeer::ReceivedData> >) + 187
19  Chromium Framework                  0x0000000112ed3fb3 content::WebURLLoaderImpl::RequestPeerImpl::OnReceivedData(std::__1::unique_ptr<content::RequestPeer::ReceivedData, std::__1::default_delete<content::RequestPeer::ReceivedData> >) + 35
20  Chromium Framework                  0x0000000112ea6903 content::ResourceDispatcher::OnReceivedData(int, int, int, int) + 723
21  Chromium Framework                  0x0000000112ea893a bool IPC::MessageT<ResourceMsg_DataReceived_Meta, std::__1::tuple<int, int, int, int>, void>::Dispatch<content::ResourceDispatcher, content::ResourceDispatcher, void, void (content::ResourceDispatcher::*)(int, int, int, int)>(IPC::Message const*, content::ResourceDispatcher*, content::ResourceDispatcher*, void*, void (content::ResourceDispatcher::*)(int, int, int, int)) + 122
22  Chromium Framework                  0x0000000112ea5632 content::ResourceDispatcher::DispatchMessage(IPC::Message const&) + 946
23  Chromium Framework                  0x0000000112ea4ce0 content::ResourceDispatcher::OnMessageReceived(IPC::Message const&) + 688
24  Chromium Framework                  0x0000000112eaa982 content::ResourceSchedulingFilter::DispatchMessage(IPC::Message const&) + 162
25  Chromium Framework                  0x0000000112eaad0d base::internal::Invoker<base::internal::BindState<void (content::ResourceSchedulingFilter::*)(IPC::Message const&), base::WeakPtr<content::ResourceSchedulingFilter>, IPC::Message>, void ()>::Run(base::internal::BindStateBase*) + 189
26  Chromium Framework                  0x000000010f800356 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 310
27  Chromium Framework                  0x000000011359aee4 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue(blink::scheduler::internal::WorkQueue*, bool, blink::scheduler::LazyNow, base::TimeTicks*) + 1284
28  Chromium Framework                  0x00000001135987ce blink::scheduler::TaskQueueManager::DoWork(bool) + 846
29  Chromium Framework                  0x000000011359d019 base::internal::Invoker<base::internal::BindState<void (blink::scheduler::TaskQueueManager::*)(bool), base::WeakPtr<blink::scheduler::TaskQueueManager>, bool>, void ()>::Run(base::internal::BindStateBase*) + 185
30  Chromium Framework                  0x000000010f800356 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 310
31  Chromium Framework                  0x000000010f841279 base::MessageLoop::RunTask(base::PendingTask*) + 441
32  Chromium Framework                  0x000000010f84163c base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 44
33  Chromium Framework                  0x000000010f841ad3 base::MessageLoop::DoWork() + 371
34  Chromium Framework                  0x000000010f8468e0 base::MessagePumpCFRunLoopBase::RunWork() + 48
35  Chromium Framework                  0x000000010f82a45a base::mac::CallWithEHFrame(void () block_pointer) + 10
36  Chromium Framework                  0x000000010f84626f base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63
37  CoreFoundation                      0x00007fffbe54a981 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
38  CoreFoundation                      0x00007fffbe52ba7d __CFRunLoopDoSources0 + 557
39  CoreFoundation                      0x00007fffbe52af76 __CFRunLoopRun + 934
40  CoreFoundation                      0x00007fffbe52a974 CFRunLoopRunSpecific + 420
41  Foundation                          0x00007fffbff3f612 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 277
42  Chromium Framework                  0x000000010f84721e base::MessagePumpNSRunLoop::DoRun(base::MessagePump::Delegate*) + 126
43  Chromium Framework                  0x000000010f8466d7 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 119
44  Chromium Framework                  0x000000010f840fa1 base::MessageLoop::RunHandler() + 369
45  Chromium Framework                  0x000000010f8789a7 base::RunLoop::Run() + 151
46  Chromium Framework                  0x0000000114f829d6 content::RendererMain(content::MainFunctionParams const&) + 742
47  Chromium Framework                  0x000000010f1da555 content::ContentMainRunnerImpl::Run() + 1045
48  Chromium Framework                  0x0000000111255eb8 service_manager::Main(service_manager::MainParams const&) + 1096
49  Chromium Framework                  0x000000010f1d9734 content::ContentMain(content::ContentMainParams const&) + 68
50  Chromium Framework                  0x000000010d13af07 ChromeMain + 119
51  Chromium Helper                     0x000000010c606daa main + 522
52  libdyld.dylib                       0x00007fffd3a83255 start + 1

Going to mark the test Flaky.
 
Note that this WebGL1 test was only seen failing during webgl2_conformance_tests.
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba6bfb3c7d6b702d3378247d9f159ade1f0e90e0

commit ba6bfb3c7d6b702d3378247d9f159ade1f0e90e0
Author: ynovikov <ynovikov@chromium.org>
Date: Thu Apr 20 21:33:31 2017

Mark a WebGL2 test Flaky

conformance/context/context-release-upon-reload.html
on mac sierra intel

BUG= 713829 
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2828963003
Cr-Commit-Position: refs/heads/master@{#466145}

[modify] https://crrev.com/ba6bfb3c7d6b702d3378247d9f159ade1f0e90e0/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 3 by kbr@chromium.org, Apr 20 2017

Blockedon: v8:6282
Labels: GPU-NVidia
Summary: Flaky V8_Fatal in Isolate::AddDetachedContext during WebglConformance_conformance_context_context_release_upon_reload on Mac (was: Flaky V8_Fatal in Isolate::AddDetachedContext during WebglConformance_conformance_context_context_release_upon_reload on Mac Intel)
Also spotted on NVIDIA
https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release%20%28NVIDIA%29/builds/1762
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9267
Cc: hablich@chromium.org machenb...@chromium.org petermarshall@chromium.org jkummerow@chromium.org
Status: Available (was: Untriaged)
Can this be related to 705341 or 708343?

Labels: -GPU-AMD -GPU-Intel -GPU-NVidia -OS-Mac OS-All
Summary: Flaky V8_Fatal in Isolate::AddDetachedContext during WebglConformance_conformance_context_context_release_upon_reload (was: Flaky V8_Fatal in Isolate::AddDetachedContext during WebglConformance_conformance_context_context_release_upon_reload on Mac)
Also seen this V8_Fatal on Nexus 5X:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%205X%29/builds/7696

The stack is not available, but it's the same test and the same message:
  	04-27 10:07:03.530  8112  8125 E v8      : # Fatal error in ../../v8/src/objects-inl.h, line 2412
  	04-27 10:07:03.530  8112  8125 E v8      : # 
  	04-27 10:07:03.531  8112  8125 E v8      : Check failed: index >= 0 && index < this->length().

Owner: cbruni@chromium.org
Status: Assigned (was: Available)
V8 stability sheriff, PTAL
FYI, the V8 issue has been fixed (hopefully -- I've never managed to repro so I can't verify the fix), so when 63a40cae7c23c36e8b9c13f52a19a6f262f40d81 rolls into Chromium, you can restore test expectations.

#6: No, unrelated. (Probably.)

Comment 10 by kbr@chromium.org, May 2 2017

Owner: kbr@chromium.org
That's excellent news Jakob! Thank you for tracking this down.

Taking the bug to remove the flaky expectation.

Project Member

Comment 11 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7abeadf366ceeff7cc81a29cf8026356c2b50a77

commit 7abeadf366ceeff7cc81a29cf8026356c2b50a77
Author: kbr <kbr@chromium.org>
Date: Thu May 04 00:48:48 2017

Remove context-release-upon-reload suppression.

BUG= 713829 
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2855323002
Cr-Commit-Position: refs/heads/master@{#469222}

[modify] https://crrev.com/7abeadf366ceeff7cc81a29cf8026356c2b50a77/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 12 by kbr@chromium.org, May 4 2017

Owner: jkummerow@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment