New issue
Advanced search Search tips

Issue 713827 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

authpolicy: Report password expiration and last auth error

Project Member Reported by ljusten@chromium.org, Apr 20 2017

Issue description

Memorize last error from AuthenticateUser and report that in GetUserStatus. Also report password expiration using pwdLastSet.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/b94f37739489ba79c1585eed8cddd7b742a541c3

commit b94f37739489ba79c1585eed8cddd7b742a541c3
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu May 04 02:40:24 2017

authpolicy: Add password and last error status

Adds data so that Chrome can detect situations where it has to prompt
the user to relog and possibly change their password or enter the new
one if it changed on the server. The corresponding authpolicyd change
is in CL:484320.

BUG= chromium:713827 
TEST=Compiles

Change-Id: Ib1aa476d467290ae7680da8e2dd4a883a3680dc4
Reviewed-on: https://chromium-review.googlesource.com/483403
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/b94f37739489ba79c1585eed8cddd7b742a541c3/dbus/authpolicy/active_directory_info.proto

Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/b94f37739489ba79c1585eed8cddd7b742a541c3

commit b94f37739489ba79c1585eed8cddd7b742a541c3
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu May 04 02:40:24 2017

authpolicy: Add password and last error status

Adds data so that Chrome can detect situations where it has to prompt
the user to relog and possibly change their password or enter the new
one if it changed on the server. The corresponding authpolicyd change
is in CL:484320.

BUG= chromium:713827 
TEST=Compiles

Change-Id: Ib1aa476d467290ae7680da8e2dd4a883a3680dc4
Reviewed-on: https://chromium-review.googlesource.com/483403
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/b94f37739489ba79c1585eed8cddd7b742a541c3/dbus/authpolicy/active_directory_info.proto

Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7afef278595357100d354548df92c0fc9a52e2ba

commit 7afef278595357100d354548df92c0fc9a52e2ba
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed May 24 22:11:51 2017

histograms/enums: Sync with latest authpolicy additions

Adds a new error type that allows us to distinguish invalid machine
names (i.e. containing invalid characters) from bad machine names
(e.g. deleted from Active Directory), see
https://chromium-review.googlesource.com/c/483099.

Also adds metrics related to getting user status, see
https://chromium-review.googlesource.com/c/458220 and
https://chromium-review.googlesource.com/c/481319.

BUG= chromium:713827 
TEST=Stared carefully at XML. Also tests passed.

Change-Id: Idc0a2bcd91f7bf668a8ee78de767e43508d256c9
Reviewed-on: https://chromium-review.googlesource.com/514042
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474438}
[modify] https://crrev.com/7afef278595357100d354548df92c0fc9a52e2ba/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7afef278595357100d354548df92c0fc9a52e2ba/tools/metrics/histograms/histograms.xml

Status: FIxed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment