New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713822 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Cast shows empty bubble when clicked, not dialog.

Project Member Reported by pinkerton@chromium.org, Apr 20 2017

Issue description

macOS 10.12.4
58.0.3029.81 beta (64-bit)

Since updating to the latest beta, the bubble for Cast is blank. This is with devices present. Restarting the extension doesn't help. Restarting the app doesn't help. 

See attached screenshot.
 
Screen Shot 2017-04-20 at 2.43.58 PM.png
76.8 KB View Download
Choosing "Cast..." from the hamburger menu does work correctly. 
Cc: gov...@chromium.org abdulsyed@chromium.org ligim...@chromium.org
Without the device I am getting bubble, but unfortunately do not have the device. Looping to Abdul and Krishna to interact with cast team for further triaging.

pinkerton@ Could you also provide the extension that you are using.

Chrome Version Tested : 58.0.3029.81 
OS: Win and Mac
I'm using Cast extensions version 15.1120.0.4. Going to the store it says it's discontinued. 

So is this now no longer a valid way of accessing Cast? Why did it work up until the latest beta?
On the chrome side we took few Cls with respect to opacity and dialog views changes in recent Beta.  Not sure whether they have some impact. 

Please keep us posted if you encounter the same in any websites.

Cc: sko...@chromium.org imch...@chromium.org
Since Chrome 50-ish the Cast extension from the Web Store is no longer needed to cast. It was replaced by the component extension which should always be there for you. The toolbar icon should've migrated from the extension icon to the permanent one.

Might just be some discovery issues (it's been rewritten in C++) or maybe a weird interaction between the disabled installed extension and the new implementation.
Owner: taku...@chromium.org
Takumi -- this looks similar to  crbug.com/691575 . The screenshot shows that the browser icon is still trying to launch the legacy extension bubble. Do you pushing the self-uninstalling legacy extension to beta will fix this issue?
Owner: sko...@chromium.org
Status: Assigned (was: Untriaged)
pinkerton@, would you mind checking chrome://extensions to see if you have "Google Cast" and/or "Google Cast (Beta)" enabled? You should have former but not the latter. We are currently updating those two extensions to uninstall themselves (b/24004297). We pushed the update for the beta yesterday, and will be updating the stable extension before the M58 release as well.

skonig@/imcheng@, I wonder if we still want to wait until Monday to update the stable extension, given the M58 release is scheduled for Tuesday.

Comment 8 by gov...@chromium.org, Apr 20 2017

Re #7: M58 #58.0.3029.81 already went out to small percentage of Stable users for Windows & Mac, 100% Linux yesterday.
Thanks, govind@.
skonig@, I think we should update the stable extension today as well. What do you think?
Has our internal testing verified that the uninstall is working?  If so I
am okay to push early (given the M58 rollout), but it's a bit risky since
we lack any data yet on whether it's working with the Beta extension (won't
get that until tomorrow).
Owner: taku...@chromium.org
Status: Started (was: Assigned)
Talked with Stephen, and just pushed an update to the stable extension (17.418.0.0). It should update and uninstall itself. We'll check the uninstall numbers tomorrow to confirm that it's working. The beta extension, which was updated yesterday, has had many uninstalls already.
Assuming there is no chrome side merges requires. It would be great if someone could confirm.
#12: Right, there should be no changes required on the Chromium side.
Cc: melodychu@chromium.org
The extension disappeared from my toolbar, and the internal cast icon is now in the hamburger menu. Accessing it puts it back on the toolbar. Clicking it shows the right thing. 

If the behavior users experience when upgrading is the cast icon disappearing from their toolbar, we're going to have a lot of confused users. The way to get it back is not very clear. Is there some kind of HelpCenter feedback we can put up, or brief the gCon folks (melodychu)?
Status: Fixed (was: Started)
We migrated from the old Cast extension/toolbar icon to Media Router toolbar icon a while back. The user preference to show the new toolbar icon was set if the legacy extension was installed.

For the users that had installed the legacy extension, we were unloading it at startup. There was a regression in M58 that caused the extension to not get unloaded if it was disabled. That meant that users could re-enable the legacy extension from chrome://extensions, and the legacy toolbar icon (no longer functional) would reappear. Whether the legacy extension is enabled does not affect the new icon. Instead of continuing to suppress the legacy extension, we decided to update the extension so that it would uninstall itself.

Marking this fixed, as uninstallation numbers are high as expected.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-58; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-58 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Per comment #13, there is no changes required on the Chromium side so no merge is needed. Hence, removing "Merge-TBD" label.
My legacy extension was enabled. For a day, it was not operational (this bug). Then it vanished. If I didn't work on this team, I wouldn't understand where it went and how to get the built-in one to show up. I don't think this is a great experience. 
There should be no impact for users who didn't notice that the legacy
extension had been temporarily re-enabled, which will be the vast majority
since M58 is just now rolling out to stable.

Sign in to add a comment