New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713814 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

cros_ec_commands.h in v3.18 kernel is out-of-sync with EC's ec_commands.h

Project Member Reported by nvaccaro@chromium.org, Apr 20 2017

Issue description

What steps will reproduce the problem?
(1)Get to a console on a Caroline running top-of-tree software.
(2)execute command "ectool motionsense fifo_info"
(3)note the failure response : "ioctl -1, errno 90 (Message too long), EC result 0 (success)"

What is the expected result?
The ectool motionsense command should work.

What happens instead?
Command failed due to mismatch in parameters structure sizes.

 

Comment 1 Deleted

Cc: -asasadeade@chromium.org aaboagye@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2017

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2002b8cac2d411a091547cf563997984dc48c503

commit 2002b8cac2d411a091547cf563997984dc48c503
Author: Nick Vaccaro <nvaccaro@chromium.org>
Date: Fri May 19 23:19:39 2017

CHROMIUM: mfd: cros-ec: bring in EC command definitions

We are adding support for new sensor api, so we need to bring in new
EC command definitions. To do that we are fetching ec_command.h at
<c5332f6fe7d4d5197ac2154319f5e7dd4436d62a> from the EC repository,
which contains canonical version of the file.

The new alignment changes brought in are not meant to change the
existing layout, but rather document it/make it explicit.

BUG= chromium:713814 
TEST=Built/boot on caroline

Change-Id: I2161aa2c444d13420029515188e1dd82bdd1c52c
Signed-off-by: Nick Vaccaro <nvaccaro@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/484746
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/2002b8cac2d411a091547cf563997984dc48c503/include/linux/mfd/cros_ec_commands.h

Status: Fixed (was: Started)

Sign in to add a comment