testScreenTapsRegisteredOnCardboard is flaky |
|||||||
Issue descriptionsee https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/11381 https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/11378 https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/11385 https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/11447 etc. I will disable the test, please fix.
,
Apr 20 2017
+jbudorick for the full logcat output. I don't know what can be done for overheating, if this is the problem, but more tests should fail then, not only this.
,
Apr 20 2017
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c08bad5ead7880b11d93e2305c3465eecfcfcfa4 commit c08bad5ead7880b11d93e2305c3465eecfcfcfa4 Author: sgurun <sgurun@chromium.org> Date: Thu Apr 20 18:15:46 2017 Disable flaky test testScreenTapsNotRegisteredOnDaydream seems to be flaky. disabling. BUG= 713781 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2832883002 Cr-Commit-Position: refs/heads/master@{#466075} [modify] https://crrev.com/c08bad5ead7880b11d93e2305c3465eecfcfcfa4/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
Apr 21 2017
Hmm, I think the wrong test is disabled (testScreenTapsNotRegisteredOnDaydream is disabled). Added this CL to change the disabled to testScreenTapsRegisteredOnCardboard https://codereview.chromium.org/2837473004
,
Apr 21 2017
You're correct - I noticed this earlier today and put this up https://codereview.chromium.org/2837583003/, but it didn't let me submit without an lgtm even though I had a TBR line, so I've been waiting on a reviewer.
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1a0b50e87e51f736677ee5256e0b4d223fb804d commit f1a0b50e87e51f736677ee5256e0b4d223fb804d Author: yolandyan <yolandyan@chromium.org> Date: Fri Apr 21 21:19:49 2017 Disable flaky testScreenTapsRegisteredOnCardboard test BUG= 713781 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2837473004 Cr-Commit-Position: refs/heads/master@{#466447} [modify] https://crrev.com/f1a0b50e87e51f736677ee5256e0b4d223fb804d/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
Apr 24 2017
(your friendly sheriff here) More tests are failing in the same file; I'm assuming it's a related problem. I'm disabling those tests as well.
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87896d5cfa6c1889b3ab66df1f302518c603016a commit 87896d5cfa6c1889b3ab66df1f302518c603016a Author: mattcary <mattcary@chromium.org> Date: Mon Apr 24 08:45:41 2017 Disable flaky WebVrTests to fix broken M and L android builds. TBR=tedchoc@chromium.org BUG= 713781 Review-Url: https://codereview.chromium.org/2841523002 Cr-Commit-Position: refs/heads/master@{#466598} [modify] https://crrev.com/87896d5cfa6c1889b3ab66df1f302518c603016a/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
Apr 24 2017
I don't think these test failures were flakes, it looks like chrome is crashing in Canvas-related blink code when loading test_requestPresent_enters_vr.html
,
Apr 24 2017
For whatever reason, pages with Canvases aren't loading properly - since it's happening consistently, wasn't an issue before, and is being caused by loadUrl timing out instead of some assert/timeout in the actual test code, it looks like some Canvas-related bug was introduced that this caught.
,
Apr 24 2017
The failures seem to have been caused by https://codereview.chromium.org/2831733003 - now that it's reverted, the failing tests pass. I've put up https://codereview.chromium.org/2837033002 to re-add them.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8fdd880c98f3a9edc67a301cd6b92e1ff87afa6 commit f8fdd880c98f3a9edc67a301cd6b92e1ff87afa6 Author: bsheedy <bsheedy@chromium.org> Date: Tue Apr 25 19:12:54 2017 Revert 2841523002 Reverts 2841523002 which disabled 7 WebVR tests that were failing due to 2831733003. BUG= 713781 Review-Url: https://codereview.chromium.org/2837033002 Cr-Commit-Position: refs/heads/master@{#467068} [modify] https://crrev.com/f8fdd880c98f3a9edc67a301cd6b92e1ff87afa6/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java [modify] https://crrev.com/f8fdd880c98f3a9edc67a301cd6b92e1ff87afa6/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java [modify] https://crrev.com/f8fdd880c98f3a9edc67a301cd6b92e1ff87afa6/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
May 1 2017
So I've been running the VR tests on identically provisioned swarming devices, and even on one of the devices that the test in question has failed on multiple times (thanks to bpastene@ for setting that up for me). After over 500 attempts I haven't been able to reproduce the issue once, so I'm at a loss as to why the tests are failing. We'd like to add the test back in - since the test only seems to be flaky on Lollipop, is it alright if we re-enable the test and disable it on L devices?
,
May 1 2017
Why not enable it on all and see if the flakiness repeat? if you see more flakiness, maybe you can investigate once again.
,
May 1 2017
SGTM, I'll see how re-enabling it for everything works out.
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cce1f4f3b02e3a65efb572ffdc292724a7ca50b5 commit cce1f4f3b02e3a65efb572ffdc292724a7ca50b5 Author: bsheedy <bsheedy@chromium.org> Date: Tue May 02 22:23:32 2017 Re-enable flaky WebVR test Re-enables WebVrTest#testScreenTapsRegisteredOnCardboard, which was flaky on L devices. Was unable to reproduce on devices that it had previously failed on, so re-enabled on all devices at sgurun@'s suggestion. If flakiness occurs again, will disable test on L devices. BUG= 713781 Review-Url: https://codereview.chromium.org/2850183003 Cr-Commit-Position: refs/heads/master@{#468792} [modify] https://crrev.com/cce1f4f3b02e3a65efb572ffdc292724a7ca50b5/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
May 4 2017
Still flaky on L, patch to disable only on L will be out shortly.
,
May 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2961d5c4106bbc849631b956dcfb62a2c27db378 commit 2961d5c4106bbc849631b956dcfb62a2c27db378 Author: bsheedy <bsheedy@chromium.org> Date: Thu May 04 18:17:20 2017 Disable flaky test on L Re-disables WebVrTest#testScreenTapsRegisteredOnCardboard, but only on L instead of of everything. TBR=dtrainor@chromium.org BUG= 713781 Review-Url: https://codereview.chromium.org/2855123006 Cr-Commit-Position: refs/heads/master@{#469384} [modify] https://crrev.com/2961d5c4106bbc849631b956dcfb62a2c27db378/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37c0b451704be2e21c996595185d5bb520d3cf60 commit 37c0b451704be2e21c996595185d5bb520d3cf60 Author: bsheedy <bsheedy@chromium.org> Date: Mon May 08 17:20:31 2017 Disable additional flaky test on L Disables a recently added test on L for flakiness. This is the same flakiness that got WebVrTest#testScreenTapsRegisteredOnCardboard disabled, where the input injection is timing out. TBR=dtrainor@chromium.org BUG= 713781 Review-Url: https://codereview.chromium.org/2870673002 Cr-Commit-Position: refs/heads/master@{#470028} [modify] https://crrev.com/37c0b451704be2e21c996595185d5bb520d3cf60/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
May 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bba10421481938ea3b8680fb68e786489a1a5438 commit bba10421481938ea3b8680fb68e786489a1a5438 Author: bsheedy <bsheedy@chromium.org> Date: Tue May 30 17:13:00 2017 Re-enable disabled WebVR tests Re-enables WebVrTest#testScreenTapsRegisteredOnCardboard and WebVrTest#testPresentationLocksFocus which were disabled for flakiness on L. Exact cause of the flakiness has not been found/fixed, but it happens infrequently enough that the @RetryOnFailure annotation should prevent the flakiness from causing issues. Bug: 713781 Change-Id: I6c19dc0855e8d4265b6e642e061b847a171d46fb Reviewed-on: https://chromium-review.googlesource.com/516842 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#475573} [modify] https://crrev.com/bba10421481938ea3b8680fb68e786489a1a5438/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
May 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ef93591fbfdcf290e197205fa69e9f3f5d66548 commit 8ef93591fbfdcf290e197205fa69e9f3f5d66548 Author: bsheedy <bsheedy@chromium.org> Date: Wed May 31 21:28:21 2017 Re-disable flaky test on L Re-disables WebVrTest#testScreenTapsRegisteredOnCardboard on L devices. While the test is being retried like expected, the root cause of the flakiness does not seem to be resolved with test retries, as the test still fails with two additional retry runs. Does not re-disable WebVrTest#testPresentationLocksFocus, as its original flakiness seems to have been caused by an unrelated race condition that has now been fixed. Bug: 713781 Change-Id: I7e91f3556a7937ed3f5ed94bc1ce7b8606959983 Reviewed-on: https://chromium-review.googlesource.com/519722 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#476030} [modify] https://crrev.com/8ef93591fbfdcf290e197205fa69e9f3f5d66548/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java
,
Jun 6 2017
,
Aug 11 2017
,
Jan 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/244e8727716f8f33f2723c33080ede1109255937 commit 244e8727716f8f33f2723c33080ede1109255937 Author: bsheedy <bsheedy@chromium.org> Date: Wed Jan 31 19:56:35 2018 Re-enable VR test on L Re-enables WebVrInputTest#testScreenTapsRegisteredOnCardboard, which has been disabled on L for quite a while due to some really strange flakiness caused by Android refusing to handle input events properly. A very similar issue was fixed in crbug.com/787056 , so we'll see if that also fixed the flakiness here. Bug: 713781 Change-Id: I5ccfd53bc25f58929ce1b6a84c04684a3127e009 Reviewed-on: https://chromium-review.googlesource.com/894677 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533368} [modify] https://crrev.com/244e8727716f8f33f2723c33080ede1109255937/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrInputTest.java
,
Feb 7 2018
Haven't seen any failures since re-enabling, so I'm going to say that this is finally fixed.
,
Feb 8 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bsheedy@chromium.org
, Apr 20 2017