Render text with Skia for WebVR warnings |
|||||||||||
Issue description
,
Apr 21 2017
,
Apr 21 2017
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/423d7c1b4001927a1a6f6180aa0f3eebe72348e4 commit 423d7c1b4001927a1a6f6180aa0f3eebe72348e4 Author: acondor <acondor@google.com> Date: Fri Apr 21 22:37:48 2017 When presenting WebVR on insecure sites, a warning needs to be presented to the user. This change renders these messages on textures to be added to a GL scene. - Text is rendered with gfx::Canvas and gfx::RenderText, previously disabled for android. - Fallback fonts were handled with Skia's font manager. - The text is measured before rendering in order to layout properly, reducing empty space. - The icons are positioned on the right on RTL languages. BUG= 713779 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2817663003 Cr-Commit-Position: refs/heads/master@{#466472} [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.h [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/ui_texture.cc [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/ui_texture.h [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/vr_shell.cc [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/device/vr/BUILD.gn [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/BUILD.gn [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/DEPS [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/font_render_params.h [modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/font_render_params_android.cc
,
Apr 24 2017
,
Apr 24 2017
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
Please tag with applicable OSs. Thanks.
,
Apr 24 2017
Only affects Android.
,
Apr 24 2017
,
Apr 28 2017
No longer merging back to M59.
,
Apr 28 2017
,
Apr 28 2017
,
Jul 4
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by acondor@google.com
, Apr 20 2017