New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713779 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR

Blocking:
issue 710150
issue 713938



Sign in to add a comment

Render text with Skia for WebVR warnings

Project Member Reported by acondor@google.com, Apr 20 2017

Issue description

Comment 1 by acondor@google.com, Apr 20 2017

Blocking: 710150
Components: Blink>WebVR
Labels: -Pri-3 Proj-VR Pri-1
Labels: M-59
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/423d7c1b4001927a1a6f6180aa0f3eebe72348e4

commit 423d7c1b4001927a1a6f6180aa0f3eebe72348e4
Author: acondor <acondor@google.com>
Date: Fri Apr 21 22:37:48 2017

When presenting WebVR on insecure sites, a warning needs to be presented to the user. This change renders these messages on textures to be added to a GL scene.

- Text is rendered with gfx::Canvas and gfx::RenderText, previously disabled for android.
- Fallback fonts were handled with Skia's font manager.
- The text is measured before rendering in order to layout properly, reducing empty space.
- The icons are positioned on the right on RTL languages.

BUG= 713779 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2817663003
Cr-Commit-Position: refs/heads/master@{#466472}

[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.cc
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/insecure_content_permanent_texture.h
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/insecure_content_transient_texture.cc
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/ui_texture.cc
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/textures/ui_texture.h
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/device/vr/BUILD.gn
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/BUILD.gn
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/DEPS
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/font_render_params.h
[modify] https://crrev.com/423d7c1b4001927a1a6f6180aa0f3eebe72348e4/ui/gfx/font_render_params_android.cc

Labels: Merge-Request-59
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 24 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Please tag with applicable OSs.  Thanks.
Labels: OS-Android
Only affects Android.
Blocking: 713938
Labels: -Hotlist-Merge-Review -Merge-Review-59
Status: Fixed (was: Untriaged)
No longer merging back to M59.
Labels: -M-59
Labels: M-60
Components: Blink>WebXR

Sign in to add a comment