SyncChrome fails intentionally on PFQ when Chrome is pinned but messaging is unclear |
||||
Issue descriptionWhen Chrome is pinned, the SyncChrome stage fails, even though it completes the sync. The reason for this is so that the PFQ will not automatically uprev while Chrome is pinned (e.g. because of a known issue in Chrome that may not have been caught by the PFQ). The messaging is extremely unclear. From: https://luci-milo.appspot.com/buildbot/chromeos/x86-generic-chromium-pfq/9976 STEP_LINK: Chromium revisions; http://omahaproxy.appspot.com/changelog?old_version=59.0.3064.0&new_version=60.0.3076.0 03:22:13: INFO: Committing changes with commit message: Marking latest_release for chromeos-chrome ebuild with version 60.0.3076.0 as stable. 03:22:13: INFO: Cleaning up stale packages ['chromeos-base/chromeos-chrome-60.0.3076.0_rc-r1']. STEP_LINK: Chromium revisions; http://omahaproxy.appspot.com/changelog?old_version=59.0.3064.0&new_version=60.0.3076.0 03:22:14: INFO: Committing changes with commit message: Marking latest_release for chromium-source ebuild with version 60.0.3076.0 as stable. 03:22:14: INFO: Cleaning up stale packages ['chromeos-base/chromium-source-60.0.3076.0_rc-r1']. 03:22:15: INFO: RunCommand: cros_sdk -- emerge-x86-generic -p --quiet '=chromeos-base/chromeos-chrome-60.0.3076.0_rc-r1' 03:22:23: ERROR: Cannot emerge-x86-generic =chromeos-base/chromeos-chrome-60.0.3076.0_rc-r1 Is Chrome pinned to an older version? @@@STEP_FAILURE@@@ 03:22:23: ERROR: Chrome is pinned. Attempting to continue build for chrome atom chromeos-base/chromeos-chrome-60.0.3076.0_rc-r1 anyway but build will ultimately fail. 03:22:23: INFO: Deleting pin file at /b/cbuild/repository/src/third_party/chromiumos-overlay/profiles/default/linux/package.mask/chromepin and proceeding.
,
Apr 20 2017
See issue 527957 for the reasoning / original CLs.
,
Apr 20 2017
"build will ultimately fail" suggests that building Chrome will fail since this is in the SyncChrome stage. The code comment is more clear FWIW :) I'm thinking: "Chrome is pinned. Build will continue but this stage will be marked as failed to prevent an uprev."
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e3aa0c71610c3d00ac5107826f12cd3332a04314 commit e3aa0c71610c3d00ac5107826f12cd3332a04314 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Apr 27 22:02:22 2017 SyncChrome/UprevAndroid: Clarify pinned message Current message is unclear and confusing since the stage completes despite the error. BUG= chromium:713773 TEST=none (string change only) Change-Id: I680874f59bf7bdf05e48199fed2b42ebda23fda4 Reviewed-on: https://chromium-review.googlesource.com/483044 Commit-Ready: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/e3aa0c71610c3d00ac5107826f12cd3332a04314/cbuildbot/stages/android_stages.py [modify] https://crrev.com/e3aa0c71610c3d00ac5107826f12cd3332a04314/cbuildbot/stages/chrome_stages.py
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/e3aa0c71610c3d00ac5107826f12cd3332a04314 commit e3aa0c71610c3d00ac5107826f12cd3332a04314 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Apr 27 22:02:22 2017 SyncChrome/UprevAndroid: Clarify pinned message Current message is unclear and confusing since the stage completes despite the error. BUG= chromium:713773 TEST=none (string change only) Change-Id: I680874f59bf7bdf05e48199fed2b42ebda23fda4 Reviewed-on: https://chromium-review.googlesource.com/483044 Commit-Ready: Steven Bennetts <stevenjb@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/e3aa0c71610c3d00ac5107826f12cd3332a04314/cbuildbot/stages/android_stages.py [modify] https://crrev.com/e3aa0c71610c3d00ac5107826f12cd3332a04314/cbuildbot/stages/chrome_stages.py
,
Apr 27 2017
Changing the summary to reflect that we're only changing the messaging.
,
Aug 1 2017
,
Jan 22 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by akes...@chromium.org
, Apr 20 2017