#4 is the hard part. I'll make sure #1-#3 are done, but I don't even know whether #4 will work. Can we split WV metrics by app, by any chance?

we cannot get app specific metrics.

4. is possible as we are going to provide a callback for apps to show their UI. 

ah boo. maybe in the future we can explore using UKM for getting app specific metrics? but i am not sure whether that would fit the policy.

well, still better than nothing :)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32bbd06a56b6048f101bcbe0e1d4763cc8718c54

commit 32bbd06a56b6048f101bcbe0e1d4763cc8718c54
Author: Nate Fischer <ntfschr@chromium.org>
Date: Tue Nov 21 03:27:50 2017

AW: UMA metrics for Quiet vs Loud interstitials

This CL adds UMA metrics to track how often we see particular
interstitial types. Currently these are for QUIET_GIANT, QUIET_SMALL,
and LOUD.

This adds the metric for WebView only, since Chrome currently only uses
loud interstitials.

Bug:  713724 
Test: check that metrics are logged under chrome://histograms/SafeBrowsing
Change-Id: I36af496078bf5a502a76b2cbdf481acf30a208bc
Reviewed-on: https://chromium-review.googlesource.com/777945
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518081}
[modify] https://crrev.com/32bbd06a56b6048f101bcbe0e1d4763cc8718c54/android_webview/browser/aw_safe_browsing_blocking_page.cc
[modify] https://crrev.com/32bbd06a56b6048f101bcbe0e1d4763cc8718c54/android_webview/browser/aw_safe_browsing_blocking_page.h
[modify] https://crrev.com/32bbd06a56b6048f101bcbe0e1d4763cc8718c54/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/32bbd06a56b6048f101bcbe0e1d4763cc8718c54/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cb724958606a901fe92e1b434b3e1099910ad78

commit 9cb724958606a901fe92e1b434b3e1099910ad78
Author: Nate Fischer <ntfschr@chromium.org>
Date: Tue Nov 21 04:02:36 2017

AW: UMA metrics for CanShowInterstitial

This CL adds UMA metrics to track how often we show interstitials vs.
immediately create a network error (because we believe the WebView to be
not visible).

Bug:  713724 
Test: check metrics are logged under chrome://histograms/SafeBrowsing
Change-Id: I5882491289de69d49e2f011de58c134c52af2ae3
Reviewed-on: https://chromium-review.googlesource.com/780360
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518101}
[modify] https://crrev.com/9cb724958606a901fe92e1b434b3e1099910ad78/android_webview/browser/aw_safe_browsing_ui_manager.cc
[modify] https://crrev.com/9cb724958606a901fe92e1b434b3e1099910ad78/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fd98c9e833e4af00a899ea68ae30e466477c6cf

commit 4fd98c9e833e4af00a899ea68ae30e466477c6cf
Author: Nate Fischer <ntfschr@chromium.org>
Date: Fri Feb 23 03:17:10 2018

AW: UMA metric for Safe Browsing manifest opt-in

No change to logic, this just adds UMA metrics.

This adds the "SafeBrowsing.WebView.AppOptIn" metric, which tracks
application opt-in preference for Safe Browsing. Most applications will
be in the "no opt-in prefernce" category, but it may be useful to see if
there's a change in "opt-out" or "opt-in" numbers, especially as we
begin to enable Safe Browsing by default.

This won't give us per-application metrics, but this should still
indicate (1) if a popular app(s) explicitly opts out of Safe Browsing,
and (2) a rough idea of how often users are protected by WebView Safe
Browsing (although this doesn't account for user opt-in preference).

Bug:  713724 
Test: check that metric is logged under chrome://histograms/SafeBrowsing
Change-Id: I2fa01a7938eabd61aeacbb31f09e7729115254d3
Reviewed-on: https://chromium-review.googlesource.com/933290
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538684}
[modify] https://crrev.com/4fd98c9e833e4af00a899ea68ae30e466477c6cf/android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java
[modify] https://crrev.com/4fd98c9e833e4af00a899ea68ae30e466477c6cf/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/4fd98c9e833e4af00a899ea68ae30e466477c6cf/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cc567ff658af8af479d28a7b8299a4f0c858995

commit 5cc567ff658af8af479d28a7b8299a4f0c858995
Author: Nate Fischer <ntfschr@chromium.org>
Date: Sat Feb 24 03:17:37 2018

AW: UMA metric for Safe Browsing user opt-in

No change to logic, this just adds UMA metrics.

Following up to http://crrev/c/933290, this is to log user opt-in
preference. This adds "SafeBrowsing.WebView.UserOptIn" to track
potential spikes/changes in user opt-outs.

Bug:  713724 
Test: check that metric is logged under chrome://histograms/SafeBrowsing
Change-Id: Ieb32dc07d930705e5348fbe66d03b267b5562d7b
Reviewed-on: https://chromium-review.googlesource.com/935483
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538976}
[modify] https://crrev.com/5cc567ff658af8af479d28a7b8299a4f0c858995/android_webview/java/src/org/chromium/android_webview/AwSafeBrowsingConfigHelper.java
[modify] https://crrev.com/5cc567ff658af8af479d28a7b8299a4f0c858995/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/5cc567ff658af8af479d28a7b8299a4f0c858995/tools/metrics/histograms/histograms.xml

No manual verification necessary.

Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.