Presubmit incorrectly accepts CL without property LGTM |
|||||
Issue descriptionCQ incorrectly accepts https://codereview.chromium.org/2799303003. This CL did not have the ownership LGTM for //third_party, yet it got checked in (though later reverted).
,
Apr 25 2017
,
Apr 25 2017
Thanks for the explanation! However, https://codereview.chromium.org/2820583002/ could not get checked in until I TBR-ed third_party's owner. It is a reland of https://codereview.chromium.org/2799303003. Did something change during this period?
,
Apr 25 2017
No, nothing changed afaiu in this time. So, possible I didn't diagnose the problem properly. But I am pretty sure that current way of OWNERS handling is crappy :(
,
Apr 26 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2018
reviews & owners & TBRs is being worked on over in 688115 these days. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tandrii@chromium.org
, Apr 25 2017Status: Available (was: Untriaged)