New issue
Advanced search Search tips

Issue 713723 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner: ----
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Presubmit incorrectly accepts CL without property LGTM

Project Member Reported by zpeng@chromium.org, Apr 20 2017

Issue description

CQ incorrectly accepts https://codereview.chromium.org/2799303003. This CL did not have the ownership LGTM for //third_party, yet it got checked in (though later reverted).

 
Components: -Infra>CQ Infra>Client>Chrome Infra>SDK
Status: Available (was: Untriaged)
KI. The presubmit runs **after** patch is applied and it uses latest version of OWNERS. Hence, https://codereview.chromium.org/2799303003/diff/40001/third_party/checkstyle/OWNERS which added owners was effectively used to verify owners :(  
Labels: -OS-Android

Comment 3 by zpeng@chromium.org, Apr 25 2017

Cc: tandrii@chromium.org
Thanks for the explanation! However, https://codereview.chromium.org/2820583002/ could not get checked in until I TBR-ed third_party's owner. It is a reland of https://codereview.chromium.org/2799303003. Did something change during this period?
No, nothing changed afaiu in this time. So, possible I didn't diagnose the problem properly. But I am pretty sure that current way of OWNERS handling is crappy :( 
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 26 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 688115
Status: Duplicate (was: Untriaged)
reviews & owners & TBRs is being worked on over in 688115 these days.

Sign in to add a comment