Issue metadata
Sign in to add a comment
|
Security: Field validation bubbles can appear over the wrong tab
Reported by
chromium...@gmail.com,
Apr 20 2017
|
|||||||||||||||||||||||
Issue descriptionVERSION Chrome Version: Canary 60.0.3076.0 Operating System: Windows 7 REPRODUCTION CASE 1. Open testcase.html. 2. Click on the button and observe. From bug 673163 and bug 704560 .
,
Apr 20 2017
Issue 713477 has been merged into this issue.
,
Apr 20 2017
tkent: Can you please take a look?
,
Apr 21 2017
Oh, print()! interesting.
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dbd356b0cc52911caef089b09de63572cd9e39f commit 9dbd356b0cc52911caef089b09de63572cd9e39f Author: tkent <tkent@chromium.org> Date: Fri Apr 21 06:38:15 2017 window.print() should close form validation bubble. Usually, window.open() deactivates the origin window and validation bubble on the origin window is closed. However, if window.print() is executed, it suspends message loop of the window, and deactivation isn't noticed until print dialog is closed. So, we need to close validation popup explicitly for window.print(). BUG= 713686 Review-Url: https://codereview.chromium.org/2834783002 Cr-Commit-Position: refs/heads/master@{#466273} [modify] https://crrev.com/9dbd356b0cc52911caef089b09de63572cd9e39f/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/9dbd356b0cc52911caef089b09de63572cd9e39f/third_party/WebKit/Source/web/ChromeClientImpl.h [modify] https://crrev.com/9dbd356b0cc52911caef089b09de63572cd9e39f/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp [modify] https://crrev.com/9dbd356b0cc52911caef089b09de63572cd9e39f/third_party/WebKit/Source/web/ValidationMessageClientImpl.h
,
Apr 21 2017
,
Apr 21 2017
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 21 2017
,
Apr 21 2017
Verified on 60.0.3078.0. Thanks for the quick fix!
,
Apr 22 2017
,
Apr 23 2017
This affects 58 stable.
,
Apr 23 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2017
This bug requires manual review: We are only 1 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2017
+awhalley@ for M58 merge review. Please note M58 is already in Stable and bar is VERY high to take any merges in for future stable refresh if any.
,
Apr 23 2017
Please merge your change to M59 branch #3071 latest before 4:00 PM PT, Monday (04/24) so we can take it for next week last M59 dev release. Thank you.
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31455b249cf2737bf96ab751252b84e8c85b3804 commit 31455b249cf2737bf96ab751252b84e8c85b3804 Author: Kent Tamura <tkent@chromium.org> Date: Mon Apr 24 00:59:15 2017 Merge "window.print() should close form validation bubble." to M59 Usually, window.open() deactivates the origin window and validation bubble on the origin window is closed. However, if window.print() is executed, it suspends message loop of the window, and deactivation isn't noticed until print dialog is closed. So, we need to close validation popup explicitly for window.print(). BUG= 713686 Review-Url: https://codereview.chromium.org/2834783002 Cr-Commit-Position: refs/heads/master@{#466273} (cherry picked from commit 9dbd356b0cc52911caef089b09de63572cd9e39f) Review-Url: https://codereview.chromium.org/2833303002 . Cr-Commit-Position: refs/branch-heads/3071@{#151} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/31455b249cf2737bf96ab751252b84e8c85b3804/third_party/WebKit/Source/web/ChromeClientImpl.cpp [modify] https://crrev.com/31455b249cf2737bf96ab751252b84e8c85b3804/third_party/WebKit/Source/web/ChromeClientImpl.h [modify] https://crrev.com/31455b249cf2737bf96ab751252b84e8c85b3804/third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp [modify] https://crrev.com/31455b249cf2737bf96ab751252b84e8c85b3804/third_party/WebKit/Source/web/ValidationMessageClientImpl.h
,
Apr 24 2017
,
Apr 24 2017
No need to rush this into a 58 stable update.
,
Apr 24 2017
Applying "Merge-Rejected-58" label per comment #20.
,
Apr 24 2017
,
Apr 28 2017
,
Apr 28 2017
The panel decided to award $500 for this bug. Thanks as ever!
,
Apr 28 2017
,
May 3 2017
,
May 3 2017
,
May 25 2017
,
May 30 2017
,
Jul 31 2017
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
|
||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Apr 20 2017Status: Untriaged (was: Unconfirmed)