New issue
Advanced search Search tips

Issue 713685 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 713914



Sign in to add a comment

Layout Test fast/workers/termination-early.html is flaky

Project Member Reported by nhiroki@chromium.org, Apr 20 2017

Issue description

The following layout tests are flaky on WebKit Linux Trusty Leak

 - fast/workers/termination-early.html
 - virtual/sharedarraybuffer/fast/workers/termination-early.html
 
This failure started after my per-global-scope-scheduler patch was landed:
https://codereview.chromium.org/2832763002/

Crash-log is not helpful:

<crash-log>
crash log for renderer (pid <unknown>):
STDOUT: This test terminates a worker at the moment before WorkerThread::workerThread starts execute the initial script. This stage includes initialization of the script engine, and V8 may crash if terminated during initialization. Test succeeds if it does not hang or crash (if worker thread is running in the separate process, that process could hang or crash).
STDOUT: 
STDOUT: This test reproduces crash specific to v8 and multi-process Chromium architecture. In case of JSC, the test is just another opportunity to exercise the Worker code.
STDOUT: 
STDOUT: DONE
STDERR: <empty>
</crash-log>
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4489ad191e999cd9537515b1abd5b1d3778cccb8

commit 4489ad191e999cd9537515b1abd5b1d3778cccb8
Author: nhiroki <nhiroki@chromium.org>
Date: Thu Apr 20 13:21:30 2017

Worker: Mark fast/workers/termination-early.html with Crash/Pass

BUG= 713685 
TBR=nhiroki@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2832723003
Cr-Commit-Position: refs/heads/master@{#465989}

[modify] https://crrev.com/4489ad191e999cd9537515b1abd5b1d3778cccb8/third_party/WebKit/LayoutTests/TestExpectations

Blockedon: 713914
Project Member

Comment 4 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb6d3be1ab6a20735406528fecb19ec718ae110

commit 2fb6d3be1ab6a20735406528fecb19ec718ae110
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 02:09:01 2017

Remove flaky expectations for tests that no longer appear flaky.

Again, done with update-test-expectations.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual/gpu/fast/canvas/painting-on-bad-canvas.html,fast/events/message-port-start-and-close-different-microtask.html,virtual/mojo-loading/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html,virtual/threaded/animations/display-inline-style-adjust.html,fast/selectors/007a.html,http/tests/workers/terminate-during-sync-operation-file.html,virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html,virtual/threaded/inspector/tracing/decode-resize.html,external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html,external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html,external/wpt/service-workers/service-worker/fetch-csp.https.html,external/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html,external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html,external/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html,external/wpt/service-workers/service-worker/fetch-response-xhr.https.html,external/wpt/service-workers/service-worker/getregistrations.https.html,http/tests/security/link-crossorigin-preload-no-cors.html,virtual/mojo-loading/http/tests/inspector/tracing/timeline-script-parse.html,tables/mozilla/bugs/bug113424.html,fast/backgrounds/background-image-relative-url-in-iframe.html,crypto/subtle/worker-subtle-crypto-concurrent.html,fast/workers/termination-early.html,fast/dnd/dropEffect-for-effectAllowed.html

BUG= 404597 , 520174 , 520194 , 596752 , 619539 , 619539 , 638693 , 658997 ,664839, 678489 , 708934 , 713050 ,713419, 713509 , 713685 , 719298 

Review-Url: https://codereview.chromium.org/2884793002
Cr-Commit-Position: refs/heads/master@{#471981}

[modify] https://crrev.com/2fb6d3be1ab6a20735406528fecb19ec718ae110/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by falken@chromium.org, May 16 2017

Status: Fixed (was: Assigned)
Seems fixed with  issue 713914 .

Sign in to add a comment