New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713683 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make the constructor of TaskTraits constexpr.

Project Member Reported by fdoray@chromium.org, Apr 20 2017

Issue description

The goal is to have a constexpr constructor that takes traits as arguments in any order. E.g.

constexpr TaskTraits default_traits;
constexpr TaskTraits user_visible_traits = {TaskPriority::USER_VISIBLE};
constexpr TaskTraits user_visible_may_block_traits = {TaskPriority::USER_VISIBLE, MayBlock()};
constexpr TaskTraits other_user_visible_may_block_traits = {MayBlock(), TaskPriority::USER_VISIBLE};

This will reduce binary and code size compared to the current builder pattern.
 

Comment 1 by gab@chromium.org, Apr 20 2017

Cc: ajwong@chromium.org
+Albert FYI, Francois decided to poke at this with the recent chatter around constexpr traits. Agreed that it'd make for a much nicer API (less wordy AND less code gen :))

Preview @ https://codereview.chromium.org/2829083002/
While less wordy, it's not clear to me if this is actually easier to use.

It's not clear from the initialization list that items should be mutually included e.g. allowing for {TaskPriority::USER_VISIBLE, TaskPriority::USER_BLOCKING}. 

With the With* style, it's obvious to see that you're only allowed to specify one mode. Would it be possible to make With* return a constexpr instead?
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02cf16644800b5c644a6067e7077882fefcaf7f1

commit 02cf16644800b5c644a6067e7077882fefcaf7f1
Author: fdoray <fdoray@chromium.org>
Date: Tue Apr 25 22:49:34 2017

Do not inherit TaskPriority in TaskTraits.

In order to make the TaskTraits constructor constexpr, do not
call GetTaskPriorityForCurrentThread() from it. Instead, keep
track of whether the TaskPriority was set explicitly. When the
TaskTraits are actually used, substitute the TaskPriority with
the return value of GetTaskPriorityForCurrentThread() if it
wasn't set explicitly.

BUG= 713683 

Review-Url: https://codereview.chromium.org/2831883003
Cr-Commit-Position: refs/heads/master@{#467152}

[modify] https://crrev.com/02cf16644800b5c644a6067e7077882fefcaf7f1/base/BUILD.gn
[modify] https://crrev.com/02cf16644800b5c644a6067e7077882fefcaf7f1/base/task_scheduler/post_task.cc
[modify] https://crrev.com/02cf16644800b5c644a6067e7077882fefcaf7f1/base/task_scheduler/task_traits.cc
[modify] https://crrev.com/02cf16644800b5c644a6067e7077882fefcaf7f1/base/task_scheduler/task_traits.h
[delete] https://crrev.com/7dacd22215a5c3a7670fde93d2b99188131809a4/base/task_scheduler/task_traits_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/879b2fcdbf4efc613abf3ab094ca11d53e74498c

commit 879b2fcdbf4efc613abf3ab094ca11d53e74498c
Author: fdoray <fdoray@chromium.org>
Date: Mon May 01 21:34:11 2017

Add constexpr TaskTraits constructor.

The new constructor accepts any number of TaskTraits in any order.

E.g.
constexpr TaskTraits default_traits;
constexpr TaskTraits user_visible_traits = {TaskPriority::USER_VISIBLE};
constexpr TaskTraits user_visible_may_block_traits = {
    TaskPriority::USER_VISIBLE, MayBlock()};
constexpr TaskTraits other_user_visible_may_block_traits = {
    MayBlock(), TaskPriority::USER_VISIBLE};

BUG= 713683 

Review-Url: https://codereview.chromium.org/2829083002
Cr-Commit-Position: refs/heads/master@{#468417}

[modify] https://crrev.com/879b2fcdbf4efc613abf3ab094ca11d53e74498c/base/BUILD.gn
[modify] https://crrev.com/879b2fcdbf4efc613abf3ab094ca11d53e74498c/base/task_scheduler/task_traits.cc
[modify] https://crrev.com/879b2fcdbf4efc613abf3ab094ca11d53e74498c/base/task_scheduler/task_traits.h
[add] https://crrev.com/879b2fcdbf4efc613abf3ab094ca11d53e74498c/base/task_scheduler/task_traits_details.h
[add] https://crrev.com/879b2fcdbf4efc613abf3ab094ca11d53e74498c/base/task_scheduler/task_traits_unittest.cc
[add] https://crrev.com/879b2fcdbf4efc613abf3ab094ca11d53e74498c/base/task_scheduler/task_traits_unittest.nc

Project Member

Comment 5 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53ccd976b39d1f456269dce73444551a1feeddc7

commit 53ccd976b39d1f456269dce73444551a1feeddc7
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 20:48:16 2017

Use constexpr TaskTraits constructor in ios.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in ios.

BUG= 713683 
R=gab@chromium.org
TBR=eugenebut@chromium.org

Review-Url: https://codereview.chromium.org/2861583006
Cr-Commit-Position: refs/heads/master@{#469111}

[modify] https://crrev.com/53ccd976b39d1f456269dce73444551a1feeddc7/ios/web/net/crw_cert_verification_controller.mm

Project Member

Comment 6 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaaac9264a92ecd849a00b5eec536af36a305afe

commit eaaac9264a92ecd849a00b5eec536af36a305afe
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 20:49:10 2017

Use constexpr TaskTraits constructor in chromecast.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in chromecast.

BUG= 713683 
R=gab@chromium.org
TBR=alokp@chromium.org

Review-Url: https://codereview.chromium.org/2858993002
Cr-Commit-Position: refs/heads/master@{#469112}

[modify] https://crrev.com/eaaac9264a92ecd849a00b5eec536af36a305afe/chromecast/browser/url_request_context_factory.cc

Project Member

Comment 7 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/054e8f0ade030ca9d679cdfafaacd6d2f2e97617

commit 054e8f0ade030ca9d679cdfafaacd6d2f2e97617
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 20:58:23 2017

Use constexpr TaskTraits constructor in android_webview.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in android_webview.

BUG= 713683 
R=gab@chromium.org
TBR=tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2856203005
Cr-Commit-Position: refs/heads/master@{#469114}

[modify] https://crrev.com/054e8f0ade030ca9d679cdfafaacd6d2f2e97617/android_webview/browser/net/aw_url_request_context_getter.cc

Project Member

Comment 8 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2a6f71677b02832b9dec1b94ce8abc43cd696df

commit f2a6f71677b02832b9dec1b94ce8abc43cd696df
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 21:14:40 2017

Use constexpr TaskTraits constructor in chromeos.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in chromeos.

BUG= 713683 
R=gab@chromium.org
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2854953005
Cr-Commit-Position: refs/heads/master@{#469126}

[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/cert_loader.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/dbus/debug_daemon_client.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/dbus/fake_cros_disks_client.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/dbus/fake_permission_broker_client.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/dbus/lorgnette_manager_client.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/network/client_cert_resolver.cc
[modify] https://crrev.com/f2a6f71677b02832b9dec1b94ce8abc43cd696df/chromeos/settings/timezone_settings.cc

Project Member

Comment 9 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ad1493ab09d85efdea49bbfb098e4c60856ee69

commit 4ad1493ab09d85efdea49bbfb098e4c60856ee69
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 21:21:11 2017

Use constexpr TaskTraits constructor in chrome.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in chrome.

BUG= 713683 
R=gab@chromium.org
TBR=sky@chromium.org, stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Review-Url: https://codereview.chromium.org/2858073002
Cr-Commit-Position: refs/heads/master@{#469129}

[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/android/offline_pages/offline_page_model_factory.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/android/offline_pages/request_coordinator_factory.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/android/thumbnail/thumbnail_cache.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/android/webapk/webapk_installer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/browsing_data/site_data_size_collector.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/budget_service/budget_database.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/captive_portal/captive_portal_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chrome_browser_main_android.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chrome_browser_main_linux.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/app_mode/kiosk_app_data_base.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/app_mode/startup_app_launcher.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/arc/downloads_watcher/arc_downloads_watcher_service.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/base/file_flusher.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/base/locale_util.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/boot_times_recorder.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/camera_detector.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/customization/customization_document.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/drive/download_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/drive/fileapi/fileapi_worker.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/drive/write_on_cache_file.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/extensions/default_app_order.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/extensions/file_manager/private_api_mount.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/extensions/install_limiter.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/external_metrics.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/file_manager/open_with_browser.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/file_manager/snapshot_manager.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/file_manager/zip_file_creator.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/first_run/goodies_displayer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/hats/hats_dialog.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/input_method/input_method_syncer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/login/wizard_controller.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/platform_keys/platform_keys.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/platform_keys/platform_keys_nss.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/policy/dm_token_storage.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/policy/remote_commands/device_commands_factory_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/policy/system_log_uploader.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/power/cpu_data_collector.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/settings/session_manager_operation.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/system/automatic_reboot_manager.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/system_logs/command_line_log_source.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/system_logs/debug_log_writer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/system_logs/touch_log_source_ozone.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/chromeos/system_logs/touch_log_source_x11.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/component_updater/ev_whitelist_component_installer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/component_updater/recovery_component_installer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/conflicts/module_inspector_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/dom_distiller/dom_distiller_service_factory.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/downgrade/user_data_downgrade.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/download/download_target_determiner.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/management/management_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/messaging/native_message_process_host.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/messaging/native_process_launcher.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/networking_cast_private/chrome_networking_cast_private_delegate.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/chrome_url_request_util.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/extension_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/extension_disabled_ui_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/extensions/updater/extension_cache_impl.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/favicon/large_icon_service_factory.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/feature_engagement_tracker/feature_engagement_tracker_factory.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/feedback/feedback_profile_observer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/file_select_helper.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/google/google_brand_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/io_thread.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/mac/keystone_glue.mm
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/media_galleries/chromeos/mtp_device_delegate_impl_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/memory_details.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/metrics/google_update_metrics_provider_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/net/dns_probe_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/net/file_downloader.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/net/load_timing_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/notifications/notification_platform_bridge_linux.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ntp_snippets/content_suggestions_service_factory.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/password_manager/password_manager_util_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/pepper_flash_settings_manager.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/platform_util.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/policy/cloud/test_request_interceptor.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/prefs/incognito_mode_prefs.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/renderer_host/chrome_extension_message_filter.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/renderer_host/pepper/device_id_fetcher.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/safe_browsing/chrome_cleaner/srt_fetcher_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/safe_browsing/chrome_cleaner/srt_global_error_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/search/local_files_ntp_source.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/search/suggestions/suggestions_service_factory.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/service_process/service_process_control.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/supervised_user/experimental/supervised_user_blacklist.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/supervised_user/legacy/supervised_user_registration_utility.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/supervised_user/supervised_user_service.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/supervised_user/supervised_user_site_list.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/thumbnails/content_based_thumbnailing_algorithm.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/app_list/arc/arc_app_icon.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/app_list/arc/arc_default_app_list.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/libgtkui/app_indicator_icon.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/startup/startup_browser_creator.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/views/chrome_views_delegate_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/views/elevation_icon_setter.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/views/frame/taskbar_decorator_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/views/outdated_upgrade_bubble_view.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/about_ui.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/chromeos/image_source.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/extensions/extension_loader_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/help/help_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/nacl_ui.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/print_preview/print_preview_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/print_preview/printer_backend_proxy_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/ui/webui/version_handler_chromeos.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/web_applications/web_app_mac.mm
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/web_applications/web_app_win.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/win/enumerate_modules_model.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/browser/win/jumplist.cc
[modify] https://crrev.com/4ad1493ab09d85efdea49bbfb098e4c60856ee69/chrome/renderer/sandbox_status_extension_android.cc

Project Member

Comment 10 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f04e789081bebb181343c3cc9c0c95b9cc189841

commit f04e789081bebb181343c3cc9c0c95b9cc189841
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 21:22:44 2017

Use constexpr TaskTraits constructor in remoting.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in remoting.

BUG= 713683 
R=gab@chromium.org
TBR=zijiehe@chromium.org

Review-Url: https://codereview.chromium.org/2858083002
Cr-Commit-Position: refs/heads/master@{#469131}

[modify] https://crrev.com/f04e789081bebb181343c3cc9c0c95b9cc189841/remoting/protocol/webrtc_video_renderer_adapter.cc

Project Member

Comment 11 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61b89c802236da47eb1fc17fdc34c2c66f843d30

commit 61b89c802236da47eb1fc17fdc34c2c66f843d30
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 21:35:12 2017

Use constexpr TaskTraits constructor in components.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in components.

BUG= 713683 
R=gab@chromium.org
TBR=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2855223002
Cr-Commit-Position: refs/heads/master@{#469135}

[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/history/core/browser/history_service.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/leveldb/env_mojo.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/nacl/browser/nacl_browser.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/nacl/browser/nacl_file_host.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/nacl/browser/nacl_host_message_filter.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/nacl/browser/nacl_process_host.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/nacl/browser/pnacl_host.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/translate/core/browser/ranker_model_loader.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/wallpaper/wallpaper_manager_base.cc
[modify] https://crrev.com/61b89c802236da47eb1fc17fdc34c2c66f843d30/components/web_restrictions/browser/web_restrictions_client.cc

Project Member

Comment 12 by bugdroid1@chromium.org, May 3 2017

Project Member

Comment 13 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6baa90f9f21576ecd6f11980c81776af7ae0866

commit e6baa90f9f21576ecd6f11980c81776af7ae0866
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 22:09:30 2017

Use constexpr TaskTraits constructor in media.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in media.

BUG= 713683 
R=gab@chromium.org
TBR=hubbe@chromium.org

Review-Url: https://codereview.chromium.org/2860573009
Cr-Commit-Position: refs/heads/master@{#469159}

[modify] https://crrev.com/e6baa90f9f21576ecd6f11980c81776af7ae0866/media/filters/ffmpeg_demuxer.cc

Project Member

Comment 14 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0

commit f79f3091c4a335c5f7d77e7a6d935ee4048d58e0
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 22:20:51 2017

Use constexpr TaskTraits constructor in extensions.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in extensions.

BUG= 713683 
R=gab@chromium.org
TBR=benwells@chromium.org

Review-Url: https://codereview.chromium.org/2859933002
Cr-Commit-Position: refs/heads/master@{#469164}

[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/api/file_handlers/directory_util.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/api/file_handlers/mime_util.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/content_hash_fetcher.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/content_verify_job.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/extension_protocols.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/image_loader.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/updater/update_client_config.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/updater/update_data_provider.cc
[modify] https://crrev.com/f79f3091c4a335c5f7d77e7a6d935ee4048d58e0/extensions/browser/updater/update_install_shim.cc

Project Member

Comment 15 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2524b542c3053e57d0c70593d26c86ef4785f881

commit 2524b542c3053e57d0c70593d26c86ef4785f881
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 22:26:05 2017

Use constexpr TaskTraits constructor in base.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in base.

BUG= 713683 
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2861833002
Cr-Commit-Position: refs/heads/master@{#469167}

[modify] https://crrev.com/2524b542c3053e57d0c70593d26c86ef4785f881/base/test/scoped_task_scheduler.h
[modify] https://crrev.com/2524b542c3053e57d0c70593d26c86ef4785f881/base/trace_event/trace_log.cc

Project Member

Comment 16 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d25ae560c5b6483ed338c89c96636ab9dc73d43b

commit d25ae560c5b6483ed338c89c96636ab9dc73d43b
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 22:34:38 2017

Use constexpr TaskTraits constructor in device.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in device.

BUG= 713683 
R=gab@chromium.org,reillyg@chromium.org
TBR=mcchou@chromium.org

Review-Url: https://codereview.chromium.org/2855233002
Cr-Commit-Position: refs/heads/master@{#469173}

[modify] https://crrev.com/d25ae560c5b6483ed338c89c96636ab9dc73d43b/device/bluetooth/dbus/fake_bluetooth_device_client.cc
[modify] https://crrev.com/d25ae560c5b6483ed338c89c96636ab9dc73d43b/device/usb/usb_service.cc
[modify] https://crrev.com/d25ae560c5b6483ed338c89c96636ab9dc73d43b/device/usb/usb_service_impl.cc

Project Member

Comment 17 by bugdroid1@chromium.org, May 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f60799d8cb1d8a99ba1b3a04156dc30de276272

commit 2f60799d8cb1d8a99ba1b3a04156dc30de276272
Author: fdoray <fdoray@chromium.org>
Date: Wed May 03 22:54:58 2017

Use constexpr TaskTraits constructor in net.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in net.

BUG= 713683 
R=gab@chromium.org
TBR=jri@chromium.org

Review-Url: https://codereview.chromium.org/2854243003
Cr-Commit-Position: refs/heads/master@{#469180}

[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/base/directory_lister.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/disk_cache/blockfile/file_ios.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/disk_cache/cache_util.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/dns/address_sorter_win.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/proxy/polling_proxy_config_service.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/socket/tcp_socket_posix.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/ssl/channel_id_service.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/url_request/url_fetcher_impl_unittest.cc
[modify] https://crrev.com/2f60799d8cb1d8a99ba1b3a04156dc30de276272/net/url_request/url_request_simple_job.cc

Project Member

Comment 18 by bugdroid1@chromium.org, May 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27b0b2aa98566217498c58e9174da2c6789cd433

commit 27b0b2aa98566217498c58e9174da2c6789cd433
Author: fdoray <fdoray@chromium.org>
Date: Thu May 04 19:52:08 2017

Use constexpr TaskTraits constructor in content.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in content.

BUG= 713683 
R=gab@chromium.org
TBR=dgozman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2857983003
Cr-Commit-Position: refs/heads/master@{#469433}

[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/browser_main_loop.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/frame_host/navigation_entry_screenshot_manager.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/net/quota_policy_cookie_store.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/plugin_service_impl.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/renderer_host/clipboard_message_filter.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/renderer_host/pepper/pepper_network_monitor_host.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/storage_partition_impl_map.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/browser/webui/url_data_manager_backend.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/network/url_loader_impl.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/public/browser/browser_thread.h
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/27b0b2aa98566217498c58e9174da2c6789cd433/content/shell/browser/shell_url_request_context_getter.cc

chrome.dll at r468999: 49917952 bytes
chrome.dll at r468999 with migration to constexpr TaskTraits constructor:  49914880 bytes
Delta: 3072 bytes
Number of affected call sites: 324
Bytes per call site: 9.5
Project Member

Comment 20 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eee2186f0e38677b7fa0e804da2037b07ab7b6c5

commit eee2186f0e38677b7fa0e804da2037b07ab7b6c5
Author: fdoray <fdoray@chromium.org>
Date: Mon May 08 21:38:35 2017

Use constexpr TaskTraits constructor in feedback_data.cc.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in net.

BUG= 713683 
TBR=gab@chromium.org,bsimonnet@chromium.org

Review-Url: https://codereview.chromium.org/2867713005
Cr-Commit-Position: refs/heads/master@{#470138}

[modify] https://crrev.com/eee2186f0e38677b7fa0e804da2037b07ab7b6c5/components/feedback/feedback_data.cc

Project Member

Comment 21 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95ee6bf2d209326f59dd26a08f53a8958c7a49e5

commit 95ee6bf2d209326f59dd26a08f53a8958c7a49e5
Author: fdoray <fdoray@chromium.org>
Date: Tue May 09 03:48:12 2017

Remove call to base::TaskTraits::WithPriority() in module_inspector_win.cc.

This method is deprecated.

BUG= 713683 

Review-Url: https://codereview.chromium.org/2873463002
Cr-Commit-Position: refs/heads/master@{#470164}

[modify] https://crrev.com/95ee6bf2d209326f59dd26a08f53a8958c7a49e5/chrome/browser/conflicts/module_inspector_win.cc
[modify] https://crrev.com/95ee6bf2d209326f59dd26a08f53a8958c7a49e5/chrome/browser/conflicts/module_inspector_win.h

Project Member

Comment 22 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5

commit f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5
Author: fdoray <fdoray@chromium.org>
Date: Tue May 09 04:18:32 2017

Use constexpr TaskTraits constructor in base (part 2).

Part 1 https://codereview.chromium.org/2861833002/ didn't catch
cases that didn't use the base:: prefix.

Use a constexpr constructor that accepts traits in any order instead of
the builder pattern to construct TaskTraits in base.

BUG= 713683 
R=gab@chromium.org

Review-Url: https://codereview.chromium.org/2859053006
Cr-Commit-Position: refs/heads/master@{#470195}

[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/observer_list_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/process/kill_win.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/post_task.h
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/priority_queue_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/scheduler_single_thread_task_runner_manager_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/scheduler_worker_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/sequence_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/task_scheduler_impl_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/task_tracker_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/task_scheduler/task_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/test/scoped_task_scheduler_unittest.cc
[modify] https://crrev.com/f7d6f760f8e0fd9fd4683b1d41628c69bebf95d5/base/threading/sequenced_worker_pool.cc

Project Member

Comment 23 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ef24a2589286dd4939a20dc1afddf4ecd9212a0

commit 6ef24a2589286dd4939a20dc1afddf4ecd9212a0
Author: fdoray <fdoray@chromium.org>
Date: Tue May 09 18:00:21 2017

Add base::TaskTraits::Override().

Returns TaskTraits constructed by combining two TaskTraits. If a trait
is in both TaskTraits, the returned TaskTraits will have the value from
the second TaskTraits.

BUG= 713683 
R=gab@chromium.org,robliao@chromium.org

Review-Url: https://codereview.chromium.org/2873453002
Cr-Commit-Position: refs/heads/master@{#470377}

[modify] https://crrev.com/6ef24a2589286dd4939a20dc1afddf4ecd9212a0/base/task_scheduler/post_task.cc
[modify] https://crrev.com/6ef24a2589286dd4939a20dc1afddf4ecd9212a0/base/task_scheduler/task.cc
[modify] https://crrev.com/6ef24a2589286dd4939a20dc1afddf4ecd9212a0/base/task_scheduler/task_traits.h
[modify] https://crrev.com/6ef24a2589286dd4939a20dc1afddf4ecd9212a0/base/task_scheduler/task_traits_unittest.cc

Project Member

Comment 24 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/224f8c294d66cdb6af36a93ec677859c50dd46e2

commit 224f8c294d66cdb6af36a93ec677859c50dd46e2
Author: fdoray <fdoray@chromium.org>
Date: Wed May 10 05:41:22 2017

Use constexpr TaskTraits constructor everywhere.

This CL replaces remaining remaining uses of the builder pattern to
construct TaskTraits with calls to the constexpr TaskTraits
constructor.

BUG= 713683 
TBR=thestig@chromium.org,bauerb@chromium.org,skym@chromium.org

Review-Url: https://codereview.chromium.org/2872933002
Cr-Commit-Position: refs/heads/master@{#470487}

[modify] https://crrev.com/224f8c294d66cdb6af36a93ec677859c50dd46e2/chrome/browser/printing/print_job.cc
[modify] https://crrev.com/224f8c294d66cdb6af36a93ec677859c50dd46e2/chrome/browser/supervised_user/supervised_user_url_filter.cc
[modify] https://crrev.com/224f8c294d66cdb6af36a93ec677859c50dd46e2/components/sync/model_impl/model_type_store_impl.cc

Project Member

Comment 25 by bugdroid1@chromium.org, May 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7599ca4415f3dd4325fa31cb4c37704d68e3cca

commit b7599ca4415f3dd4325fa31cb4c37704d68e3cca
Author: fdoray <fdoray@chromium.org>
Date: Wed May 10 13:41:46 2017

Remove methods associated with the builder pattern from TaskTraits.

BUG= 713683 

Review-Url: https://codereview.chromium.org/2871973003
Cr-Commit-Position: refs/heads/master@{#470553}

[modify] https://crrev.com/b7599ca4415f3dd4325fa31cb4c37704d68e3cca/base/task_scheduler/task_traits.cc
[modify] https://crrev.com/b7599ca4415f3dd4325fa31cb4c37704d68e3cca/base/task_scheduler/task_traits.h

Status: Fixed (was: Started)

Sign in to add a comment