Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/53e9523bf2d1d217d0b5479c6604c53edf61d8b5..d6822b0656d0a9a13ca7926806e22b3afa4d2bf9?pretty=fuller&n=10000

Suspecting: r448854 from Narrow Bisect 

@scottchen : Could you please look into the issue and if possible please help to assign it to concern owner.

tbuckley@ bettes@:
I found out the code says to show the tall (no-scroll) version of the dialog when the viewport height is taller than 724px, but in reality, the dialog is almost always taller than that. 
- It's 764px tall in default font-size 
- It's 815px tall in very large font-size
- It can even grow taller, since there's more things in the footer that can conditionally get rendered.

Basically, if the user's viewport size is between 724px ~ 850px (which I'm guessing is pretty common), there's a very good chance this dialog will look clipped. 

Solution:
1) Just change that upper-bound to 900px, so it'll ONLY show the long form if you have a taller-than-900px viewport.

2) Move the CBD dialog content to a subpage instead of using a dialog.
 - This dialog seems to have gotten so long that it should be on its own page. Having to scroll through it on small screen seems to make the options below the fold harder to discover.
 - Making it a subpage will improve its content's search-ability

1. is a quick solve, but I personally feel like 2. is a more proper solution.

I've also CCed dpapad@ and dschuyler@ who've expressed enthusiasm for moving it to a subpage.

Thoughts?

As we have discussed before, the contents of the CBD dialog are not appropriate for a subpage. It will be staying as a subpage.

Is it possible to dynamically detect how tall the CBD dialog will actually be (given font size changes, etc) and only show the no-scroll version if the window is tall enough to fit it + some padding?

(I think you meant it'll be saying as a dialog)

I think the only way to reliably detect how tall it'll be is to render it out and then calculate the rendered dialog. If we do that first and then shrink the size after, users *might* see a blip in the rendering process (of it being large for a split second and then shrinking). I'll experiment with it real quick and confirm.

tbuckley@, so I tested dynamic height changing such that it'll shrink the body of the dialog until it fits in the viewport, and it actually works pretty well.

Though, do we want to have a minimum body height? Otherwise 250% zoom would look like the attached file.

Deleted: Screen Shot 2017-04-26 at 9.17.35 PM.png 259 KB

	Screen Shot 2017-04-26 at 9.17.35 PM.png 259 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc2f3e78a68e400ab08ab5f0396fb77428ea4860

commit fc2f3e78a68e400ab08ab5f0396fb77428ea4860
Author: scottchen <scottchen@chromium.org>
Date: Tue May 02 18:52:01 2017

WebUI: restrict cr-dialogs max-height to the viewport.

BUG= 713663 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2843333002
Cr-Commit-Position: refs/heads/master@{#468722}

[modify] https://crrev.com/fc2f3e78a68e400ab08ab5f0396fb77428ea4860/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/fc2f3e78a68e400ab08ab5f0396fb77428ea4860/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

I don't think we need to worry too much about how the UI behaves at 500%. 

Though how would a minimum body height improve the experience in that case? Would we make the footer scroll?

Just for the record tbuckley@ and I discussed offline and reached a conclusion as depicted by this CL: https://bugs.chromium.org/p/chromium/issues/detail?id=713663