New issue
Advanced search Search tips

Issue 713624 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK hit in event_converter_evdev.cc: !enabled_

Project Member Reported by emaxx@chromium.org, Apr 20 2017

Issue description

Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Build a dcheck_always_on=true build for veyron_minnie and deploy it to a minnie Chromebook.
(2) Log in.

What is the expected result?

What happens instead?
Crash after several seconds:
[FATAL:event_converter_evdev.cc(40)] Check failed: !enabled_.


spang@: Assigning to you based on the OWNERS file. No suspected CL was found (the DCHECK have been there for a long time).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/419dd2a3447f1d39c092f4259d87906c192ed0da

commit 419dd2a3447f1d39c092f4259d87906c192ed0da
Author: spang <spang@chromium.org>
Date: Fri Apr 21 15:00:56 2017

Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG= 711431 ,  713624 , 713968
TEST=just compile

Review-Url: https://codereview.chromium.org/2828843002
Cr-Commit-Position: refs/heads/master@{#466336}

[modify] https://crrev.com/419dd2a3447f1d39c092f4259d87906c192ed0da/ui/events/ozone/evdev/event_converter_evdev.cc
[modify] https://crrev.com/419dd2a3447f1d39c092f4259d87906c192ed0da/ui/events/ozone/evdev/event_converter_evdev_impl.cc
[modify] https://crrev.com/419dd2a3447f1d39c092f4259d87906c192ed0da/ui/events/ozone/evdev/input_device_factory_evdev.h
[modify] https://crrev.com/419dd2a3447f1d39c092f4259d87906c192ed0da/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

Comment 2 by spang@chromium.org, Apr 21 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2017

Labels: merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/955a01b06b3cb7fb6ca51acd085313439c0ef5bb

commit 955a01b06b3cb7fb6ca51acd085313439c0ef5bb
Author: Stéphane Marchesin <marcheu@chromium.org>
Date: Sat Apr 22 01:35:20 2017

Fix unsafe destruction order of InputDeviceFactoryEvdev

This was never destroyed prior to 60a7c584a9be ("mash: Don't synthesize
extra key press events in the window server").

Now it's destroyed in a couple places, so try to make this safe.
Particularly, destroy devices prior to shared state such as the gestures
properties object, and make devices stop DCHECKing that they are
destroyed gently (i.e., by getting disabled and stopped from the hotplug
handler). Shutdown destruction is abrupt.

This should fix a couple issues people are seeing since we started
calling the destructor (at least the input related ones).

BUG= 711431 ,  713624 , 713968
TEST=just compile

Review-Url: https://codereview.chromium.org/2828843002
Cr-Commit-Position: refs/heads/master@{#466336}
(cherry picked from commit 419dd2a3447f1d39c092f4259d87906c192ed0da)

Review-Url: https://codereview.chromium.org/2833243002 .
Cr-Commit-Position: refs/branch-heads/3071@{#140}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/955a01b06b3cb7fb6ca51acd085313439c0ef5bb/ui/events/ozone/evdev/event_converter_evdev.cc
[modify] https://crrev.com/955a01b06b3cb7fb6ca51acd085313439c0ef5bb/ui/events/ozone/evdev/event_converter_evdev_impl.cc
[modify] https://crrev.com/955a01b06b3cb7fb6ca51acd085313439c0ef5bb/ui/events/ozone/evdev/input_device_factory_evdev.h
[modify] https://crrev.com/955a01b06b3cb7fb6ca51acd085313439c0ef5bb/ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment