New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713590 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

Shouldn't see search geolocation disclosure before PDS is accepted

Project Member Reported by benwells@chromium.org, Apr 20 2017

Issue description

Apparently this can happen. I'm not really sure how it would happen ... this means that the privacy policy is asking for location access, which is pretty bizarre.

will try to repro tomorrow.
 
screenshot-071dccc3439d09bd-20170419T162736.png
238 KB View Download
I don't think it does... Could it be that the document is mistakenly requested with the geo header?

Comment 2 by battre@chromium.org, Apr 20 2017

Cc: battre@chromium.org
Hmm, yeah this can totally happen. The geo header isn't being sent, the disclosure is just shown on all navigations to the same origin as the current google search engine, which this matches.

I think we should check to make sure the t&c have been accepted before showing the disclosure.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae9cf3f8288419c4985e4543bcd07ebf65bfd21

commit 2ae9cf3f8288419c4985e4543bcd07ebf65bfd21
Author: benwells <benwells@chromium.org>
Date: Sat Apr 22 19:26:25 2017

Don't enable the DSE geolocation setting until EULA accepted

This does two things. Firstly it prevents the DSE getting opt-out access to the geolocation API before the EULA is accepted. Secondly, it prevents the search geolocation disclosure from being shown before the EULA is accepted (e.g. on the privacy policy).

BUG= 713590 

Review-Url: https://codereview.chromium.org/2827333004
Cr-Commit-Position: refs/heads/master@{#466548}

[modify] https://crrev.com/2ae9cf3f8288419c4985e4543bcd07ebf65bfd21/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java
[modify] https://crrev.com/2ae9cf3f8288419c4985e4543bcd07ebf65bfd21/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java
[modify] https://crrev.com/2ae9cf3f8288419c4985e4543bcd07ebf65bfd21/chrome/browser/android/search_geolocation/search_geolocation_service.cc

Labels: Merge-Request-59
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 26 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, May 1 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, May 2 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5929a6d1f6f72bf674aa18906e6b68d729002226

commit 5929a6d1f6f72bf674aa18906e6b68d729002226
Author: Ben Wells <benwells@chromium.org>
Date: Tue May 02 01:50:17 2017

Don't enable the DSE geolocation setting until EULA accepted

This does two things. Firstly it prevents the DSE getting opt-out access to the geolocation API before the EULA is accepted. Secondly, it prevents the search geolocation disclosure from being shown before the EULA is accepted (e.g. on the privacy policy).

BUG= 713590 

Review-Url: https://codereview.chromium.org/2827333004
Cr-Commit-Position: refs/heads/master@{#466548}
(cherry picked from commit 2ae9cf3f8288419c4985e4543bcd07ebf65bfd21)

Review-Url: https://codereview.chromium.org/2853763005 .
Cr-Commit-Position: refs/branch-heads/3071@{#338}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/5929a6d1f6f72bf674aa18906e6b68d729002226/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java
[modify] https://crrev.com/5929a6d1f6f72bf674aa18906e6b68d729002226/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderTest.java
[modify] https://crrev.com/5929a6d1f6f72bf674aa18906e6b68d729002226/chrome/browser/android/search_geolocation/search_geolocation_service.cc

Status: Fixed (was: Assigned)

Sign in to add a comment