New issue
Advanced search Search tips

Issue 713561 link

Starred by 0 users
Status: Fixed
Owner: ----
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

nassh: show relay server actually being used

Project Member Reported by vapier@chromium.org, Apr 20 2017 
when using a relay server, we log the one we're using to look things up, but not the one we actually end up connecting to:

Looking up relay server using: ssh-relay.corp.google.com:443
Connecting to vapier@vapier.cam.corp.google.com...
Loading NaCl plugin... done.

we should log the actual relay server that we're sent to.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/edda435e7640c9ba9a778ab9f7814349781d9e5f

commit edda435e7640c9ba9a778ab9f7814349781d9e5f
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Apr 20 16:16:38 2017

nassh: log the relay server we use

While we log the initial server we connect to, we don't log the one
that we end up relaying through.  We already had a translation for
it too, so use it!  Now we see:

Looking up relay server using: ssh-relay.corp.google.com:443
Found relay server: https://nyc1.r.ext.google.com:443/
Connecting to vapier@vapier.cam.corp.google.com...

BUG= chromium:713561 

Change-Id: I3316def5037337457c6f9cf2d987d042c591a3e8
Reviewed-on: https://chromium-review.googlesource.com/482641
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/edda435e7640c9ba9a778ab9f7814349781d9e5f/nassh/js/nassh_google_relay.js

Comment 2 by vapier@chromium.org, Apr 20 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)
will be part of 0.8.36.3+

Comment 3 Deleted

►

Sign in to add a comment