New issue
Advanced search Search tips

Issue 713534 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

implement relative graphics memory usage

Project Member Reported by ihf@chromium.org, Apr 20 2017

Issue description

In some tests we record how much memory is currently used, say in graphics_WebGLAquarium.py

keyvals = self.GSC.get_memory_keyvals()

Now often it is better to get relative usage since the test started running and the GSC got created:

    def initialize(self):
        self.GSC = graphics_utils.GraphicsStateChecker()

So, track this initial memory usage and add a function get_memory_difference_keyvals() to obtain the delta. Going from there we should replace our memory measurements with relative changes and send these to the Chrome performance dashboard.
https://chromeperf.appspot.com/report?sid=55da93698c24c7b7b0e450638e6c604c6dd6083716a2f04b5be9f49344194d17

I am still thinking if we should just overwrite the old values on the dashboard or if we should create a new set.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0b1d88ba975bf1dd60a41a9ef0e9c9dd40d41841

commit 0b1d88ba975bf1dd60a41a9ef0e9c9dd40d41841
Author: Po-Hsien Wang <pwang@chromium.org>
Date: Sat Apr 22 03:34:21 2017

Graphics_WebGLAquarium: relative memory usage

1) Add function get_memory_difference_keyvals to autotest graphics_utils.py.
2) graphics_WebGLAquarium.py report the memory difference instead of the final memory usage.

BUG= chromium:713534 
TEST=test_that

Change-Id: Ie2966226809c4c67fb9c1ca93b93fb21e89a9a02
Reviewed-on: https://chromium-review.googlesource.com/483147
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Commit-Queue: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/0b1d88ba975bf1dd60a41a9ef0e9c9dd40d41841/client/cros/graphics/graphics_utils.py
[modify] https://crrev.com/0b1d88ba975bf1dd60a41a9ef0e9c9dd40d41841/client/site_tests/graphics_WebGLAquarium/graphics_WebGLAquarium.py

Comment 2 by pwang@chromium.org, Apr 24 2017

Status: Fixed (was: Untriaged)

Comment 3 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment