nassh: validate relay options field in the connection string |
|
Issue descriptionif you typo a flag in the relay options field, it'll be silently ignored which can lead to annoying debug sessions for users. we should reject any options we don't understand.
,
Oct 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/apps/libapps/+/464d5745ea399d64489e3378bd2d51803e192eb4 commit 464d5745ea399d64489e3378bd2d51803e192eb4 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Oct 10 00:47:02 2017 nassh: validate relay options Currently, unknown relay options are silently ignored which can lead to frustrating debugging sessions. Add some checks to the HTML and JS code to explicitly surface invalid options. BUG= chromium:713526 Change-Id: I053399e02140fe1b849b0678661af97e52ebca21 Reviewed-on: https://chromium-review.googlesource.com/706833 Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Brandon Gilmore <varz@google.com> [modify] https://crrev.com/464d5745ea399d64489e3378bd2d51803e192eb4/nassh/html/nassh_test.html [add] https://crrev.com/464d5745ea399d64489e3378bd2d51803e192eb4/nassh/js/nassh_google_relay_tests.js [modify] https://crrev.com/464d5745ea399d64489e3378bd2d51803e192eb4/nassh/html/nassh_connect_dialog.html [modify] https://crrev.com/464d5745ea399d64489e3378bd2d51803e192eb4/nassh/js/nassh_google_relay.js [modify] https://crrev.com/464d5745ea399d64489e3378bd2d51803e192eb4/nassh/_locales/en/messages.json [modify] https://crrev.com/464d5745ea399d64489e3378bd2d51803e192eb4/nassh/js/nassh_command_instance.js |
|
►
Sign in to add a comment |
|
Comment 1 by vapier@chromium.org
, Oct 10 2017