nassh: validate hostname field in the connection screen |
||
Issue descriptionif you enter foo@bar into the hostname, we end up concating that to user@foo@bar which then parses the "bar" as relay options. oops.
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/apps/libapps/+/5b3c5a93760d52b49f2f62040b89c4daadc7aa28 commit 5b3c5a93760d52b49f2f62040b89c4daadc7aa28 Author: Mike Frysinger <vapier@chromium.org> Date: Wed May 10 04:37:29 2017 nassh: add hostname checking Add a regex to match all valid hostnames and IPv4 & IPv6 addresses. This rejects IDNs, but we already don't properly support those, so it isn't like we're breaking existing functionality :). This will accept invalid hostnames/IP addresses, but this regex is much simpler than one that only accepts valid names. BUG= chromium:713524 Change-Id: I7858ee1d64ce16112adbce1ab579b78b2650fde0 Reviewed-on: https://chromium-review.googlesource.com/495608 Reviewed-by: Brandon Gilmore <varz@google.com> Tested-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/5b3c5a93760d52b49f2f62040b89c4daadc7aa28/nassh/html/nassh_connect_dialog.html
,
May 10 2017
this will be in nassh-0.8.36.4+
,
May 29 2017
|
||
►
Sign in to add a comment |
||
Comment 1 Deleted