Implement snackbar in Translate UI
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7111808ad97f5eea6a9701132a24a98406a26806 commit 7111808ad97f5eea6a9701132a24a98406a26806 Author: ramyasharma <ramyasharma@chromium.org> Date: Mon May 01 07:03:52 2017 Introduces snackbar enum, & other snackbar classes on android for translate user actions. CL#1 This snackbar will be used to convey to the user the result of any action performed on the Translate infobar. BUG= 713514 TBR=groby@chromium.org Review-Url: https://codereview.chromium.org/2838833003 Cr-Commit-Position: refs/heads/master@{#468302} [modify] https://crrev.com/7111808ad97f5eea6a9701132a24a98406a26806/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java [add] https://crrev.com/7111808ad97f5eea6a9701132a24a98406a26806/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateSnackbarController.java [modify] https://crrev.com/7111808ad97f5eea6a9701132a24a98406a26806/chrome/android/java_sources.gni [modify] https://crrev.com/7111808ad97f5eea6a9701132a24a98406a26806/chrome/browser/BUILD.gn [modify] https://crrev.com/7111808ad97f5eea6a9701132a24a98406a26806/chrome/browser/translate/android/translate_utils.h [modify] https://crrev.com/7111808ad97f5eea6a9701132a24a98406a26806/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48808f1acfda5746d21186fc83fbc60ffe0646d9 commit 48808f1acfda5746d21186fc83fbc60ffe0646d9 Author: ramyasharma <ramyasharma@chromium.org> Date: Wed May 03 08:20:01 2017 Shows snackbar in translate infobar, after certain user actions. CL#2 Plumbs through snackbar manager from Infobar container to TranslateCompactInfobar, and shows a snackbar on actions like always / never translate. BUG= 713514 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2840933003 Cr-Commit-Position: refs/heads/master@{#468917} [modify] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java [modify] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java [modify] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java [modify] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateSnackbarController.java [modify] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java [modify] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java [add] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/browser/ui/android/snackbars/translate_snackbar.cc [add] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/chrome/browser/ui/android/snackbars/translate_snackbar.h [modify] https://crrev.com/48808f1acfda5746d21186fc83fbc60ffe0646d9/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ca1f3e7c2ace2dba216a9f9bd099bcb3fea982c commit 3ca1f3e7c2ace2dba216a9f9bd099bcb3fea982c Author: ramyasharma <ramyasharma@chromium.org> Date: Mon May 08 09:09:02 2017 Moves translate snackbar functionality to Android side. To keep the implementation simple, we are not going back and forth between C++ and java. Instead of applying a translate option, and then undoing it when CANCEL is pressed in the snackbar, we do the following: 1. When snackbar is dismissed we apply options and the rest of the flow continues. 2. Otherwise if CANCEL (on snackbar) is pressed, we don't apply options, and the infobar stays. Demo: https://drive.google.com/open?id=0B-aCbwkKD2XZcXpteDhTM25WZ2c BUG= 713514 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2854243004 Cr-Commit-Position: refs/heads/master@{#469932} [modify] https://crrev.com/3ca1f3e7c2ace2dba216a9f9bd099bcb3fea982c/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java [delete] https://crrev.com/9499e291d08f34855a3c849f5b3e48ab62a9910b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateSnackbarController.java [modify] https://crrev.com/3ca1f3e7c2ace2dba216a9f9bd099bcb3fea982c/chrome/android/java_sources.gni [modify] https://crrev.com/3ca1f3e7c2ace2dba216a9f9bd099bcb3fea982c/chrome/browser/BUILD.gn [delete] https://crrev.com/9499e291d08f34855a3c849f5b3e48ab62a9910b/chrome/browser/ui/android/snackbars/translate_snackbar.cc [delete] https://crrev.com/9499e291d08f34855a3c849f5b3e48ab62a9910b/chrome/browser/ui/android/snackbars/translate_snackbar.h
Comment 1 by lafo...@chromium.org
, Apr 27 2017