Issue metadata
Sign in to add a comment
|
process_metrics_memory_dump_provider.cc should not use mach_vm_region_recurse |
||||||||||||||||||||||||
Issue descriptionOn my desktop, with ~30-50 tabs open, this stalls my machine for over a minute. It's b/c we're simultaneously trying to crawl every page in every process. We should just switch to mach_region(TOP_INFO...)
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12531f29074985a71e18f60a2e8ea79b4f24314c commit 12531f29074985a71e18f60a2e8ea79b4f24314c Author: erikchen <erikchen@chromium.org> Date: Fri Apr 21 19:48:51 2017 Use faster, but less information methods to calculate memory dumps on macOS. Switch to use mach_vm_region(TOP_INFO) and mach_vm_region(BASIC_INFO) instead of mach_vm_region_recurse(). While the latter provides more information, both on submaps and on swapped/clean pages, it's two order of magnitudes slower. Attempting to take a memory dump with ~50 renderer renderers my machine unusable for over a minute. BUG= 713481 Review-Url: https://codereview.chromium.org/2826123004 Cr-Commit-Position: refs/heads/master@{#466417} [modify] https://crrev.com/12531f29074985a71e18f60a2e8ea79b4f24314c/base/process/process_metrics.h [modify] https://crrev.com/12531f29074985a71e18f60a2e8ea79b4f24314c/base/process/process_metrics_mac.cc [modify] https://crrev.com/12531f29074985a71e18f60a2e8ea79b4f24314c/components/tracing/common/process_metrics_memory_dump_provider.cc
,
Apr 24 2017
Issue 714664 has been merged into this issue.
,
Apr 24 2017
,
Apr 24 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f0910deb4cac181efa7976efca1a3811dcbe93d commit 8f0910deb4cac181efa7976efca1a3811dcbe93d Author: erikchen <erikchen@chromium.org> Date: Mon Apr 24 21:06:28 2017 [Merge to 3071] Use faster, but less information methods to calculate memory dumps on macOS. > Switch to use mach_vm_region(TOP_INFO) and mach_vm_region(BASIC_INFO) instead of > mach_vm_region_recurse(). While the latter provides more information, both on > submaps and on swapped/clean pages, it's two order of magnitudes slower. > Attempting to take a memory dump with ~50 renderer renderers my machine unusable > for over a minute. BUG= 713481 Review-Url: https://codereview.chromium.org/2826123004 Cr-Commit-Position: refs/heads/master@{#466417} (cherry picked from commit 12531f29074985a71e18f60a2e8ea79b4f24314c) Review-Url: https://codereview.chromium.org/2840733002 . Cr-Commit-Position: refs/branch-heads/3071@{#177} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/8f0910deb4cac181efa7976efca1a3811dcbe93d/base/process/process_metrics.h [modify] https://crrev.com/8f0910deb4cac181efa7976efca1a3811dcbe93d/base/process/process_metrics_mac.cc [modify] https://crrev.com/8f0910deb4cac181efa7976efca1a3811dcbe93d/components/tracing/common/process_metrics_memory_dump_provider.cc
,
Apr 24 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by erikc...@chromium.org
, Apr 20 2017Status: Assigned (was: Untriaged)