[TTS] Tap after an invalid Tap is sometimes ignored |
|||
Issue descriptionEasiest way to reproduce is to just go to chrome://flags page and tap in a big triangle pattern around the first paragraph with one corner in the whitespace on the right side (for an invalid tap). The tap-near logic is not informed of the invalid tap, so it eats the next tap, even though the invalid tap removed the selection and the rest of the UX so the next tap should select.
,
Nov 8 2017
Need for M-64 for tap suppression.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b10783b6731e3ba8156e1a05645a1dca10f59b0 commit 9b10783b6731e3ba8156e1a05645a1dca10f59b0 Author: Donn Denman <donnd@google.com> Date: Wed Nov 29 18:02:29 2017 [TTS] Fix tap-far-from-previous suppression. A tap that's far from the previous tap should generally be ignored, and just dismiss our UI instead of starting a new tap-handling sequence. This CL updates our logic to look at whether there was any selection before the tap rather than whether the previous tap was suppressed. Our old logic ignored whether there was any selection before the tap, and used whether the previous tap was suppressed as a proxy for no-selection. Recent code changes make it fairly easy to determine if there was a selection just before a tap gesture so we use that instead. The difference becomes clear when "invalid taps" are considered. These are taps on non-text characters, e.g. a period or comma. These taps don't select, but they also are not technically suppressed, so a subsequent tap would be ignored. Now any tap that's far from a previous tap will be ignored only if there was a selection before the tap. BUG= 713471 Change-Id: Ie94e345a87cf580a3d1993370938982e6e273e89 Reviewed-on: https://chromium-review.googlesource.com/794020 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#520161} [modify] https://crrev.com/9b10783b6731e3ba8156e1a05645a1dca10f59b0/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java [modify] https://crrev.com/9b10783b6731e3ba8156e1a05645a1dca10f59b0/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapFarFromPreviousSuppression.java [modify] https://crrev.com/9b10783b6731e3ba8156e1a05645a1dca10f59b0/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapSuppressionHeuristics.java
,
Nov 29 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by donnd@chromium.org
, May 24 2017Labels: -Pri-3 Pri-2
Summary: [TTS] Tap after an invalid Tap is sometimes ignored (was: [TTS] Tap after an invalid Tap is ignored)