https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__dbg_/8413/layout-test-results/virtual/gpu/fast/canvas/canvas-ImageData-neutered-source-stderr.txt [9166:775:0419/161056.694067:419047974447:INFO:GrContext.cpp(915)] ../../third_party/skia/src/gpu/GrContext.cpp:915: fatal error: "assert(fDidTestPMConversions)" Possibly coincided with https://codereview.chromium.org/2823003002
virtual/gpu/fast/canvas/canvas-imageSmoothingQuality.html is hitting the same assert: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/8410 https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__dbg_/8410/layout-test-results/virtual/gpu/fast/canvas/canvas-imageSmoothingQuality-stderr.txt
Latter test already marked Failure by https://bugs.chromium.org/p/chromium/issues/detail?id=693568
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e7ec6b34968ce11c7cc565063a7e13a8076d3f4 commit 7e7ec6b34968ce11c7cc565063a7e13a8076d3f4 Author: aboxhall <aboxhall@chromium.org> Date: Thu Apr 20 04:19:44 2017 Add TestExpectation for canvas-ImageData-neutered-source.html BUG= 713462 TBR=reed Review-Url: https://codereview.chromium.org/2828153002 Cr-Commit-Position: refs/heads/master@{#465896} [modify] https://crrev.com/7e7ec6b34968ce11c7cc565063a7e13a8076d3f4/third_party/WebKit/LayoutTests/TestExpectations
Assert is harmless, left during a refactor that should have removed it. Will fix ASAP.
The following revision refers to this bug: https://skia.googlesource.com/skia/+/7b2391bc06a4cb5db83e3cd13402869fbe8b0bfd commit 7b2391bc06a4cb5db83e3cd13402869fbe8b0bfd Author: Brian Osman <brianosman@google.com> Date: Thu Apr 20 13:59:16 2017 Remove incorrect assert We only need to verify that we've tested the PM conversion if we're about to use GrConfigConversionEffect. For the else case, no such guarantee is made, so the assert is wrong. Bug: chromium:713462 Change-Id: I5ffcc0c5f7de4e9614e9ccd83140acc9ab4f7283 Reviewed-on: https://skia-review.googlesource.com/13962 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com> [modify] https://crrev.com/7b2391bc06a4cb5db83e3cd13402869fbe8b0bfd/src/gpu/GrContext.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3182feed58c8d7838cf85f3f4b620606ea06f7a5 commit 3182feed58c8d7838cf85f3f4b620606ea06f7a5 Author: schenney <schenney@chromium.org> Date: Thu Apr 20 20:51:57 2017 Update TestExpectations and rebase some tests. Try reducing flakes for images/color-profile-reflection.html by switching to runAfterLayoutAndPaint. Rebaseline canvas drawing tests after path tesselation patch landed. Remove expectations for no-longer-failing images/color-profile-reflection.html and virtual/gpu/fast/canvas/canvas-ImageData-neutered-source.html TBR=junov@chromium.org BUG= 642376 , 706375 ,713049, 713462 Review-Url: https://codereview.chromium.org/2831953002 Cr-Commit-Position: refs/heads/master@{#466120} [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/images/color-profile-reflection.html [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [add] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-incremental-repaint-expected.png [delete] https://crrev.com/e8227a0e1c5fc7f230fe575086e1816a4e9fa6ae/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-expected.png [add] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-arc-circumference-fill-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-expected.png [modify] https://crrev.com/3182feed58c8d7838cf85f3f4b620606ea06f7a5/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/canvas-ellipse-circumference-fill-expected.png
Comment 1 by aboxhall@chromium.org
, Apr 20 2017