New issue
Advanced search Search tips

Issue 713454 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 706017



Sign in to add a comment

Enable encryption migration UI by default.

Project Member Reported by fukino@chromium.org, Apr 20 2017

Issue description

The migration UI is behind a flag: #enable-encryption-migration.
Once the back-end process is ready for the migration, we should enable the UI by default.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e769db4f707bbc5962ee1aa0a1c727081ee754a

commit 3e769db4f707bbc5962ee1aa0a1c727081ee754a
Author: fukino <fukino@chromium.org>
Date: Fri Apr 21 02:25:17 2017

cros: Enable encryption migration UI by default.

Now that the back-end migration logic is ready, we should enable the migration UI by default.
This CL does:
- Modify encryption migration's flag type from SINGLE_VALUE_TYPE to ENABLE_DISABLE_VALUE_TYPE to have a default value.
- Enable encryption migration by default on ToT.

BUG= 713454 
TEST=manually tested the #enable-encryption-migration flag that "Enabled" and "Default" shows migration UI and "Disabled" doesn't.

Review-Url: https://codereview.chromium.org/2830933004
Cr-Commit-Position: refs/heads/master@{#466232}

[modify] https://crrev.com/3e769db4f707bbc5962ee1aa0a1c727081ee754a/chrome/browser/about_flags.cc
[modify] https://crrev.com/3e769db4f707bbc5962ee1aa0a1c727081ee754a/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/3e769db4f707bbc5962ee1aa0a1c727081ee754a/chromeos/chromeos_switches.cc
[modify] https://crrev.com/3e769db4f707bbc5962ee1aa0a1c727081ee754a/chromeos/chromeos_switches.h
[modify] https://crrev.com/3e769db4f707bbc5962ee1aa0a1c727081ee754a/tools/metrics/histograms/histograms.xml

Comment 2 by fukino@chromium.org, Apr 27 2017

Labels: ArcExt4Migration Merge-Request-59

Comment 3 by fukino@chromium.org, Apr 27 2017

Requesting a merge to M59, as we have confirmed it is working on ToT.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e61d3674614164036a6a3746eb79c26648ac5c

commit d5e61d3674614164036a6a3746eb79c26648ac5c
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Apr 27 01:49:53 2017

cros: Enable encryption migration UI by default.

Now that the back-end migration logic is ready, we should enable the migration UI by default.
This CL does:
- Modify encryption migration's flag type from SINGLE_VALUE_TYPE to ENABLE_DISABLE_VALUE_TYPE to have a default value.
- Enable encryption migration by default on ToT.

BUG= 713454 
TEST=manually tested the #enable-encryption-migration flag that "Enabled" and "Default" shows migration UI and "Disabled" doesn't.
TBR=xiyuan@chromium.org,isherman@chromium.org

Review-Url: https://codereview.chromium.org/2830933004
Cr-Commit-Position: refs/heads/master@{#466232}
(cherry picked from commit 3e769db4f707bbc5962ee1aa0a1c727081ee754a)

Review-Url: https://codereview.chromium.org/2848473002 .
Cr-Commit-Position: refs/branch-heads/3071@{#250}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/d5e61d3674614164036a6a3746eb79c26648ac5c/chrome/browser/about_flags.cc
[modify] https://crrev.com/d5e61d3674614164036a6a3746eb79c26648ac5c/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/d5e61d3674614164036a6a3746eb79c26648ac5c/chromeos/chromeos_switches.cc
[modify] https://crrev.com/d5e61d3674614164036a6a3746eb79c26648ac5c/chromeos/chromeos_switches.h
[modify] https://crrev.com/d5e61d3674614164036a6a3746eb79c26648ac5c/tools/metrics/histograms/histograms.xml

Comment 6 by fukino@chromium.org, Apr 27 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on 9532.0.0, 60.0.3092.0. Encryption migration UI is on by default.


Sign in to add a comment