New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713446 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

samus-pre-flight-branch should generate AutoFDO profiles for clang/llvm since R59.

Project Member Reported by laszio@chromium.org, Apr 20 2017

Issue description

Currently it's generating for gcc.

CLs for master / R60:
https://chromium-review.googlesource.com/c/482523
https://chromium-review.googlesource.com/c/447869

Will cherry-pick them into R59 after the above are merged and verified.
 

Comment 1 by laszio@chromium.org, Apr 20 2017

Labels: Build-Toolchain
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/941872ec0bc83b43d000ae65fa2e88c695b1137e

commit 941872ec0bc83b43d000ae65fa2e88c695b1137e
Author: Ting-Yuan Huang <laszio@google.com>
Date: Sat Apr 22 04:57:38 2017

afdo: move samus to the llvm pipeline

Chrome on samus is going to be built by llvm.
Also removing link.

BUG= chromium:713446 
TEST=None

Change-Id: Iede688cda16901d425b63ab2a27f98a262495b56
Reviewed-on: https://chromium-review.googlesource.com/447869
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/941872ec0bc83b43d000ae65fa2e88c695b1137e/cbuildbot/afdo.py
[modify] https://crrev.com/941872ec0bc83b43d000ae65fa2e88c695b1137e/cbuildbot/stages/afdo_stages.py

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f3c86ddc1643791f96b68783a84368290942e305

commit f3c86ddc1643791f96b68783a84368290942e305
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Sat Apr 22 04:57:46 2017

afdo: move samus to the llvm pipeline

Chrome on samus is going to be built by llvm.
Also removing link.

BUG= chromium:713446 
TEST=None

Change-Id: I918be649c294338d97656f609dd5706b6e56d831
Reviewed-on: https://chromium-review.googlesource.com/482523
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/f3c86ddc1643791f96b68783a84368290942e305/server/site_tests/telemetry_AFDOGenerate/telemetry_AFDOGenerate.py

Comment 4 by laszio@chromium.org, Apr 24 2017

Labels: Merge-Request-59

Comment 5 by gov...@chromium.org, Apr 24 2017

Please add applicable OSs.
Labels: OS-Chrome
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 25 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 25 2017

Labels: merge-merged-release-R59-9460.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/877d194071e8862c39ebd66a6c5570e4b95353c8

commit 877d194071e8862c39ebd66a6c5570e4b95353c8
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Apr 25 19:31:18 2017

afdo: move samus to the llvm pipeline

Chrome on samus is going to be built by llvm.
Also removing link.

BUG= chromium:713446 
TEST=None

Change-Id: I918be649c294338d97656f609dd5706b6e56d831
Reviewed-on: https://chromium-review.googlesource.com/482523
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
(cherry picked from commit f3c86ddc1643791f96b68783a84368290942e305)
Reviewed-on: https://chromium-review.googlesource.com/486119
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/877d194071e8862c39ebd66a6c5570e4b95353c8/server/site_tests/telemetry_AFDOGenerate/telemetry_AFDOGenerate.py

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b3630861dfd799fe3e503474a47c0d650b3b8a74

commit b3630861dfd799fe3e503474a47c0d650b3b8a74
Author: Ting-Yuan Huang <laszio@google.com>
Date: Tue Apr 25 19:31:18 2017

afdo: move samus to the llvm pipeline

Chrome on samus is going to be built by llvm.
Also removing link.

BUG= chromium:713446 
TEST=None

Change-Id: Iede688cda16901d425b63ab2a27f98a262495b56
Reviewed-on: https://chromium-review.googlesource.com/447869
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
(cherry picked from commit 941872ec0bc83b43d000ae65fa2e88c695b1137e)
Reviewed-on: https://chromium-review.googlesource.com/486139
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Ting-Yuan Huang <laszio@chromium.org>
Trybot-Ready: Ting-Yuan Huang <laszio@chromium.org>

[modify] https://crrev.com/b3630861dfd799fe3e503474a47c0d650b3b8a74/cbuildbot/afdo.py
[modify] https://crrev.com/b3630861dfd799fe3e503474a47c0d650b3b8a74/cbuildbot/stages/afdo_stages.py

Status: Fixed (was: Untriaged)
Project Member

Comment 12 by sheriffbot@chromium.org, May 1 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-59

Sign in to add a comment