New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 713442 link

Starred by 5 users
Status: Fixed
Owner:
█ brettw@chromium.org
Last visit 26 days ago
Closed: Sep 2017
Cc:
kcc@chromium.org
█ phajdan.jr@chromium.org
█ krasin@chromium.org
alex...@yandex-team.ru
p...@chromium.org
█ ranjitkan@chromium.org
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

LoggingTest.NestedLogAssertHandlers base_unittest is failing on Win,Mac and Linux 64 official.desktop continuous builders

Project Member Reported by pbomm...@chromium.org, Apr 19 2017 
Link to builder :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/61875

https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/145

https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1726

Link to error :
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/61875/steps/base_unittests/logs/LoggingTest.NestedLogAssertHandlers

https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/145/steps/base_unittests/logs/LoggingTest.NestedLogAssertHandlers

https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1726/steps/base_unittests/logs/LoggingTest.NestedLogAssertHandlers


Error log :
LoggingTest.NestedLogAssertHandlers (run #1):
[ RUN      ] LoggingTest.NestedLogAssertHandlers
Backtrace:
	logging::`anonymous namespace'::LoggingTest_NestedLogAssertHandlers_Test::TestBody [0x0000000140230B58+1192] (c:\b\build\slave\win_trunk\build\src\base\logging_unittest.cc:542)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::TestCase,void> [0x0000000140647A8D+61] (c:\b\build\slave\win_trunk\build\src\testing\gtest\src\gtest.cc:2460)
	testing::Test::Run [0x0000000140653BCA+122] (c:\b\build\slave\win_trunk\build\src\testing\gtest\src\gtest.cc:2481)
	testing::TestInfo::Run [0x0000000140653DC1+161] (c:\b\build\slave\win_trunk\build\src\testing\gtest\src\gtest.cc:2660)
	testing::TestCase::Run [0x0000000140653CA5+165] (c:\b\build\slave\win_trunk\build\src\testing\gtest\src\gtest.cc:2773)
	testing::internal::UnitTestImpl::RunAllTests [0x0000000140654172+562] (c:\b\build\slave\win_trunk\build\src\testing\gtest\src\gtest.cc:4645)
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x0000000140647B2D+61] (c:\b\build\slave\win_trunk\build\src\testing\gtest\src\gtest.cc:2460)
	testing::UnitTest::Run [0x0000000140653F09+217] (c:\b\build\slave\win_trunk\build\src\testing\gtest\src\gtest.cc:4255)
	base::TestSuite::Run [0x000000014078E0D9+137] (c:\b\build\slave\win_trunk\build\src\base\test\test_suite.cc:271)
	base::`anonymous namespace'::LaunchUnitTestsInternal [0x000000014078B8A6+886] (c:\b\build\slave\win_trunk\build\src\base\test\launcher\unit_test_launcher.cc:252)
	base::LaunchUnitTests [0x000000014078B517+103] (c:\b\build\slave\win_trunk\build\src\base\test\launcher\unit_test_launcher.cc:453)
	main [0x000000014078A01C+108] (c:\b\build\slave\win_trunk\build\src\base\test\run_all_base_unittests.cc:22)
	__scrt_common_main_seh [0x00000001407549C9+285] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:253)
	BaseThreadInitThunk [0x00000000777259CD+13]
	RtlUserThreadStart [0x000000007795B981+33]


Suspected CL : https://chromium.googlesource.com/chromium/src/+/cc1bde6592ae5e0b5064e7680941569625db9d09

Comment 1 by ranjitkan@chromium.org, Apr 20 2017

Cc: -brettw@chromium.org ranjitkan@chromium.org phajdan.jr@chromium.org
Components: Tests>Flaky
Labels: Test-failure
Owner: brettw@chromium.org
Status: Assigned (was: Available)
This is also observed on Official desktop builder for Windows (Non PGO 32 bit), Linux & MAC OS for Build 60.0.3076.0

BuilD URL:
==========
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1729
https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/149

Log URL:
========
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1729/steps/base_unittests/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop/builders/linux64/builds/149/steps/base_unittests/logs/stdio

Assigning to reviewer and cc'ing other reviewer of the cl.

Kindly take a look into it.

Thanks.!

Comment 2 by alex...@yandex-team.ru, Apr 20 2017 

I reproduced this failure for official build. CL with fix: https://codereview.chromium.org/2831073002/

Comment 3 by h...@chromium.org, Apr 20 2017

Cc: thakis@chromium.org
This is firing on all our WinClang(ToT) bots too: https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4df548e4159bdcc2dcfe330eef756510ce45d0be

commit 4df548e4159bdcc2dcfe330eef756510ce45d0be
Author: alex-ac <alex-ac@yandex-team.ru>
Date: Thu Apr 20 17:42:38 2017

Fix LoggingTest.NestedLogAssertHandlers in official build.

R=mark
BUG= 713442 

Review-Url: https://codereview.chromium.org/2831073002
Cr-Commit-Position: refs/heads/master@{#466051}

[modify] https://crrev.com/4df548e4159bdcc2dcfe330eef756510ce45d0be/base/logging_unittest.cc

Comment 5 by thakis@chromium.org, Apr 20 2017

Cc: kcc@chromium.org p...@chromium.org krasin@chromium.org
 Issue 713794  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/297a914c51210df503dbdef10397d23604cd1270

commit 297a914c51210df503dbdef10397d23604cd1270
Author: hans <hans@chromium.org>
Date: Thu Apr 20 18:14:53 2017

Follow-up to LoggingTest.NestedLogAssertHandlers test fix in #466051

s/catched/caught/ and add a comment on why LOG() is used rather than CHECK().

BUG= 713442 

Review-Url: https://codereview.chromium.org/2827313003
Cr-Commit-Position: refs/heads/master@{#466074}

[modify] https://crrev.com/297a914c51210df503dbdef10397d23604cd1270/base/logging_unittest.cc

Comment 7 by manoranj...@chromium.org, Sep 21 2017

Status: Fixed (was: Assigned)
Marking it as 'Fixed'. Please update if someone thinks otherwise.
►

Sign in to add a comment