New issue
Advanced search Search tips

Issue 713438 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Consider supporting composited animation of visibility.

Project Member Reported by wkorman@chromium.org, Apr 19 2017

Issue description

Breakout from http://crbug.com/700790#c21

It appears that we don't currently composite animations that incorporate visibility. Sample test case attached.

I would think we could do this without much work by treating it like opacity to/from zero and one.

Filing this to track exploration and discussion. I don't have much background on how we came up with the current set of supported properties.
 
tremble.html
1.1 KB View Download
I explored quick hack just to see what code had to be touched, notes:

- add CSSPropertyVisibility to CompositorAnimations::kCompositableProperties
- add case to existing Opacity case in CompositorAnimations::IsCandidateForAnimationOnCompositor

We then end up failing in CompositorAnimations::GetAnimationOnCompositor where we also need to add a case to handle visibility.

There's existing logic for opacity that we could probably emulate but this is where I decided to pause for checkpoint with Animations team.
Labels: -Type-Bug Type-Feature
Owner: ----
Status: Available (was: Assigned)
Unassigning self as no plan to work on it currently. See also thread "Accelerating Visibility Animation" discussed with animations team.

Comment 4 by surma@chromium.org, May 22 2017

(A email thread[1] mentions UMA stats and links to this bug)

Keep in mind that the reason we see increased animations on visibility _might_ be because of AMP. Their markup[2] animates visibility as a fallback to reveal the page after 4 seconds if JavaScript takes to long/doesn’t run at all (it’s their FOUC protection mechanism). In their case turning it into an opacity-style animation might be undesired.

[1]: https://groups.google.com/a/google.com/forum/#!topic/threaded-rendering/ybNzkjypOY0
[2]: https://www.ampproject.org/docs/tutorials/create/basic_markup
Owner: majidvp@chromium.org
Assigning to majid to triage feasibility of compositing visibility animations.

Comment 6 by suzyh@chromium.org, Jun 13 2017

Cc: -suzyh@chromium.org
Project Member

Comment 7 by sheriffbot@chromium.org, Jun 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by yigu@chromium.org, Jun 14 2018

Labels: -Hotlist-Recharge-Cold
Owner: ----
Status: Available (was: Untriaged)

Sign in to add a comment