New issue
Advanced search Search tips

Issue 713429 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 87553



Sign in to add a comment

Default style of menu[type=context]

Project Member Reported by tkent@chromium.org, Apr 19 2017

Issue description

https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements

menu[type=context] should be display:none, but the current Chromium doesn't work so.
We need to update blink::LayoutTheme::ExtraDefaultStyleSheet().

 

Comment 1 by yuzus@chromium.org, Apr 24 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9380b0c8dbb73b5421652c5f5e1472307e51cfcf

commit 9380b0c8dbb73b5421652c5f5e1472307e51cfcf
Author: yuzus <yuzus@chromium.org>
Date: Mon Apr 24 23:04:03 2017

Change default style of menu[type=context]

This CL changes menu[type=context] style to display:none.
https://html.spec.whatwg.org/multipage/rendering.html#hidden-elements

BUG= 713429 

Review-Url: https://codereview.chromium.org/2827243002
Cr-Commit-Position: refs/heads/master@{#466810}

[modify] https://crrev.com/9380b0c8dbb73b5421652c5f5e1472307e51cfcf/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/9380b0c8dbb73b5421652c5f5e1472307e51cfcf/third_party/WebKit/LayoutTests/accessibility/presentation-owned-elements.html
[modify] https://crrev.com/9380b0c8dbb73b5421652c5f5e1472307e51cfcf/third_party/WebKit/LayoutTests/html/menu_menuitem/custom-context-menu-expected.txt
[rename] https://crrev.com/9380b0c8dbb73b5421652c5f5e1472307e51cfcf/third_party/WebKit/LayoutTests/html/menu_menuitem/menu-type-context-expected.html
[rename] https://crrev.com/9380b0c8dbb73b5421652c5f5e1472307e51cfcf/third_party/WebKit/LayoutTests/html/menu_menuitem/menu-type-context.html
[modify] https://crrev.com/9380b0c8dbb73b5421652c5f5e1472307e51cfcf/third_party/WebKit/LayoutTests/http/tests/misc/custom-context-menu-expected.txt
[modify] https://crrev.com/9380b0c8dbb73b5421652c5f5e1472307e51cfcf/third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Comment 3 by yuzus@chromium.org, Apr 25 2017

Status: Fixed (was: Started)

Sign in to add a comment