New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713428 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[MD settings] USB devices looks empty

Project Member Reported by dschuyler@chromium.org, Apr 19 2017

Issue description

in chrome://settings/content/usbDevices the page can be blank without explanation of what should be there.

Should/could there be some contents for this page
 
Screenshot from 2017-04-19 16:15:13.png
7.0 KB View Download

Comment 1 by dbeam@chromium.org, Apr 19 2017

Cc: srahim@chromium.org
yeah we need a "no USB devices found" string or something here

Comment 2 by bettes@chromium.org, Apr 21 2017

"No USB devices found" seems sufficient
Labels: Hotlist-MD-Settings-Privacy-SiteSettings

Comment 4 by srahim@chromium.org, Apr 25 2017

"No USB devices found" SGTM too
Owner: dschuyler@chromium.org
Status: Started (was: Assigned)
Screen shot of fixed version.
Screenshot from 2017-05-18 13:35:44.png
5.9 KB View Download
Project Member

Comment 9 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2c35ba3891bb703bbc67c57d63b6c0a2299131d

commit e2c35ba3891bb703bbc67c57d63b6c0a2299131d
Author: dschuyler <dschuyler@chromium.org>
Date: Fri May 19 20:37:38 2017

[MD settings] explain when no usb devices are shown in site settings

This CL shows an explanation in the USB devices content settings page
when no USB devices are found. (So that the page is not blank, which
looks/looked broken).

BUG= 713428 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2891163002
Cr-Commit-Position: refs/heads/master@{#473301}

[modify] https://crrev.com/e2c35ba3891bb703bbc67c57d63b6c0a2299131d/chrome/app/settings_strings.grdp
[modify] https://crrev.com/e2c35ba3891bb703bbc67c57d63b6c0a2299131d/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/e2c35ba3891bb703bbc67c57d63b6c0a2299131d/chrome/browser/resources/settings/site_settings/usb_devices.js
[modify] https://crrev.com/e2c35ba3891bb703bbc67c57d63b6c0a2299131d/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Status: Fixed (was: Started)

Sign in to add a comment