Provide a clickable link to gerrit code review on a trybot Build Properties page |
||||
Issue descriptionCQ build pages for Rietveld CLs have a clickable build property "issue", following which one gets to the CL that triggered that build, for example, https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9121. But, CQ build pages for Gerrit CLs do not. They only have "patch_issue" build property, which one has to use to manually get to the CL that triggered that build, for example, https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/9120.
,
Apr 21 2017
I think someone added that a while ago, there was some magic to parse out the "issue" field and linkify it. And by someone i meant tandrii: https://codereview.chromium.org/1476173002 Milo does it with swarmbucket builds. It does not do it for buildbot builds. Unassigning myself because I don't intend to work on the buildbot UI, but I'll take a bug for adding rietveld/gerrit link in builds for buildbot builds.
,
May 19 2017
,
May 19 2017
,
May 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/9d8e66c1f40b2318b042ebea3618d11fe831c689 commit 9d8e66c1f40b2318b042ebea3618d11fe831c689 Author: Aaron Gable <agable@chromium.org> Date: Sat May 20 00:37:13 2017 Link to gerrit changes from buildbot build properties Bug: 713421 Change-Id: I8b419efb5d4b1cd8f088ff5f0e84bf90fa72a793 Reviewed-on: https://chromium-review.googlesource.com/509970 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/9d8e66c1f40b2318b042ebea3618d11fe831c689/masters/master.tryserver.blink/templates/build.html [modify] https://crrev.com/9d8e66c1f40b2318b042ebea3618d11fe831c689/masters/master.tryserver.chromium.perf/templates/build.html [modify] https://crrev.com/9d8e66c1f40b2318b042ebea3618d11fe831c689/masters/master.tryserver.chromium.linux/templates/build.html
,
May 20 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/master-manager/+/66b8afc0ad660bf1fbb93fdeaa9a322425da3e96 commit 66b8afc0ad660bf1fbb93fdeaa9a322425da3e96 Author: Aaron Gable <agable@google.com> Date: Sat May 20 02:15:05 2017
,
May 22 2017
It's ALIVEEE!! https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/9827
,
Jun 1 2017
Did something break recently? There is no link here: https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/6050
,
Jun 1 2017
Weird, tryserver.blink is still working correctly: https://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/10283 And tryserver.chromium.android was restarted since the change landed: https://build.chromium.org/p/tryserver.chromium.android/json/clock?as_text=1 Looks like that master is pulling its templates from master.chromium, instead of from master.tryserver.chromium.linux. CL to fix here: https://chromium-review.googlesource.com/521685
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ffd660409419b112c350eae9817245fb274f8997 commit ffd660409419b112c350eae9817245fb274f8997 Author: Aaron Gable <agable@chromium.org> Date: Thu Jun 01 22:13:46 2017 Add gerrit patch links to more masters See https://chromium-review.googlesource.com/c/509970/ R=hinoka@chromium.org Bug: 713421 Change-Id: Ic6ef60ac707ae6eb41cf521c13a9c628c251386a Reviewed-on: https://chromium-review.googlesource.com/521685 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/ffd660409419b112c350eae9817245fb274f8997/masters/master.chromium/templates/build.html
,
Jun 5 2017
Still doesn't work on android_optional_gpu_tests_rel https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/6227 Is master restart needed, perhaps?
,
Jun 8 2017
Seems to work now: https://build.chromium.org/p/tryserver.chromium.android/builders/android_optional_gpu_tests_rel/builds/6229 Thanks a lot for fixing this! |
||||
►
Sign in to add a comment |
||||
Comment 1 by aga...@chromium.org
, Apr 21 2017Labels: -Restrict-View-Google Milestone-Launch Proj-Gerrit-Migration
Owner: hinoka@chromium.org
Status: Assigned (was: Untriaged)