New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 713420 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

pulling fingerprint biometrics manager path from service_constants.h

Project Member Reported by xiaoyinh@chromium.org, Apr 19 2017

Issue description

In biod_client.cc, instead of hard code the fingerprint biometrics manager path("/FpcBiometricsManager"), we should pull that constant from the service_constants.h.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58676cfe8124067c5e2945f235f47ea9e1ec7f6e

commit 58676cfe8124067c5e2945f235f47ea9e1ec7f6e
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Mon May 08 20:21:31 2017

Roll src/third_party/cros_system_api/ c6eab9e4d..6139ae009 + API change

Roll has 1 commit

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/c6eab9e4d0b4..6139ae00925a

$ git log c6eab9e4d..6139ae009 --date=short --no-merges --format='%ad %ae %s'
2017-04-19 mqg biod: add proto to biod

Created with:
  roll-dep src/third_party/cros_system_api

In addition to roll the cros_system_api, this CL works on the following:
1. Because the change in cros_system_api moved
biod::ScanResult from cros_system_api/dbus/service_constants.h
to cros_system_api/dbus/biod/constants.proto, we need to update
the files where we use biod::ScanResult

2. The change in cros_system_api added an optional parameter
percent_complete in EnrollScanDone signal and change the dbus message
to a protobuff. Update to dbus/biod and fingerprint_chromeos to incorporate this change.

A follow-up CL will modify fingerprint settings to use the
percent_complete parameter.

BUG= 713420 , 718076

Review-Url: https://codereview.chromium.org/2858003002
Cr-Commit-Position: refs/heads/master@{#470102}

[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/DEPS
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chrome/browser/chromeos/login/lock/screen_locker.h
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.h
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/BUILD.gn
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/biod_client.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/biod_client.h
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/biod_client_unittest.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/fake_biod_client.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/fake_biod_client.h
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/fake_biod_client_unittest.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/test_utils.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/chromeos/dbus/biod/test_utils.h
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/services/device/BUILD.gn
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/services/device/fingerprint/BUILD.gn
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/services/device/fingerprint/fingerprint_chromeos.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/services/device/fingerprint/fingerprint_chromeos.h
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/services/device/fingerprint/fingerprint_chromeos_unittest.cc
[modify] https://crrev.com/58676cfe8124067c5e2945f235f47ea9e1ec7f6e/services/device/public/interfaces/fingerprint.mojom

Status: Fixed (was: Assigned)

Sign in to add a comment