Support 'manual' (locked) Auto Exposure and Auto White Balance when available (API 23) |
||||||||||||||
Issue descriptionVideoCaptureCamera2.java cannot enumerate Auto Exposure lock [1] nor Auto White Balance lock [2] because they are not available in the current API target (21), but in 23. CONTROL_AE_LOCK_AVAILABLE: https://developer.android.com/reference/android/hardware/camera2/CameraCharacteristics.html#CONTROL_AE_LOCK_AVAILABLE CONTROL_AWB_LOCK_AVAILABLE: https://developer.android.com/reference/android/hardware/camera2/CameraCharacteristics.html#CONTROL_AWB_LOCK_AVAILABLE [1] https://cs.chromium.org/chromium/src/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java?q=videocapturecamera2.java&sq=package:chromium&dr&l=798 [2] https://cs.chromium.org/chromium/src/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java?q=videocapturecamera2.java&sq=package:chromium&dr&l=831
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fba7f46f286f5573abdcdd792f10e47b4e54380 commit 3fba7f46f286f5573abdcdd792f10e47b4e54380 Author: mcasas <mcasas@chromium.org> Date: Tue Apr 25 01:46:51 2017 Image Capture Android: bump class to API 23 (Marshmallow) to retrieve fixed-controls Bump SDK to 23 (marshmallow) and use the changes to allow retrieving fixed (exposure, white balance) controls BUG= 713417 Review-Url: https://codereview.chromium.org/2841543005 Cr-Commit-Position: refs/heads/master@{#466864} [modify] https://crrev.com/3fba7f46f286f5573abdcdd792f10e47b4e54380/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
,
Apr 25 2017
,
Apr 25 2017
,
Apr 25 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b33b080af2167bda097dd47e520f2316e9ffbe5a commit b33b080af2167bda097dd47e520f2316e9ffbe5a Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Tue Apr 25 01:54:57 2017 Image Capture Android: bump class to API 23 (Marshmallow) to retrieve fixed-controls Bump SDK to 23 (marshmallow) and use the changes to allow retrieving fixed (exposure, white balance) controls BUG= 713417 Review-Url: https://codereview.chromium.org/2841543005 Cr-Commit-Position: refs/heads/master@{#466864} (cherry picked from commit 3fba7f46f286f5573abdcdd792f10e47b4e54380) Review-Url: https://codereview.chromium.org/2841773002 . Cr-Commit-Position: refs/branch-heads/3071@{#190} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/b33b080af2167bda097dd47e520f2316e9ffbe5a/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
,
Apr 25 2017
,
Apr 25 2017
Verified in Chromium 60.0.3081.0! Works great ;) Thank you!
,
Apr 25 2017
Oops, there's more to it.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a40ccb58c0b71b3cc5f1a0416d556982268fb6c commit 1a40ccb58c0b71b3cc5f1a0416d556982268fb6c Author: mcasas <mcasas@chromium.org> Date: Tue Apr 25 21:48:41 2017 Image Capture: catch NoSuchFieldError if reading CONTROL_{AE,AWB}_LOCK_AVAILABLE where not available This CL adds a catch-ignore NoSuchFieldError exception, this is thrown reading the said fields in APIs >= 21 but < 23, where the constants identifying the fields are not defined. This is totally my bad: I thought unknown constants would return false, but instead they throw an Exception, which causes a crash, caught by fbeaufort@ :sweaty smile emoji: BUG= 713417 Review-Url: https://codereview.chromium.org/2844503002 Cr-Commit-Position: refs/heads/master@{#467127} [modify] https://crrev.com/1a40ccb58c0b71b3cc5f1a0416d556982268fb6c/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
,
Apr 25 2017
,
Apr 25 2017
,
Apr 25 2017
,
Apr 25 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97d03db2f6dfed77629857607ac3634a86de9f34 commit 97d03db2f6dfed77629857607ac3634a86de9f34 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Tue Apr 25 22:35:50 2017 Image Capture: catch NoSuchFieldError if reading CONTROL_{AE,AWB}_LOCK_AVAILABLE where not available This CL adds a catch-ignore NoSuchFieldError exception, this is thrown reading the said fields in APIs >= 21 but < 23, where the constants identifying the fields are not defined. This is totally my bad: I thought unknown constants would return false, but instead they throw an Exception, which causes a crash, caught by fbeaufort@ :sweaty smile emoji: BUG= 713417 Review-Url: https://codereview.chromium.org/2844503002 Cr-Commit-Position: refs/heads/master@{#467127} (cherry picked from commit 1a40ccb58c0b71b3cc5f1a0416d556982268fb6c) Review-Url: https://codereview.chromium.org/2835413004 . Cr-Commit-Position: refs/branch-heads/3071@{#208} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/97d03db2f6dfed77629857607ac3634a86de9f34/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
,
Apr 25 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by mcasas@chromium.org
, Apr 19 2017Components: -Blink>Image Blink>ImageCapture